From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.freebsd.org (mx2.freebsd.org [96.47.72.81]) by sourceware.org (Postfix) with ESMTPS id AE1D438618AC for ; Tue, 30 Jan 2024 16:50:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AE1D438618AC Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=FreeBSD.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=FreeBSD.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org AE1D438618AC Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=96.47.72.81 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1706633458; cv=pass; b=f6xzk8nSmBrrXBgnqV16Z69eQXD1oy9lYLJxAiyxY5q27fUTQlQjkO6aOvTe4n7WSbODzCl4t/5SKGwDFcr2uAijRvOuC1dfqlqaPJmiycUVYVzTjgZLGzONL14n5dQ9i88ovpufktFa3W/dJBYxqCIbtyTORrt8iY8DUa5M/CQ= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1706633458; c=relaxed/simple; bh=95ROfz+KUExHRUbxD2iwb3Zytn0M+ZWjzfQOkh+4TIs=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=I/JJw/Nc4LQr8ox2m2gYV+CSjO+Th9ogVQVHyulDny14qJOTKSUMpfMTvLWue1j4RxMCUNdJw90l5KDm+IJdxdseb/9ofufLOy9d4kPntKcuk5xa47e8/ZQm6CAAg8RYpSWoXeMbSqz3dSHDzI6EVkq8Bu5OCUn7j+LgoseiyEI= ARC-Authentication-Results: i=2; server2.sourceware.org Received: from mx1.freebsd.org (mx1.freebsd.org [96.47.72.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits)) (Client CN "mx1.freebsd.org", Issuer "R3" (verified OK)) by mx2.freebsd.org (Postfix) with ESMTPS id 4TPWQ823krz46tw; Tue, 30 Jan 2024 16:50:56 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TPWQ81KKRz48lG; Tue, 30 Jan 2024 16:50:56 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1706633456; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TW322EEore51ylH914Apa2B4gJp87NqTb0fulSGLGv4=; b=Ocp6G4D9MAhY9iZ2GxNrjiuB0xxG8UaourQIQvGwENRE50dFqzvUM6E7kasTvhDxu+BM7o pk+V/YY7K82Xz8hn9f0blVuq0FHIcT1Smp9UMoJCU7shnhfpKawFHrOyjESsRQwj8R1AY0 kDv0vACM3cU2AjGVC+m4yN6aKHLsAvjN90HbRYowrCSn0bPHWXegcyCfDaoMRlavHPBR0C JOCFpWqFAEbC8Ym0ZhdFW7SPRYGoyrtXeKfllc065Fp8CSKUcGWCR+DaLI0LpTcT6eR0kw aLrm4QIG/4J45JBKQmsUG8Tn3dM0zsn6uI/E1V7kS/VhAWkMSF0YfZUp16PraQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1706633456; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TW322EEore51ylH914Apa2B4gJp87NqTb0fulSGLGv4=; b=Hpj8C1aV2yv4GLhvbE4BxQwnZqtIvrSofQpd+E4SPYhORJ9jr/guNpCCJToanefkVfdAoa ySX1FUSBGlUXu7rDN1+7vVR2Bp3VAUk2t9XdzXnkEYjzdmztQ3ylPculBt7/0BSY2UCokE nfEptynj99GxitqfqB3Y+21eEIkYUHpFsjIGC4TTU0NMdeDgA4GEcqY+G4szfgohhIk8kH DuAd7aTYbJMilTkuMFz3JJ/vbjorebD9IcU0BLAwq+2b1hQpq/RKdBx0URSJtcq95YqWUs RXanUeD64G//razSvV3a80W7SpGB20K9xt42nggUwAXRnfwSBtKv1aHzQotPKw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1706633456; a=rsa-sha256; cv=none; b=JmCF3uMSoo/2DEmY+TmTC93kWKzB44G8OecmVNpWj6ph5lC4ev/NK9k4dU5yqPZPjd7K5A QLCNvfPmxc6nEAjM1lb+cKs3979b95EkcAUcWl0mV4s5fJW1t3wi+588LpfX3K0tGnRBR5 Se4PNiMo1C0DGXSeVwoLtAj5XZ1kxcHEpGa8NXYINCIZp8f/rdfrJrKjwTmhxVEWYKojQQ B1RhqvD00afQI9msEyWhxYRok3CJbVDOK9OxSuCZZMnOuHmsnKe5d7FBKr3vciTxO0Np3N qLHmXswSRCLnMZwHJUs2m3LtYjTshHNut1ix++USuMgyY568tlUaRt1nF/OC6g== Received: from [IPV6:2601:644:9381:f410:d8c0:5df4:d966:b8b8] (unknown [IPv6:2601:644:9381:f410:d8c0:5df4:d966:b8b8]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4TPWQ75mgyz1j19; Tue, 30 Jan 2024 16:50:55 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: Date: Tue, 30 Jan 2024 08:50:53 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Really fix Windows gdbserver segment registers Content-Language: en-US To: Tom Tromey , gdb-patches@sourceware.org References: <20240124150044.2881846-1-tromey@adacore.com> From: John Baldwin In-Reply-To: <20240124150044.2881846-1-tromey@adacore.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 1/24/24 7:00 AM, Tom Tromey wrote: > My earlier attempt to mask the segment registers in gdbserver for > Windows introduced some bugs. That patch is here: > > https://sourceware.org/pipermail/gdb-patches/2023-December/205306.html > > The problem turned out to be that these fields in the Windows > 'CONTEXT' type are just 16 bits, so while masking the values on read > is fine, writing the truncated values back then causes zeros to be > written to some subsequent field. > > This patch cleans this up by arranging never to write too much data to > a field. > > I also noticed that two register numbers here were never updated for > the 64-bit port. This patch fixes this as well, and renames the "FCS" > register to follow gdb. > > Finally, this patch applies the same treatment to windows-nat.c. LGTM as far as I understand it. Reviewed-by: John Baldwin -- John Baldwin