From: Thomas Preudhomme <thomas.preudhomme@foss.arm.com>
To: Pedro Alves <palves@redhat.com>,
Toshihito Kikuchi <k.toshihito@yahoo.de>,
gdb-patches@sourceware.org
Cc: Simon Marchi <simon.marchi@ericsson.com>
Subject: Re: [PATCH v5] Add negative repeat count to 'x' command
Date: Thu, 11 Aug 2016 14:08:00 -0000 [thread overview]
Message-ID: <d3d1ec85-edae-ac23-3dd6-236606fb8573@foss.arm.com> (raw)
In-Reply-To: <50dbd13a-52a2-9687-ace0-5aa51e1bc1d1@foss.arm.com>
Hi Pedro,
On 11/08/16 13:51, Thomas Preudhomme wrote:
>>
>> The find-strings-backwards algorithm just looks back for '\0' to
>> find string boundaries. Looks like it just happens that in your
>> case, the TestStrings array is immediately preceded by the
>> tail of _fini, with no gap in between.
>>
>> Try this. It's not strictly correct to assume that the linker
>> places the objects consecutively, but it's probably safe
>> in practice.
>
> The patch works indeed. Thanks for your quick answer.
While trying this I noticed that the following 2 tests fail when running with
qemu-user (it works with qemu-system):
gdb.base/examine-backward.exp: address zero boundary: examine 6 bytes backward
gdb.base/examine-backward.exp: address zero boundary: examine 3 bytes backward
from 0x0
They fail with:
0xfffffffd: Cannot access memory at address 0xfffffffd
I suppose these two tests should also be guarded or maybe have several expected
results.
Best regards,
Thomas
next prev parent reply other threads:[~2016-08-11 14:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-02 8:52 Toshihito Kikuchi
2016-06-03 10:54 ` Pedro Alves
2016-06-10 6:02 ` Toshihito Kikuchi
2016-08-08 14:45 ` Thomas Preudhomme
2016-08-11 0:00 ` Pedro Alves
2016-08-11 12:51 ` Thomas Preudhomme
2016-08-11 14:08 ` Thomas Preudhomme [this message]
2016-08-11 16:32 ` Pedro Alves
2016-08-16 14:03 ` Thomas Preudhomme
2016-08-19 18:59 ` Pedro Alves
2016-09-06 14:28 ` Thomas Preudhomme
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d3d1ec85-edae-ac23-3dd6-236606fb8573@foss.arm.com \
--to=thomas.preudhomme@foss.arm.com \
--cc=gdb-patches@sourceware.org \
--cc=k.toshihito@yahoo.de \
--cc=palves@redhat.com \
--cc=simon.marchi@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).