From: Simon Marchi <simark@simark.ca>
To: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Remove some unnecessary includes from *-exp.y
Date: Mon, 20 Mar 2023 11:45:33 -0400 [thread overview]
Message-ID: <d3f69d45-70d3-bcd1-9bd0-28cb8b605966@simark.ca> (raw)
In-Reply-To: <20230318144450.1928512-1-tom@tromey.com>
On 3/18/23 10:44, Tom Tromey wrote:
> I noticed a weird comment in one of the .y files, and then ended up
> removing some unnecessary #includes from these files.
If it builds, it seems fine to me. Those comments (that tell why an
include is used) almost seem useless to me, as it's nearly impossible to
maintain them.
It's hard to know if something in these files does need one of the
headers you remove, and if you now make them rely on indirect
inclusions. But again, if it builds, there's no harm done. They can
always be re-added if a problem relocated to indirect inclusion shows up
later.
Approved-By: Simon Marchi <simon.marchi@efficios.com>
Simon
next prev parent reply other threads:[~2023-03-20 15:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-18 14:44 Tom Tromey
2023-03-20 15:45 ` Simon Marchi [this message]
2023-03-20 21:22 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d3f69d45-70d3-bcd1-9bd0-28cb8b605966@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).