From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 104145 invoked by alias); 26 Feb 2020 16:27:30 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 104136 invoked by uid 89); 26 Feb 2020 16:27:29 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-5.2 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 26 Feb 2020 16:27:28 +0000 Received: from [172.16.0.95] (192-222-181-218.qc.cable.ebox.net [192.222.181.218]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 7A2C71E5F9; Wed, 26 Feb 2020 11:27:26 -0500 (EST) Subject: Re: [PATCH 1/2] Remove casts from dwarf2/index-write.c To: Tom Tromey , gdb-patches@sourceware.org References: <20200225130932.6861-1-tom@tromey.com> <20200225130932.6861-2-tom@tromey.com> From: Simon Marchi Message-ID: Date: Wed, 26 Feb 2020 16:27:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200225130932.6861-2-tom@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2020-02/txt/msg00979.txt.bz2 On 2020-02-25 8:09 a.m., Tom Tromey wrote: > dwarf2/index-write.c casts pointers to "dwarf2_psymtab *", but as far > as I can tell, it does not actually use any DWARF-specific fields of > the psymtab. So, this patch changes this code to use partial_symtab > instead. This removes nearly every cast, leaving just the unavoidable > one from addrmap iteration. Thanks, that LGTM. Simon