From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 2A7683858D20 for ; Fri, 3 Feb 2023 16:05:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2A7683858D20 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=polymtl.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=polymtl.ca Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 313G5Elh003292 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 3 Feb 2023 11:05:19 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 313G5Elh003292 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=default; t=1675440319; bh=xnJrsKsR7XTnHVdZQIqZ47GL7iLVl2o8LwjIN5fRswY=; h=Date:Subject:To:References:From:In-Reply-To:From; b=bALzVvkBXeV0RFKgjQDRuDBruiRI3esIJgOIdFK4z7ZPMePmN3MfVBJrzLSkzTv2c ziV0LWYwY6EZqEW24Ds5aGT1WnD/oxQHGLVLA9l8Uvs4vOr8rIhgibmq8kJJy3lGV3 pAYLkpQRl8evcMY8lJPx+ICp/ZzjSfugkJ2oJZpA= Received: from [172.16.0.192] (192-222-180-24.qc.cable.ebox.net [192.222.180.24]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 998361E110; Fri, 3 Feb 2023 11:05:14 -0500 (EST) Message-ID: Date: Fri, 3 Feb 2023 11:05:13 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 3/5] gdb: remove get_tdesc_info Content-Language: fr To: Andrew Burgess , Simon Marchi via Gdb-patches References: <20230203142126.286866-1-simon.marchi@polymtl.ca> <20230203142126.286866-4-simon.marchi@polymtl.ca> <874js2sq3c.fsf@redhat.com> From: Simon Marchi In-Reply-To: <874js2sq3c.fsf@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Fri, 3 Feb 2023 16:05:14 +0000 X-Spam-Status: No, score=-3037.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2/3/23 10:53, Andrew Burgess wrote: > Simon Marchi via Gdb-patches writes: > >> Remove this function, since it's now a trivial access to >> inferior::tdesc_info. >> >> Change-Id: I3e88a8214034f1a4163420b434be11f51eef462c >> --- >> gdb/target-descriptions.c | 28 ++++++++++------------------ >> 1 file changed, 10 insertions(+), 18 deletions(-) >> >> diff --git a/gdb/target-descriptions.c b/gdb/target-descriptions.c >> index 049e42c7ea77..0561a8098c5c 100644 >> --- a/gdb/target-descriptions.c >> +++ b/gdb/target-descriptions.c >> @@ -436,14 +436,6 @@ struct tdesc_arch_data >> gdbarch_register_reggroup_p_ftype *pseudo_register_reggroup_p = NULL; >> }; >> >> -/* Get the inferior INF's target description info. */ >> - >> -static struct target_desc_info * >> -get_tdesc_info (struct inferior *inf) >> -{ >> - return &inf->tdesc_info; >> -} >> - >> /* A handle for architecture-specific data associated with the >> target description (see struct tdesc_arch_data). */ >> >> @@ -472,8 +464,8 @@ target_desc_info_from_user_p (struct target_desc_info *info) >> void >> copy_inferior_target_desc_info (struct inferior *destinf, struct inferior *srcinf) >> { >> - struct target_desc_info *src = get_tdesc_info (srcinf); >> - struct target_desc_info *dest = get_tdesc_info (destinf); >> + struct target_desc_info *src = &srcinf->tdesc_info; >> + struct target_desc_info *dest = &destinf->tdesc_info; >> >> *dest = *src; > > Would: > > destinf->tdesc_info = srcinf->tdesc_info; > > not be better now? For others: this disappears in the next patch anyway. Simon