From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by sourceware.org (Postfix) with ESMTPS id 9A16A3858D34 for ; Wed, 6 Mar 2024 17:15:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9A16A3858D34 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 9A16A3858D34 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709745344; cv=none; b=d9tZuKMaCvNLmpkAuLlciW3vJK/sGKF5uf29+vXhqAnhPLtOivkVkvAAS5V2feH74AZ41rRKYyPX6mRr2VS6pM1LryvJz//kA6ehEmFQ81ii3rIVPpkDIj5HxC7aHYsr6MWbtZzp+7U6Q7pLSgcloo8q9UZ9+/PqznSDi0yfuEU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709745344; c=relaxed/simple; bh=mN6bqpsBiEFMt10b5N8tPCQWrIJzd2NnM2OWs6ky8h0=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=PDCYaV5Cn96hvf7PZ6T5rAFcM7dJL3vx6m52ORLjgH2fSS/LIe9pMFDjdRlXk2ED7MRa8q/xM2QWN7ojLxK+C/9TN/FM8+Qa1gXy5h17qwy2CsnmEX/fGIvk8LnNs34DzeWt7a//Jt8YLSJyxDA7G9hiDLfXxh4uqN8jl5c/9G8= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 8670A4621; Wed, 6 Mar 2024 17:15:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1709745340; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+W67cfC7Oh6VeK+1WiNO2H9La7Iz/j2oNUZ7d2nVY4Q=; b=nhACBXZE/ahaSL+bC9PNlO5602H+cisdKBlkFfLt7IO952MJ8utO57Za0MPnT6tYgauOKS Z14fMSQU8owRRnrOTeoM2sQdAEjd+NNOu0H0Aih1eqcrIPEFtGdHdjwbiMXU+CIsZS0wTQ bfwNT5n4RguTdvfVbN3FwsTkEvclY+g= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1709745340; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+W67cfC7Oh6VeK+1WiNO2H9La7Iz/j2oNUZ7d2nVY4Q=; b=+4FiCrXIBpSLx3bp1FnHIEOfkVosfO1klshtndqdWH18mBnk8djVgUjGNiUPCojX8zDgzz FgkECacftDJ2bjBQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1709745340; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+W67cfC7Oh6VeK+1WiNO2H9La7Iz/j2oNUZ7d2nVY4Q=; b=nhACBXZE/ahaSL+bC9PNlO5602H+cisdKBlkFfLt7IO952MJ8utO57Za0MPnT6tYgauOKS Z14fMSQU8owRRnrOTeoM2sQdAEjd+NNOu0H0Aih1eqcrIPEFtGdHdjwbiMXU+CIsZS0wTQ bfwNT5n4RguTdvfVbN3FwsTkEvclY+g= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1709745340; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+W67cfC7Oh6VeK+1WiNO2H9La7Iz/j2oNUZ7d2nVY4Q=; b=+4FiCrXIBpSLx3bp1FnHIEOfkVosfO1klshtndqdWH18mBnk8djVgUjGNiUPCojX8zDgzz FgkECacftDJ2bjBQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 6EC4B13A65; Wed, 6 Mar 2024 17:15:40 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id x2KHGbyk6GXvdAAAD6G6ig (envelope-from ); Wed, 06 Mar 2024 17:15:40 +0000 Message-ID: Date: Wed, 6 Mar 2024 18:16:13 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/2] gdb/testsuite: reduce gdb.threads/threadcrash.exp reliance on libc symbols Content-Language: en-US To: Guinevere Larsen , gdb-patches@sourceware.org References: <20240214091712.223928-2-blarsen@redhat.com> <20240214091712.223928-4-blarsen@redhat.com> From: Tom de Vries In-Reply-To: <20240214091712.223928-4-blarsen@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Authentication-Results: smtp-out2.suse.de; none X-Spam-Level: X-Spam-Score: -3.02 X-Spamd-Result: default: False [-3.02 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; XM_UA_NO_VERSION(0.01)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; BAYES_HAM(-1.75)[93.47%]; MIME_GOOD(-0.10)[text/plain]; NEURAL_HAM_LONG(-1.00)[-1.000]; RCVD_COUNT_THREE(0.00)[3]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.18)[-0.924]; RCPT_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:email]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[] X-Spam-Status: No, score=-12.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2/14/24 10:17, Guinevere Larsen wrote: > The test gdb.threads/threadcrash.exp demanded GDB to fully unwind and > print the names of all functions. However, some of the functions are > from the libc library, and so the test implicitly demanded libc symbols > to be available, and would fail otherwise, as was raised in PR > gdb/31293. > > This commit changes it so we only explicitly check for functions that > are provided by threadcrash.c to fix that Hi Gwen, Nit: Missing dot at end of line. With that fixed, LGTM. Approved-By: Tom de Vries Thanks, - Tom > > Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=31293 > --- > gdb/testsuite/gdb.threads/threadcrash.exp | 17 +++++++---------- > 1 file changed, 7 insertions(+), 10 deletions(-) > > diff --git a/gdb/testsuite/gdb.threads/threadcrash.exp b/gdb/testsuite/gdb.threads/threadcrash.exp > index bf4534179e2..2bbedcce58e 100644 > --- a/gdb/testsuite/gdb.threads/threadcrash.exp > +++ b/gdb/testsuite/gdb.threads/threadcrash.exp > @@ -40,26 +40,23 @@ proc thread_apply_all {} { > exp_continue > } > -re "\[^\n\]*syscall_task .location=SIGNAL_ALT_STACK\[^\n\]*" { > - lappend test_list [multi_line ".*sleep.*" \ > - ".*do_syscall_task .location=SIGNAL_ALT_STACK.*" \ > + lappend test_list [multi_line ".*do_syscall_task .location=SIGNAL_ALT_STACK.*" \ > ".*signal_handler.*" \ > ".*signal handler called.*" \ > - ".*pthread_kill.*" \ > + ".*" \ > ".*thread_function.*"] > exp_continue > } > -re "\[^\n\]*syscall_task .location=SIGNAL_HANDLER\[^\n\]*" { > - lappend test_list [multi_line ".*sleep.*" \ > - ".*do_syscall_task .location=SIGNAL_HANDLER.*" \ > + lappend test_list [multi_line ".*do_syscall_task .location=SIGNAL_HANDLER.*" \ > ".*signal_handler.*" \ > ".*signal handler called.*" \ > - ".*pthread_kill.*" \ > + ".*" \ > ".*thread_function.*"] > exp_continue > } > -re "\[^\n\]*syscall_task .location=NORMAL\[^\n\]*" { > - lappend test_list [multi_line ".*sleep.*" \ > - ".*do_syscall_task .location=NORMAL.*" \ > + lappend test_list [multi_line ".*do_syscall_task .location=NORMAL.*" \ > ".*thread_function.*"] > exp_continue > } > @@ -67,7 +64,7 @@ proc thread_apply_all {} { > lappend test_list [multi_line ".*do_spin_task .location=SIGNAL_ALT_STACK.*" \ > ".*signal_handler.*" \ > ".*signal handler called.*" \ > - ".*pthread_kill.*" \ > + ".*" \ > ".*thread_function.*"] > exp_continue > } > @@ -75,7 +72,7 @@ proc thread_apply_all {} { > lappend test_list [multi_line ".*do_spin_task .location=SIGNAL_HANDLER.*" \ > ".*signal_handler.*" \ > ".*signal handler called.*" \ > - ".*pthread_kill.*" \ > + ".*" \ > ".*thread_function.*"] > exp_continue > }