From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=zGFB=EQ=suse.de=tdevries@sourceware.org>
Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c])
	by sourceware.org (Postfix) with ESMTPS id 75D543858C2B
	for <gdb-patches@sourceware.org>; Thu, 31 Aug 2023 08:00:26 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 75D543858C2B
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
	(No client certificate requested)
	by smtp-out1.suse.de (Postfix) with ESMTPS id 6CF7C21862;
	Thu, 31 Aug 2023 08:00:25 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa;
	t=1693468825; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:
	 mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=PFHls6hjSSAdLALu3YKWYaQPYbX96MdzrJATqsRXTRg=;
	b=VCWvFAYMYG2dUyyYsKWJQsqVrrMrzAuZccE4N+pHon6zDXS0KEEBHNHI9+uo4hyOBnhVFM
	LrJjerMqCF2lfZ2hjLNQgiUsU75lLy3838g8viYf0dtCsQjg8JlKLm8ccIeYU9kbhuBKZG
	d9kNK2MbJjbg1oTCEUvS+3ASAnhcI80=
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;
	s=susede2_ed25519; t=1693468825;
	h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:
	 mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=PFHls6hjSSAdLALu3YKWYaQPYbX96MdzrJATqsRXTRg=;
	b=dSJibsQjDkoQ0g8hTGv/q/UoPtj7JBZwJK3NPiKa5vp/OrjoqPM7e5/jt5qUMCsxoWT+/3
	m0Uk37+rjk/hpoCg==
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
	(No client certificate requested)
	by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 5919B13587;
	Thu, 31 Aug 2023 08:00:25 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
	by imap2.suse-dmz.suse.de with ESMTPSA
	id e2GRFJlI8GRoZgAAMHmgww
	(envelope-from <tdevries@suse.de>); Thu, 31 Aug 2023 08:00:25 +0000
Message-ID: <d4315839-9add-ff09-2a12-554947bb3ab2@suse.de>
Date: Thu, 31 Aug 2023 10:00:18 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 5/6] [gdb/symtab] Replace TYPE_ALLOC + B_CLRALL with
 TYPE_ZALLOC
Content-Language: en-US
To: Tom Tromey <tom@tromey.com>,
 Tom de Vries via Gdb-patches <gdb-patches@sourceware.org>
References: <20230830191336.15885-1-tdevries@suse.de>
 <20230830191336.15885-5-tdevries@suse.de> <87edjkqo1b.fsf@tromey.com>
From: Tom de Vries <tdevries@suse.de>
In-Reply-To: <87edjkqo1b.fsf@tromey.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <gdb-patches.sourceware.org>

On 8/30/23 22:21, Tom Tromey wrote:
>>>>>> "Tom" == Tom de Vries via Gdb-patches <gdb-patches@sourceware.org> writes:
> 
> Tom> I noticed some cases of TYPE_ALLOC followed by B_CLRALL.
> Tom> Replace these with TYPE_ZALLOC.
> 
> Looks good.
> I wonder if B_CLRALL is still used anywhere after this.

I guess not:
...
$ find gdb* -type f | egrep -v ChangeLog | xargs grep B_CLR
gdb/gdbtypes.h:#define B_CLR(a,x)	((a)[(x)>>3] &= ~(1 << ((x)&7)))
gdb/gdbtypes.h:#define	B_CLRALL(a,x)	memset ((a), 0, B_BYTES(x))
...

Thanks,
- Tom