public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Pedro Alves <pedro@palves.net>
To: Tom de Vries <tdevries@suse.de>, gdb-patches@sourceware.org
Subject: Re: [PATCH][gdb/build] Fix build with gcc 4.8.5
Date: Tue, 12 Jul 2022 12:36:11 +0100	[thread overview]
Message-ID: <d438d025-4ae1-9806-5715-d9d8f1f4bc0e@palves.net> (raw)
In-Reply-To: <20220712113125.GA14559@delia.home>

On 2022-07-12 12:31 p.m., Tom de Vries wrote:
> Hi,
> 
> When building gdb with gcc 4.8.5, we run into problems due to unconditionally
> using:
> ...
>      gdb_static_assert (std::is_trivially_copyable<packed>::value);
> ...
> in gdbsupport/packed.h.
> 
> Fix this by guarding the usage with HAVE_IS_TRIVIALLY_COPYABLE.
> 
> Tested by doing a full gdb build with gcc 4.8.5.
> 
> Any comments?

This is OK, thanks.

      reply	other threads:[~2022-07-12 11:36 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-12 11:31 Tom de Vries
2022-07-12 11:36 ` Pedro Alves [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d438d025-4ae1-9806-5715-d9d8f1f4bc0e@palves.net \
    --to=pedro@palves.net \
    --cc=gdb-patches@sourceware.org \
    --cc=tdevries@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).