From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 034383858D37 for ; Thu, 9 Mar 2023 01:58:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 034383858D37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca Received: from [10.0.0.11] (unknown [217.28.27.60]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 7D8811E128; Wed, 8 Mar 2023 20:58:32 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1678327112; bh=Lp0RUbx63loY2SfJKIajMhcgz0ttnnOEvEBhvjZ+5Es=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=IdIlhpNlLlg0wnxHpKEPXsBAyTQRNiE4z6eK2X3VGdL5yIAhoy5P3555Nix1BiNpK lGF1qUg59AVX2Ryj9CSreekk1UBYus8mAsY5pOQ0ooWqWw71OL1aUohvX0zNDWkufJ g4pQp2VIAvvvdSvIOKRjWHKYRTP+AHztv+OkaO9c= Message-ID: Date: Wed, 8 Mar 2023 20:58:32 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH v2] Ensure index cache entry written in test Content-Language: en-US To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20230306164553.1449009-1-tromey@adacore.com> <87sfegsj5f.fsf@tromey.com> <2fd34bd5-fe16-e2d4-7585-f693fdc5d8dd@simark.ca> <87h6uws9jh.fsf@tromey.com> From: Simon Marchi In-Reply-To: <87h6uws9jh.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 3/7/23 13:25, Tom Tromey wrote: > Simon> Heh, we get that now: > > Simon> (gdb) maintenance selftest help > Simon> Running selftest help_doc_invariants. > Simon> help doc broken invariant: command 'maintenance wait-for-index-cache' help doc first line is not terminated with a '.' character > Simon> Self test failed: self-test failed at /home/simark/src/binutils-gdb/gdb/unittests/command-def-selftests.c:99 > Simon> Ran 1 unit tests, 1 failed > > Ugh, sorry. > I'll send a fix in a second. > > Tom For the record, I still see this intermittently on my CI: FAIL: gdb.base/index-cache.exp: test_cache_enabled_hit: no files were created FAIL: gdb.base/index-cache.exp: test_cache_enabled_hit: check index-cache stats So there must be something else... I'll try to investigate. Simon