From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) by sourceware.org (Postfix) with ESMTPS id F3893384DD8C for ; Mon, 12 Dec 2022 20:16:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org F3893384DD8C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr1-f48.google.com with SMTP id h12so13375255wrv.10 for ; Mon, 12 Dec 2022 12:16:12 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:references:to:subject:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XI9FHZpctKRMqeLg/dyh6YlHZ+b/SAjdtljNS67mhWM=; b=OlpC9+67nq79W9g2fXmqpQNbbGmboT1DA7ZjUe4A2dWgwTwAoxGW8wBbGVl/vMC7NQ LDVuakPTLGiSUO/RccSEy9RzbqRqnjU6Xyagi8BefjB9tqpyO6To2xqTF6qayiPBIy5W GW0UAcr7RmoxhGv91clGCzUaOYBq8Kj3X82S/5Q70uzQsfRoQOPw9d/PopNfNAdLJINM 63+q02gztYXApLz5XMXFOmyhxXh6Cqopy6VQcW2v1pn5GRoyhk7WKOo2LDwXR3kJiKhE 3mE16+PixoPBCkqosvb7I4VkQfQHKetE9Ta2/2m9SAOV8JP6b6SEjuXNfbOxbVPhNzQz Ly8Q== X-Gm-Message-State: ANoB5plY1Z3eLWBDtw3m7IxaaqVWmk3gRxi3v5MAK8qt+CmwLbn2Y44D hBrr/CDdKkN0AFntKHKde/HY1BDCbzQZpQ== X-Google-Smtp-Source: AA0mqf7t028MncQ9FoKJoBFwijpqwUoY3He0hb7uCEgTCVGoYNr/N1HVmwaOzQMEzPPIC3gkNTJsAQ== X-Received: by 2002:a5d:4c87:0:b0:246:e6df:86e7 with SMTP id z7-20020a5d4c87000000b00246e6df86e7mr9493778wrs.5.1670876171934; Mon, 12 Dec 2022 12:16:11 -0800 (PST) Received: from ?IPv6:2001:8a0:f912:6700:afd9:8b6d:223f:6170? ([2001:8a0:f912:6700:afd9:8b6d:223f:6170]) by smtp.gmail.com with ESMTPSA id n11-20020adff08b000000b0023662d97130sm9829119wro.20.2022.12.12.12.16.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 Dec 2022 12:16:11 -0800 (PST) From: Pedro Alves Subject: Re: [PATCH v2 09/29] Thread options & clone events (Linux GDBserver) To: Simon Marchi , gdb-patches@sourceware.org References: <20220713222433.374898-1-pedro@palves.net> <20220713222433.374898-10-pedro@palves.net> Message-ID: Date: Mon, 12 Dec 2022 20:16:17 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2022-07-21 2:11 p.m., Simon Marchi wrote: > >> @@ -4268,15 +4280,16 @@ linux_set_resume_request (thread_info *thread, thread_resume *resume, size_t n) >> continue; >> } >> >> - /* Don't let wildcard resumes resume fork children that GDB >> - does not yet know are new fork children. */ >> + /* Don't let wildcard resumes resume fork/clone children >> + that GDB does not yet know are new children. */ >> if (lwp->fork_relative != NULL) >> { >> struct lwp_info *rel = lwp->fork_relative; >> >> if (rel->status_pending_p >> && (rel->waitstatus.kind () == TARGET_WAITKIND_FORKED >> - || rel->waitstatus.kind () == TARGET_WAITKIND_VFORKED)) >> + || rel->waitstatus.kind () == TARGET_WAITKIND_VFORKED >> + || rel->waitstatus.kind () == TARGET_WAITKIND_THREAD_CLONED)) > > This "is target_waitstatus with child" condition comes back again a few > times, this could the helper function I mentioned earlier. > Indeed, fixed. > Other than that, the changes in handle_extended_wait are quite > important, so it's a bit hard to be convinced it's all right, but I > didn't spot anything wrong. > Thanks.