From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from CAN01-YT3-obe.outbound.protection.outlook.com (mail-yt3can01on2076.outbound.protection.outlook.com [40.107.115.76]) by sourceware.org (Postfix) with ESMTPS id A62AC3858D28 for ; Wed, 24 May 2023 14:51:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A62AC3858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=efficios.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=m09twpFDIdfMi15ctiPfA12vrIV+GdPDrYeVTvOiFeBlePJZoiQsTduZzdpkw1QtCIvWmxsCdQNRTv9rR01LKciVMb7t9gWKpfk1h1/4BiwYbH4iuNWSSEZLR/w5UjlksSeXFejSLWsasJpOWyetsSUVo53pqJvvFkNVIYYPo2iaw4nZwJdbSu7u6IxIF5RKxzvnP4RV7nGgIwd8fY4fxuiHTHodEOaREtcr4n555BKDU6CHNw58fJA/Kw3Z2TByCGp1xI7piMZr+MJb8y6/WTKXJnaHqL8Wr1swojmHjobaWM/9RDxP/fJ9yI78WNdRkSxeDJOa/Th/leV2QpdCMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lFdP5DLCLcgcnQ0x/kIvs5CodbEN8sOGPCzyvz4YHfE=; b=JaEqwnjqLhygaoPc4OZLRC5cUShAwOAHSOYLOysl/q/mB2BhhD0ooRSp+ekK7Xz4spQS8ZMXymrOSeiwkhFOtvH+USyVCz6YbZiewtFMdJRwGYYfra7KsyE+u1rYY7+KNEE045GrCGt8ReQ06FdTU9RtHlPWnaH3FMDf1Z9TdD8zJuBR3cbDCWO6kipY1hli6joxuXC0kJ7VHk5b2B2LlPbv0KtYhuHSwi7NljcvRha59Wdu2ACVh8vcymVtIQxRpE9V6DpC27THzNPLB0FmMM8tdGz3z3RbGVtazdkcIu8eT2WxpBW5ltNqwrYEiTtWmeNOK9ssYILmqj+LMWh6UQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=efficios.com; dmarc=pass action=none header.from=efficios.com; dkim=pass header.d=efficios.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lFdP5DLCLcgcnQ0x/kIvs5CodbEN8sOGPCzyvz4YHfE=; b=KxH/5RfFtndQb981MU0bohh0ee7sos97s9nMspq5U4QP8Hd5pojQuFxC3g4lh2e/fk1kosqvOlGlSXUJWFz6CaCiAircuefvYLEtaHRv+lLIt4/o4M7NrkBS5zwXYBMVaIelgIdQCw2D5yFpcxEzw8zjWtEGC2VNADpw4fkT8YatNV3TRiCe/Oun+JyXNIISh+lzaJjAD8FuumnMgMYAHW5Mkgq0aIlOdyLdVJ0aH8uL5cusJHgm1fHArumphcacAZD0HSGLRKYKsRFR4pMq5pXNyf/UWEgQnE4UfaKyIWe4IiPdUBbqgmRXG6RokoT0q7OlgSDn8jmZaZMbnpsRBQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=efficios.com; Received: from YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:a::23) by YQBPR0101MB8302.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:51::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6433.15; Wed, 24 May 2023 14:51:48 +0000 Received: from YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM ([fe80::28e9:8b26:5c7a:46a8]) by YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM ([fe80::28e9:8b26:5c7a:46a8%3]) with mapi id 15.20.6433.015; Wed, 24 May 2023 14:51:48 +0000 Message-ID: Date: Wed, 24 May 2023 10:51:47 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH] gdbsupport: add support for references to checked_static_cast Content-Language: fr To: Andrew Burgess , Simon Marchi via Gdb-patches References: <20230518205737.403656-1-simon.marchi@efficios.com> <878rdd7u9p.fsf@redhat.com> From: Simon Marchi In-Reply-To: <878rdd7u9p.fsf@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: YT4PR01CA0192.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:110::13) To YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:a::23) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: YT1PR01MB2828:EE_|YQBPR0101MB8302:EE_ X-MS-Office365-Filtering-Correlation-Id: eacf3f6c-919d-44ca-7924-08db5c66668b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: FZdnHvVZ68f9dtzfVsVbQgDMNXjZvsVYutmx2cw2ZyfC+hGlXyXt32TVX82rTnquJuuFArO8rRLlGLjyRjpgL7upy622DW8tUpMxcsNLGYvW9aluJlSCZugaX0pn3sftvnKMIV3L0aVUW2G4y3sOaMLVfQq3NHlft4KKrP7VnbPuJWuIzq+8hMvPhWk18u4Xl7oCNkgXexczTRqa0o28gmiGX1Gx2uQ7AbRx+Llc607yijtHl8FEKECmGHMhMmDokQyTUUOC9XyxlnmxbXshZpzP4TUAVXDUDoViV/NWIV1YWBU/oIo7WqW1aCqhoYnZyT3jmvBAI1u2DJt6YYq4ZwexnT4z7xoENnmDeRDS6UYQKSQmyQnu4WJuWOvI8DnKuuyckdtd0KMZlsV8yPS0bCzbGBYo6ZiIs7F83b77ftpQ2yRKRBlxCVKDO+bk3g5f4B8lGBYTBzdIK5L+PfbLlONJ60UW0kLYQjB1IqYCFkbpwgapSigrqiCPSwjRFaa6cpmgptTceY3A6wzvDxLbMt1u3Xly6TDkub1/5VzR3eIvTWrKkGg6f5/JcoN23l0N90gcBKie/zXMAnaoUQ5SjCVxGJw0ZYddfVp52ewje3CCRjHHUKdb8KbbO+LtbtXigONerdheVOKx8t0kN8xiIg== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFS:(13230028)(366004)(396003)(39830400003)(346002)(376002)(136003)(451199021)(478600001)(6486002)(31686004)(110136005)(53546011)(26005)(6506007)(6512007)(66476007)(186003)(66946007)(66556008)(5660300002)(2616005)(36756003)(41300700001)(31696002)(38100700002)(2906002)(8676002)(8936002)(316002)(44832011)(83380400001)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SExGbzd3WmowOGM2S2V5RUZYM0oyZUhrY1cwcitLbUVDU214RW5YRU0valZF?= =?utf-8?B?eno5MFFROXZOcG1zcGQvcDFadmlpNGtiZE5wSjdCTUpUM2VFOENUV1VaZS9q?= =?utf-8?B?My9KeFJ2OC9Ka0Z3QUVic0NVQ1VDSFR2VFVCQm41ZTB1SldrSFI0Y2FrK202?= =?utf-8?B?QWJtZFExejMwRm1QVWJ1VStkQnBEanRvVWozSVVlQUV2azBlNGcyN2FoOUdO?= =?utf-8?B?MlhOL0ZGZXI3dENiSjBEaThPU0RELzZXZUFiSHhCclZhL2p2bWlaU1dURkpX?= =?utf-8?B?Nm1yNCs0UisxY1ZjQkwzblR4UjlRRnpmV1V0Rmp1ZERMUVRJUmI1cTMrdi9s?= =?utf-8?B?ZUZ6MFoxSENWblM0MVlRODB3ZCthZlM5RlU4RlAwb1VUcmRIMDd1Ti9kWnZU?= =?utf-8?B?KzZFejBUZUMwNElHOGFkeXU1VytxWWVHNEJYVy9LWHRDaElDMk5PQmUxMnpo?= =?utf-8?B?MDM3SnAyTlNLV3RlaEN5dEdPSzNMVEhYRlVaa3RHazNvVUlUc2NXSkNvMUg5?= =?utf-8?B?ay9IZ2lhUldhdE8ra1A4RTJJcUJlaG0rYlY2QnJEVmJkbUFUR09Fa2FGVTVE?= =?utf-8?B?U3hFQ0ZuZ1M0M3Z0bkQ3ZzJpaExHM2lTM3pKYnozVTcvUFFtZy9DdWltTzl4?= =?utf-8?B?YmZMQW8vQUVkUW45blRUYS90QmI1bXV5QzVaMmNlbHJzcTRjcjJkUHJDVDI4?= =?utf-8?B?dy93VHNXUWZBbVZ4bzl0cXJLcHhTaVBtYU0wWW14dzI1VUJBZzFPeFpiNVVP?= =?utf-8?B?RzlZK0JkU2Zzbm5QcWZVRW1ubEtIUnUrRGh2ZTlGLzRqaFN5Wk8zaFl5MklH?= =?utf-8?B?WVdTOTZwUkIzMC9GK1JWbHcxdUZnVmRCODhWQnl0bVE3M010WFBzS1g5LzRa?= =?utf-8?B?WHJNR1hjY0hwM1VXazNKbzE0K1J0ZW9idUhSOVFiTEZNb2JwZWU4d1VWc0tu?= =?utf-8?B?THZ5aUFIZ0swUDFHc3RyZFkzU1I1Y0RaazRRQk1oc2gvS0dBMXFXSk5HZzZV?= =?utf-8?B?ZnVVT3B1cGtoTFllcjNhRkpLdXJ2T0grejRqY3ZqeWlCK0NCbStZRXZ1OFVT?= =?utf-8?B?UnJob0hkMlIyUm5nalA5ek1aNFBBczlZWnFMMVFsbGFzd0lndGZvUFBiazI3?= =?utf-8?B?RlJKSWxvRlpKMjR1MVlJTG5wSGZYVEladVF5U0ExM2pBKzRVNWtwZUwyeDZK?= =?utf-8?B?OXJOVFNjMlhxVSs5MkJpRmFyR0RSMVpua1NDRy9EMG5lU0tCdFNVU2VwY0hz?= =?utf-8?B?WVVhS1FHd043WXNtZXFnZU4rVmp6R2JrQTJvQ1Jjemc3V2ZrZkNlVWxFVXJW?= =?utf-8?B?RE1aSlVpem5HbEgrQ3JYMG5TV3JpQ1Y0cHMvRE16dmY5UDlHVWtZWDRvS0Zy?= =?utf-8?B?cXd2U3FUUHYrQlBXemhHT0l0LytkVTF5ckVNTjNxa2xQcm1mWjZKOGs5THIv?= =?utf-8?B?aTFDRVhncWlLbURSVnluSStEbGZyZ0VwMjRqL1VRMWJZVEFaVHdJMjdNTmZh?= =?utf-8?B?RHR4alR4a1lzbi81cGJ6dHdqRkJlblRNR0JOQ0szUlVrNk1jTXhkR3JuZG1h?= =?utf-8?B?TnVocFh6UkZ5OWVKQjJMY1JjS2tYR1NVdGM4WDlVRVRnR3FZaXJjN0c5TmhM?= =?utf-8?B?aDZ2ZERnZy9HbkloVWlzMGVkWnVSZHBSYjhRbEIwdEpTUjFFZmx1eEZPeUxY?= =?utf-8?B?UlY3TWhNZGRCQWQxdXV6ajlUZFA0WFphMk1Ob3ZPUFp0OWhwOVlIVWZ6QjAx?= =?utf-8?B?SkZHMHhvcVgvSVFTLzdRdUJGOFk0WURVcTVzUGpuZUdBMDdFcko2MmRtQ3lv?= =?utf-8?B?QTZZQ2JaMTIvcjRCZUxhZjU1TWVjeUpSVWJoMng5WGZLRFViZnVUR3J0UGIz?= =?utf-8?B?N2RId1M1dHc1RXF5YTRlQVVYM1hJaWw2bHJqank4SDNENlI5UlQzQTNUVUkz?= =?utf-8?B?ZDhzQlROQjNwTGJqaElYZ2RJYjBmckxIeWRNWU4xa0RxNUx2My9PL01UbFRR?= =?utf-8?B?c2ZCTXBiazRTdmkxT1c0cG5qTGVZZFBWVTJ6OWY5UmJ4QWxDYTBOSUpNZmVC?= =?utf-8?B?MEVqMVRkbDhIa1ZuSHJVV2VSMTgzR0F3YUdFRmhYQ05SVmRmUlNOZ3J3MUk3?= =?utf-8?Q?YwaVSa6VfbB2gzDWoOLky704W?= X-OriginatorOrg: efficios.com X-MS-Exchange-CrossTenant-Network-Message-Id: eacf3f6c-919d-44ca-7924-08db5c66668b X-MS-Exchange-CrossTenant-AuthSource: YT1PR01MB2828.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 May 2023 14:51:48.1109 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4f278736-4ab6-415c-957e-1f55336bd31e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: YpaopJRKX5PlExST8U5ePjhCav6t7cvX0L7pB3rRWpDGwdw217fmQTmzl8qJ/V9X4/qHLOev3qdHiPb8pcx4KQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: YQBPR0101MB8302 X-Spam-Status: No, score=-3033.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 5/24/23 09:07, Andrew Burgess wrote: > Simon Marchi via Gdb-patches writes: > >> Add a checked_static_cast overload that works with references. A bad >> dynamic cast with references throws std::bad_cast, it would be possible >> to implement the new overload based on that, but it seemed simpler to >> just piggy back off the existing function. >> >> I found some potential uses of this new overload in amd-dbgapi-target.c, >> update them to illustrate the use of the new overload. To build >> amd-dbgapi-target.c, on needs the amd-dbgapi library, which I don't >> expect many people to have. But I have it, and it builds fine here. I >> did test the new overload by making a purposely bad cast and it did >> catch it. > > Looks great. Thanks for expanding this feature. > > Reviewed-By: Andrew Burgess Thanks. Are you also fine with the switch to use gdb::Requires to do the "target is reference" check, as Lancelot suggested? Simon