From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) by sourceware.org (Postfix) with ESMTPS id BB8A33857405 for ; Thu, 5 May 2022 10:29:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BB8A33857405 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr1-f47.google.com with SMTP id v12so5472656wrv.10 for ; Thu, 05 May 2022 03:29:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=TzQ+PX0w49BkeBAbCoKfKZl9vQMt76VMaTAgEez4OUA=; b=cTqq2/mSZNSLQxKMcJdZEXRHcWhNXi043jx0wZN/Fr1wAx3bdzXXUwUKoDVyGeWBam 7VihI4x7W6IujA/a91/RcTSMQyjXoKHkB6XmyDE4v4E4sDkDmi5XlecOjVnQlZr5qiNC s6BFcPrmWmJ/lwVx22wwDSwMLfhUKv6gTgrwe9Iv8AmsF91MeXhdSIYKSQgBvQeauTjf xFQJz2nPjOIGP2SB0eQCNEBsExdS+RttigL45QbLVNmCzOLWbnxWBba/5NYZ5w7ybhHZ XoZ2vBe3wEWHIAEqMF1ZNeNnNXO/2iDpjNCRvyHGCTNXWy/0qPT0VND8gSWYeYLl8yuJ 9dHw== X-Gm-Message-State: AOAM533MM0gg7OWcdrRFDJnnT8IEtaYT0fxKRgnM3aMRt3ihsoSZScnj qCM43uAF5gxB86fe6Tvz1SIPXF5zGTjdZQ== X-Google-Smtp-Source: ABdhPJxlNNDMecaaf/zAI0/GI1xJgshorUP99R8V00BD7Ld7rtjcm+sAaCm+w7WI1Uh/D5TqBLQluQ== X-Received: by 2002:a5d:6708:0:b0:20a:d1b3:3479 with SMTP id o8-20020a5d6708000000b0020ad1b33479mr20404981wru.463.1651746554524; Thu, 05 May 2022 03:29:14 -0700 (PDT) Received: from ?IPV6:2001:8a0:f924:2600:209d:85e2:409e:8726? ([2001:8a0:f924:2600:209d:85e2:409e:8726]) by smtp.gmail.com with ESMTPSA id o8-20020adfa108000000b0020c5253d8e5sm918498wro.49.2022.05.05.03.29.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 May 2022 03:29:13 -0700 (PDT) Message-ID: Date: Thu, 5 May 2022 11:29:12 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH] Move 64-bit BFD files from ALL_TARGET_OBS to ALL_64_TARGET_OBS Content-Language: en-US To: Luis Machado , gdb-patches@sourceware.org References: <20220503111913.563509-1-luis.machado@arm.com> <4099d8e4-54e1-0579-a4f4-15a40d4942a5@arm.com> <715abbd2-18bb-28b5-f30b-6d92ca42e8ca@arm.com> <4a965c5f-0ddf-f6e6-2578-8b45fb526611@arm.com> From: Pedro Alves In-Reply-To: <4a965c5f-0ddf-f6e6-2578-8b45fb526611@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 May 2022 10:29:17 -0000 On 2022-05-05 10:06, Luis Machado wrote: > On 5/3/22 22:51, Luis Machado via Gdb-patches wrote: >>>> In opcodes, tilegx is in TARGET32_LIBOPCODES_CFILES.  So why did we need to move that one? >>> >>> *sigh*... I think that needs to be fixed as well. >>> >>> opcodes/disassemble.c defines ARCH_tilegx if BFD64 is defined, which makes it a 64-bit BFD target. So a 32-bit build makes it not register a disassembler function (leading to GDB internal errors). >>> >>> TILE-Gx is a 64-bit core according to https://en.wikipedia.org/wiki/TILE-Gx. So I suppose we need to move it from TARGET32_LIBOPCODES_CFILES to TARGET64_LIBOPCODES_CFILES. >> >> Patch to binutils sent here: https://sourceware.org/pipermail/binutils/2022-May/120651.html > > I've pushed the binutils patch. Are there any objections to the gdb-side patch? Nope. Please go ahead and merge it.