Re: [PATCH, GDB] Expect prompt after no FPU warning

[Thomas Preudhomme <thomas.preudhomme@foss.arm.com>]

[-- Attachment #1: Type: text/plain, Size: 868 bytes --]

FYI

On 17/05/17 14:34, Yao Qi wrote:
> Thomas Preudhomme <thomas.preudhomme@foss.arm.com> writes:
>
>> Is this ok for master branch and GDB 8 (after a 1 week period)?
>>
>
> Patch is good to me, one comment below.
>
> GDB 8 will be released soon, so it is good to have this patch in 8.0.
> This patch is about test case, so it should be safe to merge it to 8.0
> branch now.
>
>> -    gdb_test "info float" "No floating.point info available for this processor." "info float (unknown target)"
>> +    gdb_test "info float" "No floating.point info available for this processor.*$gdb_prompt $" "info float (unknown target)"
>>  }
>
> This change is not needed, because $gdb_prompt is appended in the
> pattern inside of gdb_test.
>

Alright, pushed the attached patch which also fix a spurious codestyle change 
(tab - space) to master and GDB 8.

Best regards,

Thomas

[-- Attachment #2: nofloat_gdb_tests_expect_prompt.patch --]
[-- Type: text/x-patch, Size: 1977 bytes --]

diff --git a/gdb/testsuite/gdb.base/float.exp b/gdb/testsuite/gdb.base/float.exp
index a4762c9742682391074f0707e56a6eae4cd70c6e..e09c124b8825d687cd0bac9f363b0b61b0ed9230 100644
--- a/gdb/testsuite/gdb.base/float.exp
+++ b/gdb/testsuite/gdb.base/float.exp
@@ -50,7 +50,7 @@ if { [is_aarch64_target] } then {
 	    # if we have NEON.
 	    pass "info float (VFP)"
 	}
-        -re "No floating.point info available for this processor.*" {
+        -re "No floating.point info available for this processor.*$gdb_prompt $" {
             pass "info float (without FPU)"
 	}
     }
@@ -63,7 +63,7 @@ if { [is_aarch64_target] } then {
         -re "fp0.*fp1.*fp7.*$gdb_prompt $" {
             pass "info float (with FPU)"
 	}
-        -re "No floating.point info available for this processor.*" {
+        -re "No floating.point info available for this processor.*$gdb_prompt $" {
             pass "info float (without FPU)"
 	}
     }
@@ -81,7 +81,7 @@ if { [is_aarch64_target] } then {
         -re "fd0.*fd3.*$gdb_prompt $" {
             pass "info float (with FPU)"
 	}
-        -re "No floating.point info available for this processor.*" {
+        -re "No floating.point info available for this processor.*$gdb_prompt $" {
             pass "info float (without FPU)"
 	}
     }
@@ -90,7 +90,7 @@ if { [is_aarch64_target] } then {
         -re "f0.*f1.*f31.*fpscr.*$gdb_prompt $" {
             pass "info float (with FPU)"
 	}
-        -re "No floating.point info available for this processor.*" {
+        -re "No floating.point info available for this processor.*$gdb_prompt $" {
             pass "info float (without FPU)"
 	}
     }
@@ -102,7 +102,7 @@ if { [is_aarch64_target] } then {
 	-re "fpul.*fr0.*fr1.*fr15.*$gdb_prompt $" {
 	      pass "info float (with FPU)"
 	  }
-	-re "No floating.point info available for this processor.*" {
+	-re "No floating.point info available for this processor.*$gdb_prompt $" {
 	      pass "info float (without FPU)"
 	}
     }