From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) by sourceware.org (Postfix) with ESMTPS id 1DD813858C39 for ; Tue, 4 Apr 2023 13:03:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1DD813858C39 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr1-f52.google.com with SMTP id e18so32715123wra.9 for ; Tue, 04 Apr 2023 06:03:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680613405; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=kHea1I2P1pnIHlZ7yKSAVox+x1OvUF8CB5BPqppMGHY=; b=ZcYyJUhoCNRGKpOlCcfRIRg8Pu8Or6U8Grn/uDzml3c6D5OKdTsd/F4eCkrL5H5HZd /guJLspsLYsn/gJ+pUGa/Q2mWLv1T/SlaxqSsKCVQm0Lxls5L7V6gyUQ/QJh1JqLhJ4M hBCTdJKktuNWh9+zS0Z15e8doO4hVe1nbgy/p4LXrByZcgZr8+v86yN5YUwAMUtu/xxu Zpc8z2LNbS0taA6eFcnmiUh4RqNbQoGT9zbvuA9tEI2RvKE08jhd7eWajFctaGdcqsr6 aKdBYieJ02bfmBA3Jm9sufHYBb5GPDg8d5xUVgOT5qSksh4tXDKQ9saBneEkhcwDfGw8 EZiQ== X-Gm-Message-State: AAQBX9foZG6yPEjwWE3i60TLzQ161U7uMhG2K2AJXhULjHGDvim1HQNj B6DpulYaOiFUHJB/RCZvZT0= X-Google-Smtp-Source: AKy350aaInI26Z9NzFXBq/kVuBhOrY95kpFIlZoGnQXx6xqgyJjBrPLuongfX/UhCwKn4fTMn0mAPg== X-Received: by 2002:adf:dd87:0:b0:2cf:e87b:5c52 with SMTP id x7-20020adfdd87000000b002cfe87b5c52mr1738068wrl.18.1680613404966; Tue, 04 Apr 2023 06:03:24 -0700 (PDT) Received: from ?IPv6:2001:8a0:f93c:5900::1fe? ([2001:8a0:f93c:5900::1fe]) by smtp.gmail.com with ESMTPSA id l4-20020a5d6744000000b002da76acfee1sm12236229wrw.28.2023.04.04.06.03.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Apr 2023 06:03:24 -0700 (PDT) Subject: Re: [PATCHv4] gdb: fix reg corruption from displaced stepping on amd64 To: Andrew Burgess , gdb-patches@sourceware.org Cc: Simon Marchi References: <49d7093fe09ea127d7dfd6082695ccda23d62439.1680097352.git.aburgess@redhat.com> From: Pedro Alves Message-ID: Date: Tue, 4 Apr 2023 14:03:21 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <49d7093fe09ea127d7dfd6082695ccda23d62439.1680097352.git.aburgess@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,KAM_NUMSUBJECT,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2023-03-29 2:46 p.m., Andrew Burgess wrote: > In v4: > > - The first two patches, which related to displaced step debugging, > have now been merged, > > - The test now uses 'remote_exec target "kill ...' as suggested by > Pedro, I've confirmed that the test still exposes the issue when > the GDB fix is not applied, > > - Have regenerated the gdbarch related files. The only change to > generated code is within a comment -- so no functional change, > > - All the typos and gramatical errors Pedro pointed out have been > fixed, > > - The trailing blank lines that Simon pointed out have been removed. > Thank you. Approved-By: Pedro Alves