From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2079.outbound.protection.outlook.com [40.107.22.79]) by sourceware.org (Postfix) with ESMTPS id AC7373858D28 for ; Fri, 12 Aug 2022 09:33:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org AC7373858D28 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=HDLypDMSX8/IQeijnoNXnVlUQlEZO1zSkjsGHVeYgJSnhYmwxpMDNr4kXs5uSgSBjPIvI5/HT4QO+Tmm6p/NWiQuNRrhyogqBSaqsi+3ao1uZ8ROY2lwIZRZCXFYW9mZmXyPBgksVh5Zx23oOIMV0cCFkESA0Dfu5Kdi77s43ooxjIqxDI3UBT7KC+5vQ7mGLde+27Uhe85G5f4nznwqGRcez4Od6ekw6f17KqJjyf609WmpXn8JWpUQyx3uwatw9FxtgomPcLkSDCUfRMJFdTS8PeHz+iF10dYrYRMiS/Z1n5qMcRklFnNl88qwleQ1WBaw/h7byIAKqOocrwirUw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LneLKO0vbNX4w1JYYKatP95utrr/vYfUanfajjXG7UI=; b=g/HEKmf0t1/UnfMGp2AMgWU7zWpLDKWRkJ0m4zD29AlEBOsjynTYE1kZ2PYst6Jd8HHqaOmy+j8z8sID7H20MjN3qiN6ao9WEVqqe9E7XitSGXWoKQxpCxSGR7NTP8iH50C5BpbO55fgyGZlBMi/2J/VUqCSU25NW8KjY/apTzx32BdjroFBah7mEdSE6QNQp9j88ozRse9Ann/5LcBlY5u9QlEGCqAUHvmjU38ffRtyv8OAKaLfFnr6Tyazb8Wu0Sb56GVqF/QV6Q7YRjBq8ViCj8cyuXpKaQsearDBMGEMVwW68BfD8tTPmT+6V+W27jgGRBSUWbCn01YfKEIcRw== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) Received: from DB6PR0202CA0025.eurprd02.prod.outlook.com (2603:10a6:4:a5::11) by PA4PR08MB7569.eurprd08.prod.outlook.com (2603:10a6:102:26e::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5525.11; Fri, 12 Aug 2022 09:33:22 +0000 Received: from DBAEUR03FT050.eop-EUR03.prod.protection.outlook.com (2603:10a6:4:a5:cafe::d6) by DB6PR0202CA0025.outlook.office365.com (2603:10a6:4:a5::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5525.14 via Frontend Transport; Fri, 12 Aug 2022 09:33:21 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT050.mail.protection.outlook.com (100.127.142.250) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5525.11 via Frontend Transport; Fri, 12 Aug 2022 09:33:21 +0000 Received: ("Tessian outbound fa99bf31ee7d:v123"); Fri, 12 Aug 2022 09:33:21 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 15d772d927172c0a X-CR-MTA-TID: 64aa7808 Received: from d6b46a049a51.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 4914B3A1-1B86-47AE-B8E3-5AE67C704B8B.1; Fri, 12 Aug 2022 09:33:15 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id d6b46a049a51.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 12 Aug 2022 09:33:15 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bsOi1sEiJcDFGmGOlZeRZd0X96EHU1/GMGLjMNNXjbHeZ+LGO6kuOzqhSQ/qtWKsrhwHlzD9vEgDj/QCv09O3v6kXyEvxJKxa0SGCq8k5B8cAle5hxx3oMzRAwwUbVOJ1Jl/Mcn0yDJ//lkq6OySXkt2oOLj13yktS0bsNty4eRSxarRD8UyHNRs0NsVn+1rTj4DAwTsB/KdG7dSKsBELdt7RYaA90VQ1I334H14LSdq3xNx+AIH3JP5Ph+GhyujDuEq+PoGyfH56sFwDH64RlahSw3RY4ntTaClC9aKhws2Hw1FBpamF82I425oZdbUtujABIX5DoW4ohcJkOb9vg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LneLKO0vbNX4w1JYYKatP95utrr/vYfUanfajjXG7UI=; b=HN03HAKKFLUDrUwcmYp6GhS00cJr2XKsekM4W5SyifD3e1wmbre+XyJLO6JicdKicIdvYHtk/bGqlGs3P2XuMzLUkRF3riUm9T6SX+Cr5uT8jq9Whw902o1Mb3Una9JDIMHUhQ8eA6DyySECRXR+q2LfsIZ33DSnhWkDYDibPBbunttg+++pr3+XTM6aRxKK2Tuqlg7T8ONfmrAzXYFZ6HYFTftlfhVRmEMmw6fHTTE7p7U1oXtaypIkrAE/M86aiMUlEd/w0FoUoaAE9rz4eFZ+lXAUVGkHaw3wfvMBrKXvgZxSUt1qJ5OWHbgKEk7JdSMDFiGCc42K9WHFBfbiAw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) by AM6PR08MB3573.eurprd08.prod.outlook.com (2603:10a6:20b:4b::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5504.14; Fri, 12 Aug 2022 09:33:12 +0000 Received: from VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::cc64:9170:b12d:de8]) by VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::cc64:9170:b12d:de8%4]) with mapi id 15.20.5504.019; Fri, 12 Aug 2022 09:33:11 +0000 Message-ID: Date: Fri, 12 Aug 2022 10:33:09 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH][gdb/testsuite] Fix gdb.dwarf2/dw2-dir-file-name.exp Content-Language: en-US To: Tom de Vries , gdb-patches@sourceware.org References: <20220811115809.GA19509@delia> From: Luis Machado In-Reply-To: <20220811115809.GA19509@delia> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LNXP123CA0019.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:d2::31) To VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: fcca5010-26b6-4af0-cccd-08da7c45b2b7 X-MS-TrafficTypeDiagnostic: AM6PR08MB3573:EE_|DBAEUR03FT050:EE_|PA4PR08MB7569:EE_ x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: tYE9lf9lkHDcepRxU9Sox2gzv4AgaR/3gWeDEWYE4PdjiKfo9DfX6XZEn8klDIfMMHkt/0eCb86VWO2oNtIwJDOx1vBbMO55sgqmQRmTawEHXGurynQTtz34xft4SDOo5zCS+dOktM2jerOoEwOl+Skh/TctL5O+6JoKU3JoDybgKw8OK+ZS8ZLKhdHWrrvGzLh49l8KL0ed767QVl4RWpBkcrMciQCElSfq/ty3/s2KqZFqT61cGxE73ZNlTvQ/74En+Pei6wja+7ORiYRR+SNVA9tEJxns5e75xPbH878e9fdveLHBTOwOHP9laLi/U3ytvfO+/KdwS1PU7/SHlSgJBk/16WT79l/wEFzEavfn8ORP2vzFNOMDTt0o4lUp5+Cr66IWIkkFXCVPu9eEMmFbzcvC1q7NeVR+HveKrwCJ/uvsOvd82oIYBwrjgPdWz3Wau5KH9m1YzOHiV3V0JDPB/oVMGdRqyI2G7GOW9XTPSxWeTN9G46hXN5VBtuu38bBw9V6jN/6WETVpusrSdlvvvSeHbWNP3onIbwLUedoWJOtNi+ZFV5+71ElgMyqRL8GFqZc7kb3iM4NTt5YKoXX754frSqwXSYAWvs95xNUEu6LHyDHWyD8+p0RVc12KCah0svkHj5kBolaEKy+wcOOdxfOPqfu9Ieh4ekE5HqIyXZ462Sp6SGlroFpbqOaqvXCML4KGnS7HVu8cBxnAlNRFBTDqRvZwaCMEC0WAs+fFWVIVVe50QNEAtbE4P9oZLWqLD7Niu05lRvDpAj8OZ0Iude9TgTFPbQtRzChP9mbwry/24GV6y4xqmfhdWHSzPM4UprVeYly1UuaSC0ZrFw== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR08MB3919.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(4636009)(396003)(346002)(136003)(376002)(39860400002)(366004)(2906002)(86362001)(31696002)(36756003)(38100700002)(478600001)(6486002)(316002)(186003)(31686004)(2616005)(26005)(41300700001)(53546011)(6506007)(6512007)(66476007)(66556008)(66946007)(8676002)(83380400001)(44832011)(8936002)(5660300002)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB3573 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT050.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: b1aaad58-f767-4f5f-0ff3-08da7c45ac41 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mV7Ijmgf2ZEy/ypjakC8IvqjIMNCqt3cvvLKf0dkJbAaxLucvJN6ilATioRdBALvJxRBpcy1qvzxIOG4pnz9H7rpYYiKx6m/URGMW0OOnnTJyK0cOnpinZiZFaEvyzOVm9d1Po4DmAcvz8UIyc1vxkwmk3XoYFjfYFEvxY/QraDHpBjbJ130HZgwWEaDgPzGVrH6myQ42H2aPTTOGmUkVnxJ35kB0tO6euYtPdLnY/g3WwzxtWJ2+eI8Zz5dXdg8tvmySYNGbMKIllwnTxOvBDHfErLyP2vEiiMqFjfVhEkk1nuCqY37MJ/Pz6q+Ue3kBewDVZem1l0y3DOL1MvhqXqfC1Lw3pEQrMFowepd2UgLbCCVufgPypaDXMXMidd2+ki7/P6b5h91a700yLshE5gLzWiTs5EVAyLK5ShIl0Ry9K7kqFe4cIlmjwlrGIgz8wWXjr9yaaH1mNpMgomcZO1KpYVj+Xu6VBmBFeaPrquix59r1V+onR03QbMys5RFQejZBz/nQqNnnDtPG8BbADvtoHxgOE1fwst93zcuwKSyEOhqeLb8mW33USwonAO+S3XpWZWGco3HtxyJd1wuKdnaCf+ND4r5bQIZt9jjZyoP/lY46NnOSSbBL4o+dQGiHynTTvZlsJz3VPvF+6I1qHg0j2h4ue294DHEBa6OoIXbORetLDrMJgT/uExoHHsRNDELsNE7XRol7EyB5zruSm6Mk4Cf+s6uWZickbWFFKONzELkPJInYVSc5M2TeIpWhoDVRlK9LMCJziEmPzXtnPhtZrY0D1VaAtkBxTBx4mOFMFaaiwXD63frTApPXOYGh1bJvZ9/MxH/mKAaNN6djQ== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230016)(4636009)(376002)(136003)(346002)(396003)(39860400002)(46966006)(36840700001)(40470700004)(8676002)(83380400001)(41300700001)(70206006)(40480700001)(2906002)(70586007)(36860700001)(316002)(2616005)(36756003)(47076005)(31686004)(186003)(336012)(82310400005)(26005)(81166007)(356005)(6512007)(86362001)(8936002)(40460700003)(478600001)(6506007)(5660300002)(82740400003)(31696002)(6486002)(53546011)(44832011)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Aug 2022 09:33:21.9167 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: fcca5010-26b6-4af0-cccd-08da7c45b2b7 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT050.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR08MB7569 X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, FORGED_SPF_HELO, GIT_PATCH_0, KAM_DMARC_NONE, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Aug 2022 09:33:29 -0000 On 8/11/22 12:58, Tom de Vries wrote: > Hi, > > When running test-case gdb.dwarf2/dw2-dir-file-name.exp on x86_64-linux, we > have: > ... > (gdb) break compdir_missing__ldir_missing__file_basename^M > Breakpoint 2 at 0x4004c4: file tmp-dw2-dir-file-name.c, line 999.^M > (gdb) continue^M > Continuing.^M > ^M > Breakpoint 2, 0x00000000004004c4 in \ > compdir_missing__ldir_missing__file_basename () \ > at tmp-dw2-dir-file-name.c:999^M > (gdb) PASS: gdb.dwarf2/dw2-dir-file-name.exp: \ > compdir_missing__ldir_missing__file_basename: continue to breakpoint: \ > compdir_missing__ldir_missing__file_basename > ... > > When trying to set a breakpoint on > compdir_missing__ldir_missing__file_basename, the architecture-specific > prologue skipper starts at 0x4004c0 and skips past two insns, to 0x4004c4: > ... > 00000000004004c0 : > 4004c0: 55 push %rbp > 4004c1: 48 89 e5 mov %rsp,%rbp > 4004c4: 8b 05 72 1b 20 00 mov 0x201b72(%rip),%eax # 60203c > 4004ca: 83 c0 01 add $0x1,%eax > 4004cd: 89 05 69 1b 20 00 mov %eax,0x201b69(%rip) # 60203c > 4004d3: 90 nop > 4004d4: 5d pop %rbp > 4004d5: c3 ret > ... > > And because the line table info is rudamentary: > ... > CU: tmp-dw2-dir-file-name.c: > File name Line number Starting address View Stmt > tmp-dw2-dir-file-name.c 999 0x4004c0 x > tmp-dw2-dir-file-name.c 1000 0x4004d6 x > tmp-dw2-dir-file-name.c - 0x4004d6 > ... > the address does not fall at an actual line, so the breakpoint is shown with > address, both when setting it and hitting it. > > when running the test-case with aarch64-linux, we have similarly: > ... > (gdb) break compdir_missing__ldir_missing__file_basename^M > Breakpoint 2 at 0x400618: file tmp-dw2-dir-file-name.c, line 999.^M > ... > due to the architecture-specific prologue skipper starting at 0x400610 and > skipping past two insns, to 0x400618: > ... > 0000000000400610 : > 400610: 90000100 adrp x0, 420000 <__libc_start_main@GLIBC_2.17> > 400614: 9100b000 add x0, x0, #0x2c > 400618: b9400000 ldr w0, [x0] > 40061c: 11000401 add w1, w0, #0x1 > 400620: 90000100 adrp x0, 420000 <__libc_start_main@GLIBC_2.17> > 400624: 9100b000 add x0, x0, #0x2c > 400628: b9000001 str w1, [x0] > 40062c: d503201f nop > 400630: d65f03c0 ret > ... > > But interestingly, the aarch64 architecture-specific prologue skipper is > wrong. There is no prologue, and the breakpoint should be set at 0x400610. > > By using "break *compdir_missing__ldir_missing__file_basename" > we can get the breakpoint set at 0x400610: > ... > (gdb) break *compdir_missing__ldir_missing__file_basename^M > Breakpoint 2 at 0x400610: file tmp-dw2-dir-file-name.c, line 999.^M > ... > and make the test-case independent of prologue analysis. > > This requires us to update the expected patterns. > > The fix ensures that once the aarch64 architecture-specific prologue skipper > will be fixed, this test-case won't start failing. > > Tested on x86_64-linux. > > Any comments? > > Thanks, > - Tom > > [gdb/testsuite] Fix gdb.dwarf2/dw2-dir-file-name.exp > > --- > gdb/testsuite/gdb.dwarf2/dw2-dir-file-name.exp | 8 ++++---- > gdb/testsuite/lib/gdb.exp | 7 ++++++- > 2 files changed, 10 insertions(+), 5 deletions(-) > > diff --git a/gdb/testsuite/gdb.dwarf2/dw2-dir-file-name.exp b/gdb/testsuite/gdb.dwarf2/dw2-dir-file-name.exp > index 4d3f767f597..4c4c1ff07af 100644 > --- a/gdb/testsuite/gdb.dwarf2/dw2-dir-file-name.exp > +++ b/gdb/testsuite/gdb.dwarf2/dw2-dir-file-name.exp > @@ -396,20 +396,20 @@ proc test { func compdir filename } { > error "not absolute" > } > > - gdb_breakpoint $func > + gdb_breakpoint *$func > gdb_continue_to_breakpoint $func "$func \\(\\) at .*" > > gdb_test_no_output "set filename-display absolute" > verbose -log "expect: ${absolute}" > - gdb_test "frame" " in $func \\(\\) at [string_to_regexp ${absolute}]:999" "absolute" > + gdb_test "frame" "#0 $func \\(\\) at [string_to_regexp ${absolute}]:999" "absolute" > > gdb_test_no_output "set filename-display basename" > verbose -log "expect: [file tail $filename]" > - gdb_test "frame" " in $func \\(\\) at [string_to_regexp [file tail $filename]]:999" "basename" > + gdb_test "frame" "#0 $func \\(\\) at [string_to_regexp [file tail $filename]]:999" "basename" > > gdb_test_no_output "set filename-display relative" > verbose -log "expect: $filename" > - gdb_test "frame" " in $func \\(\\) at [string_to_regexp $filename]:999" "relative" > + gdb_test "frame" "#0 $func \\(\\) at [string_to_regexp $filename]:999" "relative" > } > } > > diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp > index a8f25b5f0dd..70fc019eeb9 100644 > --- a/gdb/testsuite/lib/gdb.exp > +++ b/gdb/testsuite/lib/gdb.exp > @@ -787,9 +787,14 @@ proc gdb_continue_to_breakpoint {name {location_pattern .*}} { > global gdb_prompt > set full_name "continue to breakpoint: $name" > > + set re_at_in " (at|in) " > + if { [regexp $re_at_in $location_pattern] } { > + set re_at_in " " > + } > + > set kfail_pattern "Process record does not support instruction 0xfae64 at.*" > gdb_test_multiple "continue" $full_name { > - -re "(?:Breakpoint|Temporary breakpoint) .* (at|in) $location_pattern\r\n$gdb_prompt $" { > + -re "(?:Breakpoint|Temporary breakpoint) .*$re_at_in$location_pattern\r\n$gdb_prompt $" { > pass $full_name > } > -re "\[\r\n\]*(?:$kfail_pattern)\[\r\n\]+$gdb_prompt $" { LGTM I agree that having a test that doesn't rely on prologue analysis is a good move. I'll track the aarch64 prologue analysis hiccup separate.