From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27323 invoked by alias); 16 Nov 2017 18:47:23 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 27309 invoked by uid 89); 16 Nov 2017 18:47:23 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.7 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,KB_WAM_FROM_NAME_SINGLEWORD,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=learn X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 16 Nov 2017 18:47:22 +0000 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 04FADFC7B9 for ; Thu, 16 Nov 2017 18:47:21 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 81CBA614D7 for ; Thu, 16 Nov 2017 18:47:20 +0000 (UTC) Subject: Re: [PATCH 0/5][Resend] Fix multiple Ctrl-C/Quit issues To: GDB Patches References: <1510010836-15287-1-git-send-email-palves@redhat.com> From: Pedro Alves Message-ID: Date: Thu, 16 Nov 2017 18:47:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1510010836-15287-1-git-send-email-palves@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-11/txt/msg00322.txt.bz2 On 11/06/2017 11:27 PM, Pedro Alves wrote: > As I mentioned before, I've been messing with GDB's terminal handling > in context of multi-target. While doing some inflow.c surgery, I had > the bright idea of writing a test that did: > > break foo > commands > printf "hello\n" > continue > > and run that against a program that does basically: > > while (1) > foo (); > > and then while the inferior is running and hitting that breakpoint, > hit Ctrl-C, to make sure target_terminal::inferior/ours handling was > correct and that the user always re-gained control. > > Unfortunately, that test hit a number of other, preexisting > problems... (I never learn... :-P) This series fixes them, and then > adds a testcase similar to the above. The test passes cleanly with > the fixes in place, but fails otherwise. > > Pedro Alves (5): > Fix swallowed "Quit" when inserting breakpoints > Fix stdin ending up not registered after a Quit > Don't ever Quit out of resume > Python unwinder sniffer: PyExc_KeyboardInterrupt -> Quit > Test breakpoint commands w/ "continue" + Ctrl-C I've pushed these in as well. Thanks, Pedro Alves