From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 48498 invoked by alias); 12 Feb 2019 02:46:19 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 48487 invoked by uid 89); 12 Feb 2019 02:46:18 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 12 Feb 2019 02:46:17 +0000 Received: from [10.0.0.178] (unknown [192.222.164.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 30CF71E077; Mon, 11 Feb 2019 21:46:16 -0500 (EST) Subject: Re: [PATCH v2 2/4] Add a new function child_path. From: Simon Marchi To: John Baldwin , gdb-patches@sourceware.org References: Message-ID: Date: Tue, 12 Feb 2019 02:46:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2019-02/txt/msg00129.txt.bz2 On 2019-02-11 9:43 p.m., Simon Marchi wrote: > On 2019-01-28 3:47 p.m., John Baldwin wrote: >> child_path returns a pointer to the first component in a child path >> that comes after a parent path. This does not depend on trying to >> stat() the paths since they may describe remote paths but instead >> relies on filename parsing. The function requires that the child path >> describe a filename that contains at least one component below the >> parent path and returns a pointer to the first component. >> >> gdb/ChangeLog: >> >> * Makefile.in (SUBDIR_UNITTESTS_SRCS): Add >> unittests/child-path-selftests.c. >> * common/pathstuff.c (child_path): New function. >> * common/pathstuff.h (child_path): New prototype. >> * unittests/child-path-selftests.c: New file. > > Thanks, this LGTM. Just minor comments below. Oh, and maybe name the function is_child_path or child_path_p? Simon