From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id D33813858C2D for ; Wed, 30 Mar 2022 16:59:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D33813858C2D Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 22UGwu4i021661 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 30 Mar 2022 12:59:01 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 22UGwu4i021661 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id E38B41ED17; Wed, 30 Mar 2022 12:58:55 -0400 (EDT) Message-ID: Date: Wed, 30 Mar 2022 12:58:55 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH] gdb/testsuite/tui: implement _csi_P proc Content-Language: en-US To: Andrew Burgess , Simon Marchi via Gdb-patches Cc: Simon Marchi References: <20220330012411.2993199-1-simon.marchi@efficios.com> <87ee2jak1b.fsf@redhat.com> From: Simon Marchi In-Reply-To: <87ee2jak1b.fsf@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Wed, 30 Mar 2022 16:58:56 +0000 X-Spam-Status: No, score=-3032.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Mar 2022 16:59:07 -0000 > Maybe I should just go ahead and push this: > > https://sourceware.org/pipermail/gdb-patches/2022-March/186433.html > > This includes _csi_P, _csi_L, and _csi_S, plus a bug fix in _csi_K. > > As far as I can tell our _csi_P implementations are equivalent. Oh, I hadn't seen this (I must skip some threads / series, because I don't have time to read everything). I wasn't sure if our implementations were equivalent, there seemed to be an off-by-one difference in the row/column. I wasn't sure though, so that prompted me to start writing some unit tests for Term. I'll send a patch soon to add them. After that, you could rebase your patch on top, add some tests for the control sequences you add support for, so we can be more confident that the implementation is right. Simon