From: Luis Machado <lgustavo@codesourcery.com>
To: Pedro Alves <palves@redhat.com>, <gdb-patches@sourceware.org>
Subject: Re: [PATCH 1/2] Add rdrand/rdseed record/replay tests
Date: Wed, 01 Feb 2017 12:42:00 -0000 [thread overview]
Message-ID: <d5eb13e9-07a7-f266-965b-8eeb4aa3f339@codesourcery.com> (raw)
In-Reply-To: <38210a5e-14b5-23f6-456c-1ec1b900caf5@redhat.com>
On 02/01/2017 05:09 AM, Pedro Alves wrote:
> On 01/26/2017 05:18 PM, Luis Machado wrote:
>
>> +/* Fetches information from cpuid and sets flags indicating supported
>> + features. */
>
> What flags?
>
This is stale. The function should actually be called
check_rdrand_support, so that's what it does. In my previous design it
checked for a number of features, but i've trimmed it down.
>> +
>> +static unsigned int
>> +check_cpu_support (void)
>> +{
>> + unsigned int rdrand_mask = (1 << 30);
>> + unsigned int eax, ebx, ecx, edx;
>> +
>> + __get_cpuid(1, &eax, &ebx, &ecx, &edx);
>
Fixed locally.
next prev parent reply other threads:[~2017-02-01 12:42 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-26 17:19 Luis Machado
2017-01-26 17:19 ` [PATCH 2/2] [BZ 21005] Add support for Intel 64 rdrand and rdseed record/replay Luis Machado
2017-01-26 19:36 ` Eli Zaretskii
2017-02-01 11:11 ` Pedro Alves
2017-01-26 17:23 ` [PATCH 1/2] Add rdrand/rdseed record/replay tests Luis Machado
2017-02-01 11:11 ` Pedro Alves
2017-02-01 11:09 ` Pedro Alves
2017-02-01 12:42 ` Luis Machado [this message]
2017-02-01 12:55 ` Luis Machado
2017-02-01 15:38 ` Pedro Alves
2017-02-06 9:16 ` Luis Machado
2017-02-23 16:23 ` Yao Qi
2017-02-23 17:20 ` Luis Machado
2017-02-23 17:26 ` Luis Machado
2017-02-23 21:42 ` Yao Qi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d5eb13e9-07a7-f266-965b-8eeb4aa3f339@codesourcery.com \
--to=lgustavo@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).