Re: [PUSHED 2/5] Add [-q] [-t TYPEREGEXP] [NAMEREGEXP] args to info [args|functions|locals|variables]

[Tom de Vries <tdevries@suse.de>]

On 10/27/18 2:44 PM, Philippe Waroquiers wrote:
> @@ -4497,8 +4560,13 @@ search_symbols (const char *regexp, enum search_domain kind,
>  	    || MSYMBOL_TYPE (msymbol) == ourtype3
>  	    || MSYMBOL_TYPE (msymbol) == ourtype4)
>  	  {
> -	    if (!preg || preg->exec (MSYMBOL_NATURAL_NAME (msymbol), 0,
> -				     NULL, 0) == 0)
> +	    /* If the user wants to see var matching a type regexp,
> +	       then never give a minimal symbol.  */
> +	    if (kind != VARIABLES_DOMAIN
> +		&& !treg.has_value () /* minimal symbol has never a type ???? */
> +		&& (!preg.has_value ()
> +		    || preg->exec (MSYMBOL_NATURAL_NAME (msymbol), 0,
> +				   NULL, 0) == 0))
>  	      {
>  		/* For functions we can do a quick check of whether the
>  		   symbol might be found via find_pc_symtab.  */

Hi,

Consider this testcase with minimal symbols:
...
$ cat test.c
static int var;

int
main (void)
{
  return 0;
}
$ gcc test.c
$
...

After this commit, I don't see "var":
...
$ gdb -batch a.out -ex "info var"
All defined variables:

File init.c:
24:     const int _IO_stdin_used;
...

while before this commit, I do see "var":
...
$ gdb -batch a.out -ex "info variables"
All defined variables:

File init.c:
24:     const int _IO_stdin_used;

Non-debugging symbols:
0x0000000000400534  __GNU_EH_FRAME_HDR
0x0000000000400624  __FRAME_END__
0x0000000000600e40  __frame_dummy_init_array_entry
0x0000000000600e40  __init_array_start
0x0000000000600e48  __do_global_dtors_aux_fini_array_entry
0x0000000000600e48  __init_array_end
0x0000000000600e50  _DYNAMIC
0x0000000000601000  _GLOBAL_OFFSET_TABLE_
0x0000000000601018  __data_start
0x0000000000601018  data_start
0x0000000000601020  __dso_handle
0x0000000000601028  __TMC_END__
0x0000000000601028  __bss_start
0x0000000000601028  _edata
0x0000000000601028  completed
0x000000000060102c  var
0x0000000000601030  _end
...

I think this is a regression.

Thanks,
- Tom