From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.codeweavers.com (mail.codeweavers.com [4.36.192.163]) by sourceware.org (Postfix) with ESMTPS id AF0E63858D1E for ; Tue, 19 Mar 2024 15:59:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AF0E63858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=codeweavers.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=codeweavers.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org AF0E63858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=4.36.192.163 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710863946; cv=none; b=NtJx0rgueMQL8mNcsJ2HOqAYS7SsqJaCfeYp3HDNdd2J8eWwEU2aIjsnTEj8F1YKF0ZTCOGFsoxQyIPO+lNqJ0mxKgj9o5HD+IAoGWrVJwqHR+EKJ6YHyJQjLqdTuL1l8qSZKwVQ9LJWDV4FcfZTYb5P4au71KHFRpxaaSjSLQM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710863946; c=relaxed/simple; bh=1rSzZKxB5BPkB9mV+Ubg5hduLYTbJXH+gTea4lBmEno=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=LA7R8cG7PA5Ornoc/7GAeQnwR8dFKtvI99c9Qd9ICUZYnXaZdBwksjnc2BRsAF5aOG5fmPRRHLVWqpZV3IHM9OKrY73TrScZ7+FeE8oPDT3gFAZIQTYFC6orKvAUNwWcP9JjoIp8k/vNmvGdgcuWP2Bu/uxlj2Ond+7RFs3Fbng= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=codeweavers.com; s=s1; h=From:To:Subject:Date:Message-ID:Cc:Sender; bh=3twXt2VMKbkKrvxYEHvcRiNwQ3tBLP9PNv2MI+/qDYc=; b=hjgDCOqUG0rMVJnx533Sowomnb vIKj8FKpuf6dboZGQ6i6BGZxefg/yrVq0CmzYsuEVmYCfnxOCsZ//5crA7v5TdeTt8P9cTEjktz/V u4a/WxSyXd5Z2MVbztULqi69PBmxzeBqLhajoogmeqWT29SuDl41Ms/44JTZVHpREuonmQVCcCPL5 IUy4KGhREhIkdlwOj3pyIHVcohb/k9Au5MSReLnbpYcdlufQulvoQy4632XOG6R7oxAXdK+XjROnI J3DpHfbvxLkurVlvYerur7vdYlY/vb7AtWwcwD9wlOenwL6JsHFVlwJXqPhfsdkznrWOz8LQdbtFy zzYMWhJA==; Received: from cw141ip122.vpn.codeweavers.com ([10.69.141.122]) by mail.codeweavers.com with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1rmbrh-00AL4s-1Q; Tue, 19 Mar 2024 10:59:02 -0500 Message-ID: Date: Tue, 19 Mar 2024 16:58:59 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdb/python: Allow SIGTRAMP_FRAME python unwinders to be created. To: Guinevere Larsen , gdb-patches@sourceware.org References: <20240214215916.2655301-1-rbernon@codeweavers.com> <3d80a22b-3ccf-4da7-9c40-59a3c74ccaa8@redhat.com> Content-Language: en-US From: =?UTF-8?Q?R=C3=A9mi_Bernon?= In-Reply-To: <3d80a22b-3ccf-4da7-9c40-59a3c74ccaa8@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-6.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 3/14/24 14:00, Guinevere Larsen wrote: > On 14/02/2024 22:58, Rémi Bernon wrote: >> Wine now executes Win32 code on a separate stack for its Unix code. It >> switches from one stack to another on through specific functions, and >> without any custom unwinders, debugging Wine in Gdb will only let you >> see the frames of either the Win32 side, or the Unix side. >> >> The Win32 and Unix call stacks are actually interleaved, with Unix code >> sometimes calling back into Win32. Using a custom Python frame unwinder >> we can provide Gdb with the information it needs to join both toghether >> and show a complete interleaved call stack. However, Gdb will often stop >> unwinding as it will see the frames from one stack as inner the frames >> from the other stack. >> >> This allows to write custom unwinders to produce SIGTRAMP_FRAME typed >> frames, which bypasses this restriction and will show the Win32 / Unix >> gate as a signal frame. > > Hi! > > Sorry for taking a long time for to review. > > This looks like a good improvement. It would be nice if you could > provide a test, but I'm not sure if you are able to manufacture a > trampoline frame for a test. If it isn't possible to make a test patch > LGTM: Reviewed-By: Guinevere Larsen > > I hope a responsible maintainer is able to approve this soon (or explain > how to make a faux trampoline frame to test). > Thanks for the feedback! I have no idea how to add a test, but I'll try to figure something up. -- Rémi Bernon