From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on2054.outbound.protection.outlook.com [40.107.8.54]) by sourceware.org (Postfix) with ESMTPS id E7EF73857BA4 for ; Fri, 13 Oct 2023 14:50:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E7EF73857BA4 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=65RiQ958n2vA6U+VktYNIz4LVluuWSy8i7VcYkJaxpg=; b=s9ecND3VFbeUikVNc98YFXm9oxDrolMmoRD/N0GNJvLLiJKlyJeurmDEgSVpYfeEKuE+hFd7eeX8au3SdtIZczqyTTtfrvqhM6IAPca7mQAcbLXoDARfL+B7zcO1itMjHpocErMrN1L5Qm2/YuOPgUEYvdxHCElY7lRYKx4awH4= Received: from DU2PR04CA0323.eurprd04.prod.outlook.com (2603:10a6:10:2b5::28) by PAWPR08MB9686.eurprd08.prod.outlook.com (2603:10a6:102:2e2::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6863.44; Fri, 13 Oct 2023 14:50:19 +0000 Received: from DBAEUR03FT047.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:2b5:cafe::a0) by DU2PR04CA0323.outlook.office365.com (2603:10a6:10:2b5::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6886.31 via Frontend Transport; Fri, 13 Oct 2023 14:50:19 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT047.mail.protection.outlook.com (100.127.143.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.16 via Frontend Transport; Fri, 13 Oct 2023 14:50:19 +0000 Received: ("Tessian outbound d219f9a4f5c9:v211"); Fri, 13 Oct 2023 14:50:19 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 435d9139bc9ccde5 X-CR-MTA-TID: 64aa7808 Received: from a60e5d00d67f.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id D5278BF3-452A-46AB-AD17-ACAD1E76D46E.1; Fri, 13 Oct 2023 14:50:13 +0000 Received: from EUR04-VI1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a60e5d00d67f.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 13 Oct 2023 14:50:13 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GXe3H7t3hiPt4iOf67VwidURuxG6CiU5HQ1VpH9HaThVFr9HJW5oyXyV7OpXdv1lO4wXkOdm2khL1/5r/Qpi7o7JVHpGJX7BB68Wv8J/8h13ZdAXtMyIWushvLPtVWkZIQ+wTMPu2KSm1YdeHACRjmA3evk7t4XhJJHFBfT3qtXLuwgeogZLVsXXyoqJsR36kIm+wLmMJveRQdiAxgjnIhdaOUuXMBN7wFJdL7S9++0nAsl+mXgjGcNbbRL8YYSiWlO7I7GPKsHKLA4pN7sNi/8Vaz9fwFMFIJ2ledj337yTgHPmiiTV2Gos/bcfCAXEnTWfzWefoZwdQnNkw93RxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=65RiQ958n2vA6U+VktYNIz4LVluuWSy8i7VcYkJaxpg=; b=M4ppOILzLVT43SJxDjr1PvP3Fog27aPUepEfbIh9JEyiPON4y3n3UbMza76p8onMCT+nyw0YDV3pK5fVDMgdUH3zNaGta620yrGMj9M7/V1gjJ0Hh4NxXDJM1E27bjOry00qStSXauUfJ3HB4X8mobr1lwRNkHz+qNNEaW21q880P8m7ZRtFVEFG8R+IbvaeTDgHq7Dwwk+ZHsq2GWb510v4tRinKTfJSg+D3rElZJZh9nfdokTi1Vfk7SQByLRbpDcimfj05Uhph8U2pR83iU2s425Y8082h/W6LSTEYXIX48FyzkaSfqJunfCxRvyAxVG0kDWCt+1D/Yqfh6f5CQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=65RiQ958n2vA6U+VktYNIz4LVluuWSy8i7VcYkJaxpg=; b=s9ecND3VFbeUikVNc98YFXm9oxDrolMmoRD/N0GNJvLLiJKlyJeurmDEgSVpYfeEKuE+hFd7eeX8au3SdtIZczqyTTtfrvqhM6IAPca7mQAcbLXoDARfL+B7zcO1itMjHpocErMrN1L5Qm2/YuOPgUEYvdxHCElY7lRYKx4awH4= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) by VE1PR08MB5838.eurprd08.prod.outlook.com (2603:10a6:800:1a7::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6863.46; Fri, 13 Oct 2023 14:50:11 +0000 Received: from VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::c126:1009:20a5:195]) by VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::c126:1009:20a5:195%4]) with mapi id 15.20.6863.032; Fri, 13 Oct 2023 14:50:11 +0000 Message-ID: Date: Fri, 13 Oct 2023 15:50:09 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 05/18] [gdb/aarch64] sme: Enable SME registers and pseudo-registers Content-Language: en-US From: Luis Machado To: Tom Tromey , Luis Machado via Gdb-patches Cc: thiago.bauermann@linaro.org References: <20230918212651.660141-1-luis.machado@arm.com> <20230918212651.660141-6-luis.machado@arm.com> <87edhyu0xp.fsf@tromey.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0299.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a5::23) To VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: VI1PR08MB3919:EE_|VE1PR08MB5838:EE_|DBAEUR03FT047:EE_|PAWPR08MB9686:EE_ X-MS-Office365-Filtering-Correlation-Id: 771d74b7-3475-444a-908e-08dbcbfbb853 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: X+Zvo9IJywS948ILYKpDVFC5RTH/PmsAT6uh22clGNtRKxtU7CIxCN7DQij8y08BNqSfSX6oZB/d9WqAclVLg29K/eVZuFFi6JBra4KhQDGHAdNZUYr1s0lO1SYWIWneU/CW2ZDeR4AuTMAJpZfUe4peKVCqxCeWgwvtSfL0AFk3YZpUkLwh7bgApmVtfo+pFtudXiZyT0g0PWdb23Xjcmeb1JGnKLj9Mctek1TYRzdGddmEpLIHSOW9Y7TUDoRZCKpoC7eKESQEcN9OZC5rx6bdugUJGHSz/KMzAA8ZX5JHg2QnA/LDeXG9aGb2ps8SGN+oc4opH1PLTNFWzxdE9Uo2m9bh8Lv2os8/ksaomSKB/HIuXvCmptEetaC3WSGrQdgH3duh5rzMSx3uBxXTxXdceTB88+DkkgWAAZmHy9Zs1ZACi+HctMiJBgD4NM1nUiPU/qq68GgA1w6VAY/O2wsxz6sEBJ5ttdMWTOSyC9BylZn8D3wsA+yfcx8meGomf3cMN3+SQ9wJje4zmZFbl8q/nAgqaV2yWOgQHmyGhzhxUCmhO9blBMoH5f5/hT1ax74ZFD8loJr18n63N4hZhqSvslEjsKHvcL57Z37th+vm74rgmUnM+TnBlRdj1cb1i0Xm6SaoryTTlh1vXft7qQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR08MB3919.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(366004)(376002)(346002)(39850400004)(136003)(396003)(230922051799003)(451199024)(1800799009)(64100799003)(186009)(6512007)(6506007)(83380400001)(31686004)(2616005)(26005)(38100700002)(53546011)(6486002)(110136005)(478600001)(5660300002)(66946007)(66556008)(66476007)(41300700001)(8936002)(44832011)(8676002)(4326008)(2906002)(316002)(36756003)(86362001)(31696002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5838 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT047.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 7146108a-a2f9-4c60-8a5e-08dbcbfbb365 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7veD9qNKUZXk9d9+j4kMvKoJziZWxzO2pc+SoSJBvOF9L8P5SbWsODIbK1TtNoqQb0v6Lql1SoUvtVWJZmMamBR3CpCRcYWYzbMZePP5CWvvYUJyLQkhOr7viqhD10EiUCvujDUpC/V0lwAq0D10UCP9Un0BM6N3u4hMgdd9DkHpmq7wmswb/vpwG9q1w1mhT6YcjCevpT3zunjSQw668xI7e4s8evvYkeNRxFsw6QSFHGh3rjI5YlDpPEb7k5qhf9inEcnNILrgB9eB3HqDm8p2t/abeXR4ZrIUFx8GWZER3gLYQiYHDPMIayeaT5aBw/GljNItursqNKPJi18viOjH7iVv/XBUtv//g40/62hlkgI7csu9hjVmL+tJ438/Yy3Y7Hp6WfAS8Ho2nALpzB/ISugcV27qkRE6oPz6ZvfPti2RslEX756ob3FpNrniHrBVSrZLk1izj9zQlrYxS5khRDOxiU3tBTCqJAYuBrR/d/J2adNlmxiBHmxXpsLHLy0EI1IUqt6zolCrWzUE0sIlDALwMaOqO5vKC/nHHcJxc0ZQnRgwlK6L7Je9yy99FvrBX+qtPXDz622tuUKCFEI7hUzoBV+M9sIlK4VLhJRx4gngpnGGBCosslXTHtEk8Lu9y2Gz9auBWbnaJ5R5NWZ4VhmDzTJbynDIwYaqbNzbHPcfIHyDySdta5NpwsGC6zZ9TkiLzWBC7wVJVkN7gqgFwyuQBDgmFV5ikPDVtbpUxVxpDXemTc4rHGTj1XQrSl0l83Zbx/4XHwpOUMJpwg== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230031)(4636009)(396003)(346002)(39860400002)(136003)(376002)(230922051799003)(1800799009)(451199024)(186009)(82310400011)(64100799003)(46966006)(36840700001)(40470700004)(70206006)(26005)(70586007)(316002)(107886003)(83380400001)(40460700003)(2616005)(110136005)(40480700001)(5660300002)(336012)(44832011)(47076005)(478600001)(31696002)(53546011)(6506007)(86362001)(8936002)(8676002)(4326008)(36860700001)(82740400003)(356005)(6486002)(31686004)(81166007)(2906002)(6512007)(41300700001)(36756003)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Oct 2023 14:50:19.2458 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 771d74b7-3475-444a-908e-08dbcbfbb853 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT047.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR08MB9686 X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,KAM_DMARC_NONE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 10/13/23 15:44, Luis Machado wrote: > On 10/13/23 14:06, Tom Tromey wrote: >>>>>>> "Luis" == Luis Machado via Gdb-patches writes: >> >> Hi Luis. >> >> This patch caused a gdbserver build failure on aarch64-linux. >> >> In file included from ../../src/gdbserver/../gdb/nat/aarch64-scalable-linux-ptrace.h:36, >> from ../../src/gdbserver/linux-aarch64-low.cc:48: >> ../../src/gdbserver/linux-aarch64-low.cc: In function 'void aarch64_adjust_register_sets(const aarch64_features&)': >> ../../src/gdbserver/../gdb/nat/aarch64-scalable-linux-sigcontext.h:304:45: error: '__SVE_VQ_BYTES' was not declared in this scope; did you mean 'SVE_VQ_BYTES'? >> 304 | ((sizeof (struct user_za_header) + (__SVE_VQ_BYTES - 1)) \ >> | ^~~~~~~~~~~~~~ >> ../../src/gdbserver/../gdb/nat/aarch64-scalable-linux-sigcontext.h:325:10: note: in expansion of macro 'ZA_PT_ZA_OFFSET' >> 325 | (ZA_PT_ZA_OFFSET + ZA_PT_ZA_SIZE(vq)) >> | ^~~~~~~~~~~~~~~ >> ../../src/gdbserver/linux-aarch64-low.cc:941:28: note: in expansion of macro 'ZA_PT_SIZE' >> 941 | regset->size = ZA_PT_SIZE (features.svq); >> | ^~~~~~~~~~ >> CXX nat/aarch64-linux.o >> >> Luis> +/* Make sure we only define these if the kernel header doesn't. */ >> Luis> +#ifndef ZA_PT_SIZE >> ... >> Luis> +/* Offset from the start of struct user_za_header to the register data */ >> Luis> +#define ZA_PT_ZA_OFFSET \ >> Luis> + ((sizeof (struct user_za_header) + (__SVE_VQ_BYTES - 1)) \ >> Luis> + / __SVE_VQ_BYTES * __SVE_VQ_BYTES) >> >> Is it safe to just remove the "__" as the compiler suggests? >> >> thanks, >> Tom > > Should be, if it is defined. Let me look into it. We should use SVE_VQ_BYTES as opposed to __SVE_VQ_BYTES here. __SVE_VQ_BYTES is only available if the system headers include that definition, which older distros may not include. Does it build fine with that? If so, I can push that change, but I want to make sure the path of building aarch64 gdbserver on a system without SVE headers works. My testing systems are probably newer and have that definition available.