From: Pedro Alves <palves@redhat.com>
To: Jim Wilson <jimw@sifive.com>, gdb-patches@sourceware.org
Cc: Andrew Burgess <andrew.burgess@embecosm.com>
Subject: Re: [PATCH 0/2] RISC-V: Improve FP register support.
Date: Tue, 23 Oct 2018 11:18:00 -0000 [thread overview]
Message-ID: <d6453051-c5c3-2efd-32ac-d53a36d330fd@redhat.com> (raw)
In-Reply-To: <CAFyWVabswzH+cwN6aBgPbP-ccUjUC2iya+HUyLjYzxLgUaM_Zg@mail.gmail.com>
On 10/19/2018 10:46 PM, Jim Wilson wrote:
> The first patch improves printing of values in FP registers. A 64-bit FP
> register can hold either float or double, and they are currently printed as
> only double. The patch changes this to print them as both float and
> double. Without the patch I see
> (gdb) print $fa0
> $1 = -nan(0xfffff3f828f5c)
> With the patch I see
> (gdb) print $fa0
> $1 = {float = 1.01999998, double = -nan(0xfffff3f828f5c)}
> Tested with a gdb testsuite run on a HiFive Unleashed running fedora
> core 29. The first patch has no effect on the results.
That screams "add some test then". :-)
Thanks,
Pedro Alves
next prev parent reply other threads:[~2018-10-23 11:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-19 21:46 Jim Wilson
2018-10-19 21:49 ` [PATCH 1/2] RISC-V: Print FP regs as union of float types Jim Wilson
2018-10-20 21:38 ` Kevin Buettner
2018-10-22 21:22 ` Jim Wilson
2018-10-19 21:50 ` [PATCH 2/2] RISC-V: NaN-box FP values smaller than an FP register Jim Wilson
2018-10-20 21:39 ` Kevin Buettner
2018-10-22 21:21 ` Jim Wilson
2018-10-23 11:18 ` Pedro Alves [this message]
2018-10-25 23:49 ` [PATCH 0/2] RISC-V: Improve FP register support Jim Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d6453051-c5c3-2efd-32ac-d53a36d330fd@redhat.com \
--to=palves@redhat.com \
--cc=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
--cc=jimw@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).