From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2074.outbound.protection.outlook.com [40.107.22.74]) by sourceware.org (Postfix) with ESMTPS id 0039B3858439 for ; Tue, 19 Jul 2022 14:26:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0039B3858439 ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=cr6BaQ/Usu/mVejthMmzsYHPaIi0/9Yk5XkHA+k8WE3PD4CdvGyiIeGtbf4tAi48783/IaAOGZTqno5N/VROWU72d0FW5Z1H7OTghgBhErnypo+rYLZ1fdYFBsCmizynA4xt/XWPWOz4FFRa3q2mfqVQv5+V/mpo80Nj/vJqLNrR2rCcR90Y5ZYY6V1cEtWMuelAjh+8cC3J0Fg1hn1j+VAMRcL8DxdxnVchbyrHPcZtXPvXfQK2RUwoCEVSWYec2ePU5L/h08eD5YB4AefeiQ+NNgC7d9ze7DJBPjajD8HI2wOwSilsrspxGt6VpB4zceoj/LQupTUBJuW/gxQHqA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9U4pUdg9OpGA0+DgOIdYiKjYu70atE09PwO7g9gQT9Y=; b=ZppjyUAKD+6MUZNlQ1US7tzZeAdFvHRBxWp3RpWpSB2FmfU6O+Fe0SXtGsR+UNEeUB4gSDwgN7Gc+4yJWgfuocZNXshAdP66DAFPcO3xiYiV9dC3EhF7VGKHGXmqeeKe9xO9yy8DqTBbDHtB/J/6Qj0NyZutNOt4VzwjrijqpPgZV2ez5xfPrnJfgYxWfTu48ZKGOE+oNp7U7D/gxW6EYk/vX4uMgsTCHjk7pqQXKjgTO64hd0GmipkVi2pBUsbCatZZaEmN/wvd/s5lkehG1dJkvWY38G2rMlcSgnufZTdw0gdse97uSi7TDc+DCiXLqR/LKXQMX30HFTunFC9zZg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) Received: from AS9PR04CA0161.eurprd04.prod.outlook.com (2603:10a6:20b:530::7) by AM0PR08MB3265.eurprd08.prod.outlook.com (2603:10a6:208:56::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.12; Tue, 19 Jul 2022 14:26:19 +0000 Received: from VE1EUR03FT019.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:530:cafe::54) by AS9PR04CA0161.outlook.office365.com (2603:10a6:20b:530::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.23 via Frontend Transport; Tue, 19 Jul 2022 14:26:19 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT019.mail.protection.outlook.com (10.152.18.153) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.12 via Frontend Transport; Tue, 19 Jul 2022 14:26:19 +0000 Received: ("Tessian outbound fa99bf31ee7d:v123"); Tue, 19 Jul 2022 14:26:18 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 1f5716fe84ea579f X-CR-MTA-TID: 64aa7808 Received: from 691ab635165b.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 37E8ABA2-9F3B-401C-952B-8A90025E0809.1; Tue, 19 Jul 2022 14:26:11 +0000 Received: from EUR04-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 691ab635165b.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 19 Jul 2022 14:26:11 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dmHC9pU9tGE1zccOHA42sy4bgHrwf9vE626TT45eQgHRb99erX0nhp4GSBmOD2OCa7ZIxt7CARvFX4pWcyMVVqz/zlxDHaUBjsNaMpGNxqoYqnoXuo7SykEtGpT9gqZ/C+Co393JKub2qoL/+ToG7tsKTkAg4n+CDA1HyYr8DAG0yeWyt6gZHcphT2DH5PefActuifDerCJyFMWeYtEapkftSb5jSNEbwh49Ca1jyN0QwhqMqu5ln0d05P0xucGDgBHtlXlNjb2uzyG1+KzpsBUhHjPUOtAxIH3fft5z4ipMRFe4ogJhLOvFAcn/ER8OscuBfGkI1UIXGQAc8Lf01Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9U4pUdg9OpGA0+DgOIdYiKjYu70atE09PwO7g9gQT9Y=; b=iXiWhMeD2MiTwOy9s9D16JXBAh1gfZju9MK1OYkgK+Z/aeYhfRXe0wRHIswMbTU1Vk4f9exMQW6355JOmhv9H7Bqn2eKlm5Ba/8KR9jydS+c+wTp2WtnlsQb058rQnMFbBnvIUdmb9h4626kC+GTp4yZ9AC3oKQM82LHOcht8+kv9JWQBVpK043CCPiUzjsDY05VqRpe1fMnQZTacMF75QwHBBTvqB8OHDNFLup4CmGYoTqd9sns0qsc/WIP82pH+a7VeUtnm/c8TbgCzqZI/R2hncW6OksdhB0a4lJ7Pk4uK8JuLP69QiIawbxN5NLNk0tENPP9OTBxAinW6YZPPA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) by AM0PR08MB3684.eurprd08.prod.outlook.com (2603:10a6:208:106::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5438.14; Tue, 19 Jul 2022 14:26:02 +0000 Received: from VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::e866:af0e:2168:5ca7]) by VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::e866:af0e:2168:5ca7%5]) with mapi id 15.20.5438.023; Tue, 19 Jul 2022 14:26:02 +0000 Message-ID: Date: Tue, 19 Jul 2022 15:25:59 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH] [AArch64,v5] MTE corefile support Content-Language: en-US To: Pedro Alves , gdb-patches@sourceware.org References: <20220503215632.914608-1-luis.machado@arm.com> <20220711105753.19978-1-luis.machado@arm.com> <541510b3-fe64-45cf-c505-dc758a2b4122@palves.net> From: Luis Machado In-Reply-To: <541510b3-fe64-45cf-c505-dc758a2b4122@palves.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LNXP265CA0093.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:76::33) To VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 9708cf38-cd16-48b2-7e0f-08da6992a5a5 X-MS-TrafficTypeDiagnostic: AM0PR08MB3684:EE_|VE1EUR03FT019:EE_|AM0PR08MB3265:EE_ x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: Oni3c5980ya0GK6lVl9kX/+8IPngC976AMqNOTfdXzU0/5bAWvBBPT3apdcKvZs2905KVw7mZKd5HoP547FNu59OJN1fydW8vmjdXcZ+4OJgWLyRNuoLghWu9vOt4OxGaN7lDkoBHlIlq2G0Vj/6SI6erky+YLeNRoZ5DWyRKbG1kI9hORnToDxo0BSAE/wvM/SceUzthG4tf8rMTy5atMIiBkJVPcdSWr1GD7d53SFjkMzn0Sw4HdQVeD8DAx1mopsiJnDtzzgz4R0+SRT8co/H8Y3ofa1mKUB+cEqgJDslxbA5zppOhyrgFcGzjrqb7tRwjbO5coK+uUjV64DS84TtURFfsIafLbsgLz1BIJHXpt5cv5LhM1SUB0zDFtc0a6GtVAz5VO19Y1vIEc0PM+PWddII+SSxh/aYAOExyHCnwYaZdoMJyTcZ4UXznSpr2XcSGKUoMSlIxzXhgE3JPidoE38y13x0O/RVSLM2zih3c77SbUd075bvLqTyubXJWK5gmtFqSC5SYQNLfEynf/b60rGMo+TUV5KQX45r2yIXI98yXuzgQ9mz6MHu7mKHLH1R/7Y0qRKxh9FYvJ2+qU3yKEguioStdpRkcaFl1W9ytlsFvSHLQexIl8B5V42X92zDAdP4ZxPoA1thzoR14KChkAiUOVUsQkOCf/souGdzSWiQZZJVRdogEcYra8UPAeVrjupcE2Ve1/ULtbnD5szgMyMQKrq5HT6hp8/4tK6wHu9QCxWkHaj1dlDZ8sfAhZiMkyKADSx2togixYV2r5d/z/a6gWj+4KWHE/Zlha2vhtdX4vrpit7kXH5/outG+oKr/YASP0Kkc4sUGNYRKg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR08MB3919.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(4636009)(136003)(39860400002)(366004)(376002)(396003)(346002)(6486002)(6666004)(41300700001)(186003)(478600001)(26005)(6506007)(2616005)(38100700002)(66946007)(6512007)(66476007)(31686004)(44832011)(2906002)(8936002)(5660300002)(53546011)(8676002)(36756003)(31696002)(316002)(66556008)(86362001)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3684 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT019.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: b5ba387e-38a8-4c99-112e-08da69929b65 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hCRQJ2gVxrOxp/MeCY9yAjoaClsewxBF/TXEwllRG8hzY9x+cKFqkcXLwZDxJHipocG32V8uC2+OjNzlNGTDkwwmwZfdKjOYTCSj8Y0GZhDGQW/chf8dE0sJ8Mooc4VZzzf1E4PV2HvzkmPCZM+4sZlNeVohjK7XWglDEnvKu28M9RjhbgH6vddxpsoWvyH1VURSx47PNC8pjtKciYuNZHMDW/zvVK4bFOrJYp5PZfIXQ7C4M9SWQlpml9nVbj0Pvyf92Pp7QnNZ8a0FkURMscNsj6fwD1x+HUeOEq0MTW/QCqhyq8G+dwHbWITBGwFXaq/RoiIK0Tt8F+mPhHcWpquYcg9bzBHi7voSIwTa5rujOSTRajPHp7PkrUx622m5mwXifuhqZ5dO21bLAglIC4Gu/tel293SVzKNjqFSQIRUrQdLtDl5KV4vF3SFogVonnY5oVEM9103HtEU7kCiN60z+aIkOhqTCkKayt22KttFQyYWK13XjPwA/U+QAkT5GftDAEGupl1odwmJ2Nrh0791bCToI3Bkx0RGvgGNfHrz97z+lASTdjPDdxVqI50NLZaVtQbV7okHiLi2u7hC84wuIwXamA4/run+uUbXAmdegvRrAS6XJq0vcDmyTmAK5r6O9vMBgjZBtPMK8f5I9ArinFaA5VVmo9xECoLvPyVMxin52B3RwwdJssNqAAADTRAqSqUvAX3obVbuwQ7qnCbP3a6W8LQzmxt4LRtqeKUBfWsfnruAWf9NqW5R96KhjzJm1Vrit1+W29QY98VmeS6no8KW62EumcxZ9h3l/S1wDxnLDrmPz0xwDitfz20oKTYAIxmodVpQ1IewrMCkMA== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230016)(4636009)(376002)(39860400002)(346002)(136003)(396003)(36840700001)(46966006)(40470700004)(8936002)(478600001)(8676002)(36756003)(31686004)(316002)(86362001)(6486002)(36860700001)(40460700003)(31696002)(70206006)(70586007)(44832011)(82310400005)(81166007)(26005)(2906002)(53546011)(82740400003)(6506007)(6512007)(356005)(41300700001)(2616005)(47076005)(336012)(40480700001)(186003)(5660300002)(6666004)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jul 2022 14:26:19.0521 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9708cf38-cd16-48b2-7e0f-08da6992a5a5 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT019.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB3265 X-Spam-Status: No, score=-6.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, FORGED_SPF_HELO, KAM_DMARC_NONE, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NONE, TXREP, UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Jul 2022 14:26:23 -0000 Hi, On 7/18/22 14:54, Pedro Alves wrote: > Hi! > > This version looks good to me. Just one nit in the testcase. No need to repost for this. > > On 2022-07-11 11:57 a.m., Luis Machado wrote: >> +foreach_with_prefix mode {"sync" "async"} { >> + >> + if {$mode == "async"} { >> + lappend compile_flags "additional_flags=-DASYNC" >> + } >> + >> + standard_testfile >> + set executable "${testfile}-${mode}" >> + if {[prepare_for_testing "failed to prepare" ${executable} ${srcfile} ${compile_flags}]} { >> + return -1 > > If we hit this return while testing "sync", then "async" won't be tested either. Similarly > for the other returns below. To avoid scenarios like this (and in the future if the code evolves > to have more early returns), it's IMO better/safer to move the body of the foreach_with_prefix > to a procedure, like: > > proc test {mode} { > global srcfile testfile > > if {$mode == "async"} { > lappend compile_flags "additional_flags=-DASYNC" > } > > standard_testfile > set executable "${testfile}-${mode}" > if {[prepare_for_testing "failed to prepare" ${executable} ${srcfile} ${compile_flags}]} { > return -1 > > ... > } > > foreach_with_prefix mode {"sync" "async"} { > test $mode > } Thanks. That made it more organized. I've made the changes and pushed both the GDB and the binutils changes.