From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.freebsd.org (mx2.freebsd.org [96.47.72.81]) by sourceware.org (Postfix) with ESMTPS id C261C3858291 for ; Tue, 31 Oct 2023 16:42:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C261C3858291 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=FreeBSD.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=FreeBSD.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C261C3858291 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=96.47.72.81 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1698770560; cv=pass; b=QK8bW/u950TAEaRul7CqJKx13N1HHwzymXyVk2rEUSGF2pwip5mZbQC3jYUwOfJpwPuvHEiZT40SJ03xVxmFd4rLKuNpEGc8lsLvLRAPEqunpzcDpJQW825OnHQz9hRgDOg5vJEI8mebBG30u55aO9L82VQ7hp/b+MeN9bSXtZs= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1698770560; c=relaxed/simple; bh=MFs8zhrfnzYTtCgDedgAVVrX3nb1bdNcyUZrCVRSdVw=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=cd0FDfJWI+LxYBigZSpkT/NBuzk0cWnSYwgNU/hHhWAbnHvlyP7HlOX+XOim+wePC0j0FPjG8wd0tDlql3Ds8h/HGb3EKOV9IQ9+NZomw06Kg4SoNqa5BkeoQ1khjq98+gwbKwMVo3XVfb1fDLvgESV12y9R9kt//CoPJrq5u2c= ARC-Authentication-Results: i=2; server2.sourceware.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits)) (Client CN "mx1.freebsd.org", Issuer "R3" (verified OK)) by mx2.freebsd.org (Postfix) with ESMTPS id 4SKbXZ12s9z3XWS; Tue, 31 Oct 2023 16:42:38 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4SKbXY741tz3c3j; Tue, 31 Oct 2023 16:42:37 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1698770558; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WFYDLnrn9EJM0gjz1+GtzoFCFF06B85eZ1rAqQm6ZfQ=; b=BHuf4Mdcgglbi/0B3dro4qEY6f70XgRSCF8iDTAnYEfWUOHpB6mOeRIXWReut4oDt7WwwT lBrXzeRUu+UGt0l3eQLiT+ufvNE5S/8zue2YUjWmA1/brGw8v4W0ODsD0ER3ONjkyFNeBD eWYnQuBizRdMrNJaDPQXVpu0Yta5eydONSnndjQBB9rR6yep9aLrXOxRw2hrc5qlO7pkpI Dx4CgpN7kFAf6gLKuUxqj8A9JbqCn2cuT7zXneK8jklbuyo1p5Vjw+tbZQ/t4DJjpgF/c0 v9lhg/CZP3oYMuXyy5l2HAycgafO0DJOTTNYDAza5HL5AJ7L/2XcAwayzL5r6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1698770558; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WFYDLnrn9EJM0gjz1+GtzoFCFF06B85eZ1rAqQm6ZfQ=; b=CAUMZIrg2erQ1VgVYJEpI+2qBVOl74RR4aFN0X8SJHeqb6nsQAUQ1K2qJi7MkQ6APehg9a GzaS0zuKFdoW/pZUIM1ueCVrNr7v3cxBpzMO06eO9POuVK92QShz6Y37l7YJlphGVIKETg qgjh7OA2ZOyeycKbYsWgfsej7xheYxA7S3H/t7kvRf7yeEUYEnzwHIBd3iwN4ZQOnXuN36 0u6Tf8r/T35yrOpgLlIyQLpTuYltFKg/prGVhYlbsmpBDj4PYnbjORoYtEDZASig7ccRQW rKNKaJHQpIOduIRoWExlkFLUS2JI5VZPG5bF6uqOB5SrrxAE4gkzZYU5hXW1KQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1698770558; a=rsa-sha256; cv=none; b=NwXvFxy1hSNzX6h/VW5W26RksVVS/vV5B6IqhqI8mT01gXzDO5Aqvu2zv6tZK4MmAJ4zkW nv0IZ1NqFn9IBXQCkExNJV0yRkN0paqo4cZl6iD28k/Gqh0ggCzl/V4hmAUCUOoIkEBH9x TFr+Ef9CGA2zhH5TRz3ur6+sNneEAKFJA4b6KXf0I919xm4dgqJbJ/3ZiVSgICgKqxAsj7 XI+N4IVStuOs1L+lIcQLB53lKyFm95ldw+yQChRA9PmARHQ2nZcUofG98GUTXjIm4JaeJq 8hQcMIsxoSz9fgf1P2PK8Op9VSdpmXOxQd0n80czw/gtQj023FjVjPBpqgpqjQ== Received: from [10.0.0.43] (unknown [98.47.13.2]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4SKbXY2YTrzjpm; Tue, 31 Oct 2023 16:42:37 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: Date: Tue, 31 Oct 2023 09:41:15 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC 00/13] Proposal for a new NT_X86_CPUID core dump note Content-Language: en-US To: "George, Jini Susan" , Simon Marchi , "gdb-patches@sourceware.org" Cc: Felix , "Balasubrmanian, Vignesh" References: <20231009183617.24862-1-jhb@FreeBSD.org> <1fe75b09-7531-4d57-845c-c4a172af17fe@polymtl.ca> <53b0925d-04d5-a43b-0bd5-cf9e7d9db291@FreeBSD.org> <209db235-f5f8-ef21-a2d7-b0e06c752f11@FreeBSD.org> <1a7910b6-6e04-41c7-a274-85f9e203447b@FreeBSD.org> From: John Baldwin In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 10/27/23 4:11 AM, George, Jini Susan wrote: > [Public] > > If tomorrow, we have to deal with varying xsave layouts/ cache or any other information for different coresets, then we would need the mapping from LWPIDs to coresets. > >> One way you could store that would be to have a per-thread note storing the >> logical CPU mask (or cpuset, not sure which term Linux uses, FreeBSD uses >> cpuset) for each thread, but then you'd need perhaps some other note mapping >> logical CPU IDs to other CPU data. >> (For example, if you did have a separate NT_X86_CPUID_E_CORE, you could >> have some other note that was a short table mapping CPU IDs to CPUID notes >> (e.g. cpu 0 is NT_X86_CPUID, cpu 1 is NT_X86_CPUID, cpu 2 is >> NT_X86_CPUID_E_CORE). > > I was thinking of having the per-thread note storing the last executed cpu for the thread -- not sure if the cpuset will be needed, but I could be missing something. But yes, we will need 3 extra note types for P/E scenarios. (the per process E note, the per process cpu ID to coreset mapping note and the per thread last executed cpu/ cpuset note). > > So, yes, since we can add other required information as need be as extra notes in the future, I feel none of this should hinder the current patch with going through. Ok, sounds good. Please cc me once you post the Linux kernel patches. I opened a thread over on the LLVM discourse with the LLDB folks on this topic and the only feedback so far has been positive: https://discourse.llvm.org/t/proposal-for-a-new-nt-x86-cpuid-core-dump-note/74458 -- John Baldwin