Re: [PATCH v2 0/3] Small step in supporting AVX instructions

[Guinevere Larsen <blarsen@redhat.com>]

I've made the mistake of wondering about YMM, and noticed that this 
series fails to save the higher bits of the register.

Seeing as it isn't possible to save ymm registers directly yet (more 
info here[1][2]), and I'd like to avoid having to save ymmh and xmm in 
this series, I'll wait until the relevant series get approved before 
sending a v3 of this series

-- 
Cheers,
Guinevere Larsen
She/Her/Hers

On 6/11/24 12:44 PM, Guinevere Larsen wrote:
> This patch series is the first, very small, step in supporting AVX and
> AVX2 instructions for the record-full target. It is important that we
> support it since glibc has been using avx instructions for a long time
> (at least fedora 21), so depending on which functions an inferior uses,
> they might be very inconvenienced.
>
> Patch 1 adds capability to identify the VEX prefix, but no instruction
> support. Patches 2 and 3 add support for a total of 10 instructions,
> which covers around 5% of all AVX instructions used by system libraries
> in my fedora 39 box.
>
> While this support is extremely minimal, I figured I could propose the
> patch series early so it was open for others with more free time could
> help contributing to this :)
>
> ---
> Changes for v2:
> * stopped using "error" when finding incorrect encoding in vmov
>    instructions, as suggested by Tom Tromey.
> * Changed i386-avx-reverse test, to stop failing with clang.
> * Changed the KFAIL in gdb.reverse/step-precsave, so we don't get new
>    FAILs while AVX support is incomplete.
>
> Guinevere Larsen (3):
>    gdb: Start supporting AVX instruction
>    gdb/record: add support to vmovd and vmovq instructions
>    gdb/record: add support to AVX unpack instructions
>
>   gdb/amd64-tdep.c                              |   3 +-
>   gdb/i386-tdep.c                               | 173 ++++++++++++++-
>   gdb/i386-tdep.h                               |   2 +
>   gdb/testsuite/gdb.reverse/i386-avx-reverse.c  | 138 ++++++++++++
>   .../gdb.reverse/i386-avx-reverse.exp          | 203 ++++++++++++++++++
>   gdb/testsuite/gdb.reverse/step-precsave.exp   |   4 +-
>   6 files changed, 518 insertions(+), 5 deletions(-)
>   create mode 100644 gdb/testsuite/gdb.reverse/i386-avx-reverse.c
>   create mode 100644 gdb/testsuite/gdb.reverse/i386-avx-reverse.exp
>