From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 2A0F0384AB52 for ; Mon, 24 Jun 2024 17:49:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2A0F0384AB52 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 2A0F0384AB52 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1719251367; cv=none; b=wKLJ7z5J/k1DTazbGgDxX8Sq9mNFWKUIBczJ6jw9Ut7LB5+/spJek8hnv84oB79DweHBkC2BPV/hf3eCrCJ2438GI9hCYc9k4M4f3I9wOYLwmatAhnpT9ST6sg/JPwh46Dmo3hgY6QTdb+wxdVenAkesx1BUDoZq1bc/M2I5gYw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1719251367; c=relaxed/simple; bh=pzz19zgpRNYqy2j1k0UFrfEFJYm9JlVknmJ1fLUbeO4=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=S5/BtaZvlHWuZrxxzal6mZTghG9FpL8uP06r6SSy6Wf+ni9xfc7WFz8XKIpOGNZNzsasF7PhtCBoBzoDUahIJ0kvMvxGLmeqkYJTLUlEwXxO09c4CnUTzqgCGHFWEA3RKFvLOM435oE07qAbcIHiOw2oEN+QqHhrnb72vPCx4Lk= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1719251362; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=i4ElMrG/9+Fy2DLmV6zte6VFVdDX8QH3DNd5g6MJlOA=; b=ODKn0Qc7kFb4fcU+wYD0J8maKOoAI8e+DRj6asYDphlzOFW9s6BMD1IYAKeuEV+F0vOZEF meiSZpS1kcKdRi66J7qaqQQJKRBAEQkLqSNo03B5LcuxBYgGBVHVYx9dAvlGtfChsja07s VdZTbPmgdmhWFerVlzDUn6qic+nL7ZE= Received: from mail-oo1-f69.google.com (mail-oo1-f69.google.com [209.85.161.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-413-sKm2qMYdN0KViZ_WAuoZcA-1; Mon, 24 Jun 2024 13:49:21 -0400 X-MC-Unique: sKm2qMYdN0KViZ_WAuoZcA-1 Received: by mail-oo1-f69.google.com with SMTP id 006d021491bc7-5b30ef5bcfcso5781720eaf.0 for ; Mon, 24 Jun 2024 10:49:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719251360; x=1719856160; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=i4ElMrG/9+Fy2DLmV6zte6VFVdDX8QH3DNd5g6MJlOA=; b=WJ18VGVrnR7fGHoeUiBMvaC/IF1/XaW89bSEZm/SbEhEONfPNSZZSQFwk1jOe/yQY1 tTLf3UPUYFfR4nIenXh3BDiZ+SezjwBRuTOIQoboOAeQIjPdKGDJq77irfoSuLgo68kC HxA2fOjgA/qpxcg7A1i0Bf8UGmAFGmsffsVin1gvZsXYmMCnz9mtrKPKoDYfUzf/hJiN CULYBTL/pdmeMHg9qYj60Rgor6nkKPx3quv0KvU8DoWzeIJYt5gllNjKD9NMc3FDzwZj ul6OH4tBmYm2dr5fmGz8BAuejXbSB16W49Ai2jAq4kwRDty5ykirUw32flO5epAXmJqj kDug== X-Forwarded-Encrypted: i=1; AJvYcCXIjU60jrpKGl4SipSfGUNmW58/W3q/u2TmOdpj33TUO1rr5CsStgg0t7jcNajpX44LHTYdLMQ2kuff3OsOCwMU7QTCRFrJh29G9Q== X-Gm-Message-State: AOJu0YzNIyACF+ZZzOC9vNS/lp0FkORmK08oMuz8d5NLPbIoxFRL6ohP ZTJh5DPAGgkSl9At0VigcnSPUoG/Xio9jSL67NLb7JipGK0/CQGw5TXo1EnJWhb3ZLkleb6kNwZ cofQjETALjRRdjjxLd7tem1xR6pseNcJETB7mKccsZdaxoY5AmjTv6F9/F3w= X-Received: by 2002:a05:6358:2921:b0:1a2:67:e75 with SMTP id e5c5f4694b2df-1a23c02b8ffmr677459555d.1.1719251360420; Mon, 24 Jun 2024 10:49:20 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFWbaRGM4v9EE18EGPuwFQqlnse/tPk9/G9ciJmq7Wi9gyT1v3dcnb9BgY0cBVC1PhvqAGa+w== X-Received: by 2002:a05:6358:2921:b0:1a2:67:e75 with SMTP id e5c5f4694b2df-1a23c02b8ffmr677458255d.1.1719251360102; Mon, 24 Jun 2024 10:49:20 -0700 (PDT) Received: from ?IPV6:2804:14d:8084:92c5::1001? ([2804:14d:8084:92c5::1001]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-71b70662dadsm3049597a12.67.2024.06.24.10.49.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Jun 2024 10:49:19 -0700 (PDT) Message-ID: Date: Mon, 24 Jun 2024 14:49:16 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 0/3] Small step in supporting AVX instructions To: Guinevere Larsen , "gdb-patches@sourceware.org" References: <20240611154500.259754-1-blarsen@redhat.com> From: Guinevere Larsen In-Reply-To: <20240611154500.259754-1-blarsen@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: I've made the mistake of wondering about YMM, and noticed that this series fails to save the higher bits of the register. Seeing as it isn't possible to save ymm registers directly yet (more info here[1][2]), and I'd like to avoid having to save ymmh and xmm in this series, I'll wait until the relevant series get approved before sending a v3 of this series -- Cheers, Guinevere Larsen She/Her/Hers On 6/11/24 12:44 PM, Guinevere Larsen wrote: > This patch series is the first, very small, step in supporting AVX and > AVX2 instructions for the record-full target. It is important that we > support it since glibc has been using avx instructions for a long time > (at least fedora 21), so depending on which functions an inferior uses, > they might be very inconvenienced. > > Patch 1 adds capability to identify the VEX prefix, but no instruction > support. Patches 2 and 3 add support for a total of 10 instructions, > which covers around 5% of all AVX instructions used by system libraries > in my fedora 39 box. > > While this support is extremely minimal, I figured I could propose the > patch series early so it was open for others with more free time could > help contributing to this :) > > --- > Changes for v2: > * stopped using "error" when finding incorrect encoding in vmov > instructions, as suggested by Tom Tromey. > * Changed i386-avx-reverse test, to stop failing with clang. > * Changed the KFAIL in gdb.reverse/step-precsave, so we don't get new > FAILs while AVX support is incomplete. > > Guinevere Larsen (3): > gdb: Start supporting AVX instruction > gdb/record: add support to vmovd and vmovq instructions > gdb/record: add support to AVX unpack instructions > > gdb/amd64-tdep.c | 3 +- > gdb/i386-tdep.c | 173 ++++++++++++++- > gdb/i386-tdep.h | 2 + > gdb/testsuite/gdb.reverse/i386-avx-reverse.c | 138 ++++++++++++ > .../gdb.reverse/i386-avx-reverse.exp | 203 ++++++++++++++++++ > gdb/testsuite/gdb.reverse/step-precsave.exp | 4 +- > 6 files changed, 518 insertions(+), 5 deletions(-) > create mode 100644 gdb/testsuite/gdb.reverse/i386-avx-reverse.c > create mode 100644 gdb/testsuite/gdb.reverse/i386-avx-reverse.exp >