From: Simon Marchi <simon.marchi@polymtl.ca>
To: Andrew Burgess <andrew.burgess@embecosm.com>
Cc: Paul Koning <paulkoning@comcast.net>, gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb: Disable address space randomization for a test
Date: Tue, 31 Jul 2018 13:32:00 -0000 [thread overview]
Message-ID: <d6c06934b47ed50751e44cd7219b438f@polymtl.ca> (raw)
In-Reply-To: <20180731124749.GG3155@embecosm.com>
On 2018-07-31 08:47, Andrew Burgess wrote:
> * Simon Marchi <simon.marchi@polymtl.ca> [2018-07-30 15:49:01 -0400]:
>
>> On 2018-07-30 15:01, Andrew Burgess wrote:
>> > > Does that turn off address randomization? The keyword implies the
>> > > opposite (double negative, so "disable... off" means "turn on").
>> >
>> > That's a very good question... now I just have to figure out why my
>> > incorrect patch fixed the problem I was seeing.... watch this space...
>>
>> GDB usually disables address randomization by default, so I was also
>> wondering why this would be needed. Do you have a scenario where GDB
>> doesn't disable it by default?
>
> Thank you to you both for pointing me in the right direction.
>
> It turned out the mistake was user error. I've recently switched to a
> jenkins/docker combo to try and streamline testing my patches.
>
> When running GDB under docker I'm having to supply the '--privileged'
> flag in order to allow GDB to function correctly.
>
> The problem was that I use a separate docker instance to build GDB and
> then a set of instances to test GDB in different modes (native,
> gdbserver, etc). When testing GDB I supplied the '--privileged', but
> not when building GDB. As a result configure decided that my system
> didn't support the personality API, and so all the code to disable
> address space randomization was not compiled into GDB.
>
> As for why I failed to spot this, again user error, but far less
> interesting, I forgot I pushed a change to the scripts I used for
> comparing test results.
>
> Anyway, sorry for the noise, and thanks for the help figuring out my
> mistakes.
>
> Thanks,
> Andrew
Well, that's good information to know, thanks!
Simon
next prev parent reply other threads:[~2018-07-31 13:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-30 18:50 Andrew Burgess
2018-07-30 18:56 ` Paul Koning
2018-07-30 19:02 ` Andrew Burgess
2018-07-30 19:49 ` Simon Marchi
2018-07-31 12:47 ` Andrew Burgess
2018-07-31 13:32 ` Simon Marchi [this message]
2018-07-31 14:23 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d6c06934b47ed50751e44cd7219b438f@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
--cc=paulkoning@comcast.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).