From: Pedro Alves <palves@redhat.com>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 1/2] Eliminate target_have_continuable_watchpoint
Date: Fri, 31 Aug 2018 15:40:00 -0000 [thread overview]
Message-ID: <d6effa71-6c09-560f-632f-55bca9488576@redhat.com> (raw)
In-Reply-To: <871sae1rh9.fsf@tromey.com>
On 08/31/2018 04:32 PM, Tom Tromey wrote:
>>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:
>
> Pedro> target_have_continuable_watchpoint isn't used anywhere so remove it.
> Pedro> The property isn't necessary because checking for "continuable" is the
> Pedro> same as checking for "!steppable && !non-steppable".
>
> Pedro> /* If the *_hw_beakpoint functions have not been defined
> Pedro> diff --git a/gdb/x86-nat.h b/gdb/x86-nat.h
> Pedro> index cc27fa43b4d..f6d8a26baf9 100644
> Pedro> --- a/gdb/x86-nat.h
> Pedro> +++ b/gdb/x86-nat.h
> Pedro> @@ -76,8 +76,6 @@ struct x86_nat_target : public BaseTarget
> Pedro> the one that caused the trap. Therefore we don't need to step
> Pedro> over it. But we do need to reset the status register to avoid
> Pedro> another trap. */
> Pedro> - bool have_continuable_watchpoint () override
> Pedro> - { return true; }
>
> I think the comment just before this function should also be removed.
I thought it was still useful as is. It's describing x86 watchpoints
generically enough before a set of functions implementing watchpoints
support that I thought that it's still positioned in a good place as
is. WDYT?
Thanks,
Pedro Alves
next prev parent reply other threads:[~2018-08-31 15:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-31 15:12 [PATCH 0/2] continuable/steppable/non-steppable watchpoints Pedro Alves
2018-08-31 15:12 ` [PATCH 1/2] Eliminate target_have_continuable_watchpoint Pedro Alves
2018-08-31 15:33 ` Tom Tromey
2018-08-31 15:40 ` Pedro Alves [this message]
2018-08-31 15:43 ` Tom Tromey
2018-08-31 17:52 ` Pedro Alves
2018-08-31 15:12 ` [PATCH 2/2] Add comment describing continuable/steppable/non-steppable watchpoints Pedro Alves
2018-08-31 15:41 ` Tom Tromey
2018-08-31 17:56 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d6effa71-6c09-560f-632f-55bca9488576@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).