From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 124337 invoked by alias); 31 Aug 2018 15:40:32 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 124327 invoked by uid 89); 31 Aug 2018 15:40:31 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-25.3 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=positioned, generically X-HELO: mx1.redhat.com Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 31 Aug 2018 15:40:30 +0000 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E3BEA401EF2D; Fri, 31 Aug 2018 15:40:28 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6E15D2027EA0; Fri, 31 Aug 2018 15:40:28 +0000 (UTC) Subject: Re: [PATCH 1/2] Eliminate target_have_continuable_watchpoint To: Tom Tromey References: <20180831151159.10583-1-palves@redhat.com> <20180831151159.10583-2-palves@redhat.com> <871sae1rh9.fsf@tromey.com> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: Date: Fri, 31 Aug 2018 15:40:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <871sae1rh9.fsf@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-08/txt/msg00871.txt.bz2 On 08/31/2018 04:32 PM, Tom Tromey wrote: >>>>>> "Pedro" == Pedro Alves writes: > > Pedro> target_have_continuable_watchpoint isn't used anywhere so remove it. > Pedro> The property isn't necessary because checking for "continuable" is the > Pedro> same as checking for "!steppable && !non-steppable". > > Pedro> /* If the *_hw_beakpoint functions have not been defined > Pedro> diff --git a/gdb/x86-nat.h b/gdb/x86-nat.h > Pedro> index cc27fa43b4d..f6d8a26baf9 100644 > Pedro> --- a/gdb/x86-nat.h > Pedro> +++ b/gdb/x86-nat.h > Pedro> @@ -76,8 +76,6 @@ struct x86_nat_target : public BaseTarget > Pedro> the one that caused the trap. Therefore we don't need to step > Pedro> over it. But we do need to reset the status register to avoid > Pedro> another trap. */ > Pedro> - bool have_continuable_watchpoint () override > Pedro> - { return true; } > > I think the comment just before this function should also be removed. I thought it was still useful as is. It's describing x86 watchpoints generically enough before a set of functions implementing watchpoints support that I thought that it's still positioned in a good place as is. WDYT? Thanks, Pedro Alves