From: John Baldwin <jhb@FreeBSD.org>
To: Pedro Alves <palves@redhat.com>, Paul Koning <paulkoning@comcast.net>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH][gdb] fix unsigned overflow in charset.c
Date: Thu, 11 Oct 2018 20:16:00 -0000 [thread overview]
Message-ID: <d6f5988a-97ef-b8a3-ee58-3bd9cb8a045e@FreeBSD.org> (raw)
In-Reply-To: <c335f8db-1825-2c16-6fbb-3ff56beca97f@redhat.com>
On 10/10/18 1:50 AM, Pedro Alves wrote:
> On 10/09/2018 08:58 PM, John Baldwin wrote:
>> On 10/9/18 11:10 AM, Paul Koning wrote:
>>>
>>>
>>>> On Oct 9, 2018, at 1:57 PM, John Baldwin <jhb@FreeBSD.org> wrote:
>>>>
>>>> On 10/9/18 10:40 AM, Paul Koning wrote:
>>>>>
>>>>>
>>>>>> On Oct 9, 2018, at 1:31 PM, Pedro Alves <palves@redhat.com> wrote:
>>>>>>
>
>>>> I also ran into the same failure using LLVM's ubsan on FreeBSD but in a different
>>>> use of obstack_blank_fast(). If we wanted to fix this, I wonder if we'd instead
>>>> want to fix it centrally in obstack_blank_fast (e.g. by using a ptrdiff_t cast)
>>>> rather than fixing various consumers of the API. That would be a change to
>>>> libiberty though, not just gdb.
>>>
>>> I suppose. But casts in macros scare me, they can hide mistakes. It seems more reasonable to have the caller be responsible for creating a value of the correct type. Since it's an adjustment, I suppose the cast should be for ptrdiff_t rather than ssize_t?
>>
>> So if obstack_blank_fast() were an inline function instead of a macro, I
>> suspect it's second argument would be of type ptrdiff_t in which case the
>> equivalent "hidden" cast would happen at the function call. That said,
>> the obstack_blank() macro uses _OBSTACK_SIZE_T (which is an unsigned size_t)
>> when it declares a local variable to pass as the offset, so it seems obstack
>> really is relying on unsigned wrap around.
>
> The function is documented to take an int, at least:
>
> void obstack_blank_fast (struct obstack *obstack-ptr, int size)
>
> https://www.gnu.org/software/libc/manual/html_node/Summary-of-Obstacks.html
>
> Not sure what's best to do, but I think I leaning toward
> agreeing with Paul, in that passing down a signed negative
> integer rather than passing down a large unsigned integer
> expecting it to cast to a negative integer ends up
> being a little better.
Ok. Do you have a preference on the type to use (ssize_t vs ptrdiff_t vs
something else)? Paul's original patch used ssize_t. I'll probably patch
the one case I found in minsyms.c to match whatever we use here.
--
John Baldwin
                                                                           Â
next prev parent reply other threads:[~2018-10-11 20:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-09 17:19 Paul Koning
2018-10-09 17:31 ` Pedro Alves
2018-10-09 17:40 ` Paul Koning
2018-10-09 17:57 ` John Baldwin
2018-10-09 18:10 ` Paul Koning
2018-10-09 19:58 ` John Baldwin
2018-10-10 8:51 ` Pedro Alves
2018-10-11 20:16 ` John Baldwin [this message]
2018-10-16 15:58 ` Pedro Alves
2018-10-17 18:38 ` John Baldwin
2018-10-17 18:47 ` Paul Koning
2018-10-17 21:51 ` Pedro Alves
2018-10-17 23:28 ` Paul Koning
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d6f5988a-97ef-b8a3-ee58-3bd9cb8a045e@FreeBSD.org \
--to=jhb@freebsd.org \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=paulkoning@comcast.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).