From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by sourceware.org (Postfix) with ESMTP id B09A9394C03F for ; Wed, 1 Apr 2020 21:16:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org B09A9394C03F Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-180-TlegzR-bM7ai5VjWSJ68XQ-1; Wed, 01 Apr 2020 17:16:55 -0400 X-MC-Unique: TlegzR-bM7ai5VjWSJ68XQ-1 Received: by mail-ed1-f70.google.com with SMTP id a14so999626edx.22 for ; Wed, 01 Apr 2020 14:16:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=rnRNvTX94huk/PL/FU0uisUGnovCeKRGx70TOSbNekk=; b=MYP1ddN0uE3wF290kBklzWIvkLJX3BNW+P0NPJcnduFhSdB/7HW9TXIpteJSMnTAER xNmxjfywREWZOMpZxeTExsK0gEKHWAVNn/Zk+YT/z1Tkk1wl8L3AKTUv7rs3zLivdlEb BtWQZPJIAwkmAFwf2pifcVt+oER116fpuu6WOpmKYFeE3ne8b1rXx8kJfMgtfoqJ0xtN TSLozNKFhf8juzN7llH/UGHnucih/GH9Zgg3pIVdPvH22UyqS4ZaLE3QizuZsCUHltCw uKRG9gOaC7JsjyE+ae34/jTIZu0e4wfVnUXyuYir7RCYqg2VM1rm8k1s3iBLnUh1Jb7k LkIw== X-Gm-Message-State: AGi0PuZGQbpFp/BEEdEnXBffkOHAFu2OT2AGgpNuPoSI+efMsRa6uSFg dywmwyqJrwuaSXJgxJwgFtrBwjdkHMIjhvOfU5r/AaeqtwT0T3iDoa1WOs7BAV1DwxZ82hzwpsG gTBP8DGRVX0J146ldHM9z/w== X-Received: by 2002:a17:906:2ccc:: with SMTP id r12mr88833ejr.47.1585775814504; Wed, 01 Apr 2020 14:16:54 -0700 (PDT) X-Google-Smtp-Source: APiQypJTVJENHCcNDmKkUwqRc7u9VnmGyMZXCg70fLoncZtzuyNdNdUXOGXpa7F4PjDmYeP4EBqXLQ== X-Received: by 2002:a17:906:2ccc:: with SMTP id r12mr88818ejr.47.1585775814335; Wed, 01 Apr 2020 14:16:54 -0700 (PDT) Received: from ?IPv6:2001:8a0:f909:7b00:56ee:75ff:fe8d:232b? ([2001:8a0:f909:7b00:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id r3sm750653eju.50.2020.04.01.14.16.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Apr 2020 14:16:53 -0700 (PDT) Subject: Re: [PATCH 00/31] Turn gdbserver's linux low targets into classes To: Tankut Baris Aktemur , gdb-patches@sourceware.org References: From: Pedro Alves Message-ID: Date: Wed, 1 Apr 2020 22:16:52 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Apr 2020 21:16:58 -0000 On 3/6/20 9:31 PM, Tankut Baris Aktemur wrote: > This is a series that converts the linux low target definitions of > gdbserver into classes that derive from 'linux_process_target'. This is excellent, thanks much for doing this. Excellent work splitting things up, and I like how you used the pattern of calling the low virtual methods "low_xxx", like gdb/linux-nat.h does. Other than the two patches I replied to, this all looks great to me. Thanks, Pedro Alves