From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id AB9013858D28 for ; Wed, 15 Feb 2023 21:19:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AB9013858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca Received: from [10.0.0.111] (modemcable162.249-56-74.mc.videotron.ca [74.56.249.162]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id B0C771E110; Wed, 15 Feb 2023 16:19:08 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1676495949; bh=ffxuamvn7zwQYVoH8WPs0ot8Z7Nh70PZ0V0BicnupCo=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=RhgpstzR3PBbC2VV2SvVyR14t6tRSZv8j8ZK6HB9dP5ToTX0JIX4MA51xYMsTjKJt WwNMUT4uDAip43vYJdWx3v1+pW91xUNg82vQD6x5KFubhrPy/A6n5AnPkuK3J6lvFH uMuJinnIjkiTa50XT1bQcfYTgnW3ckIOn6cUF6sk= Message-ID: Date: Wed, 15 Feb 2023 16:19:08 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [PATCH] Do not record a rejected target description Content-Language: fr To: Tom Tromey , Andrew Burgess Cc: Tom Tromey via Gdb-patches References: <20230112193356.1133696-1-tromey@adacore.com> <87bklwmenh.fsf@redhat.com> <875yc4tawn.fsf@tromey.com> <875yc3m6in.fsf@redhat.com> <871qmqsyvu.fsf@tromey.com> From: Simon Marchi In-Reply-To: <871qmqsyvu.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2/15/23 10:59, Tom Tromey via Gdb-patches wrote: > Andrew> You are, of course, correct. I guess given we know nothing after the > Andrew> assignment can throw the what you have is fine. Hopefully we'll not add > Andrew> an error() call later. > > Andrew> Sorry for the noise. > > No, thank you for taking a look at this. I appreciate it. I'm going to > check it in now. I see: maint print c-tdesc^M There is no target description to print.^M (gdb) FAIL: gdb.xml/maint_print_struct.exp: printing tdesc with a structure and a bitfield Simon