From: Doug Gilmore <Doug.Gilmore@imgtec.com>
To: <gdb-patches@sourceware.org>
Subject: [PATCH] [mips] Fix PR 21337 v1: segfault when re-reading symbols with remote debugging.
Date: Fri, 31 Mar 2017 23:04:00 -0000 [thread overview]
Message-ID: <d7619e0c-38f4-b547-8117-8e5315313b71@imgtec.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 89 bytes --]
This is a fix to a problem that was introduced with commit g3e29f34.
OK to apply?
Doug
[-- Attachment #2: 0001-mips-Fix-PR-21337-v1-segfault-when-re-reading-symbol.patch --]
[-- Type: text/x-patch, Size: 1406 bytes --]
From 6746b67149f1158c072317e0f1a095d682e112aa Mon Sep 17 00:00:00 2001
From: Doug Gilmore <doug.gilmore@imgtec.com>
Date: Fri, 31 Mar 2017 15:41:06 -0700
Subject: [PATCH] [mips] Fix PR 21337 v1: segfault when re-reading symbols with
remote debugging.
gdb/
2017-??-?? Doug Gilmore <Doug.Gilmore@Doug.Gilmore@imgtec.com>
* symfile.c (reread_symbols): Fix PR 21337.
---
gdb/symfile.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/gdb/symfile.c b/gdb/symfile.c
index 8b79508..290b18b 100644
--- a/gdb/symfile.c
+++ b/gdb/symfile.c
@@ -2592,6 +2592,12 @@ reread_symbols (void)
/* Free the obstacks for non-reusable objfiles. */
psymbol_bcache_free (objfile->psymbol_cache);
objfile->psymbol_cache = psymbol_bcache_init ();
+
+ /* Notify objfiles that we've modified objfile sections, which now
+ needs to be done early to ensure that, for the MIPS target,
+ find_pc_section won't access stale data. PR 21337. */
+ objfiles_changed ();
+
obstack_free (&objfile->objfile_obstack, 0);
objfile->sections = NULL;
objfile->compunit_symtabs = NULL;
@@ -2678,9 +2684,6 @@ reread_symbols (void)
{
int ix;
- /* Notify objfiles that we've modified objfile sections. */
- objfiles_changed ();
-
clear_symtab_users (0);
/* clear_objfile_data for each objfile was called before freeing it and
--
1.9.1
next reply other threads:[~2017-03-31 23:04 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-31 23:04 Doug Gilmore [this message]
2017-04-10 16:01 ` Doug Gilmore
2017-04-12 18:52 ` Luis Machado
2017-04-12 21:42 ` Doug Gilmore
2017-04-13 18:56 ` [PATCH] Fix PR 21337 v2: " Doug Gilmore
2017-04-14 15:33 ` Luis Machado
2017-04-22 2:15 ` Simon Marchi
2017-04-25 18:16 ` Doug Gilmore
2017-04-27 19:46 ` Simon Marchi
2017-04-28 23:44 ` Doug Gilmore
2017-04-29 1:13 ` Luis Machado
2017-04-29 1:42 ` Simon Marchi
2017-04-29 17:12 ` Doug Gilmore
2017-04-29 23:26 ` Simon Marchi
2017-04-30 5:14 ` Doug Gilmore
2017-05-10 23:26 ` Doug Gilmore
2017-05-12 3:29 ` Simon Marchi
2017-05-12 19:24 ` Doug Gilmore
2017-05-16 23:11 ` [PATCH] Fix PR 21337 (v3): " Doug Gilmore
2017-06-06 16:08 ` [PING][PATCH] " Doug Gilmore
2017-06-23 18:20 ` [PING^2][PATCH] " Doug Gilmore
2017-06-25 11:25 ` [PATCH] " Simon Marchi
2017-06-27 17:29 ` [PATCH] Fix PR 21337 (v4): " Doug Gilmore
2017-06-27 21:35 ` Doug Gilmore
2017-06-28 2:01 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d7619e0c-38f4-b547-8117-8e5315313b71@imgtec.com \
--to=doug.gilmore@imgtec.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).