From: Pedro Alves <pedro@palves.net>
To: Jan Vrany <jan.vrany@labware.com>, gdb-patches@sourceware.org
Cc: lsix@lancelotsix.com, brobecker@adacore.com
Subject: Re: [PATCH v3 2/2] ppc: recognize all program traps
Date: Tue, 7 Dec 2021 23:30:25 +0000 [thread overview]
Message-ID: <d76d65ef-15f2-26e0-3222-51179c0161b9@palves.net> (raw)
In-Reply-To: <20211201143005.3690440-3-jan.vrany@labware.com>
Thanks! This LGTM. Just a super tiny nit to pick. No need to repost for this.
> +if { [istarget powerpc-*] } {
> + standard_testfile powerpc-trap.s
> + # Number of expected SIGTRAP's to get. This needs to be kept in sync
> + # with the source file powerpc-trap.s
SIGTRAP's -> SIGTRAPs (i.e., plural, not possessive.)
Add missing period at the end, after the filename:
... file powerpc-trap.s.
> + set expected_traps 3
> +} elseif {[istarget powerpc64*] } {
> + standard_testfile powerpc64-trap.s
> + # Number of expected SIGTRAP's to get. This needs to be kept in sync
> + # with the source file powerpc64-trap.s
Ditto.
prev parent reply other threads:[~2021-12-07 23:30 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-23 15:42 [PATCH 1/2] ppc: use 'trap' ('tw, 31, 0, 0', 0x7fe00008) as breakpoint instruction Jan Vrany
2021-11-23 15:42 ` [PATCH 2/2] ppc: recognize all program traps Jan Vrany
2021-11-24 10:43 ` Lancelot SIX
2021-11-24 10:57 ` Lancelot SIX
2021-11-24 13:09 ` [PATCH v2 0/2] " Jan Vrany
2021-11-24 13:09 ` [PATCH v2 1/2] ppc: use 'trap' ('tw, 31, 0, 0', 0x7fe00008) as breakpoint instruction Jan Vrany
2021-11-27 6:45 ` Joel Brobecker
2021-11-29 11:50 ` Jan Vrany
2021-12-01 9:23 ` Joel Brobecker
2021-11-24 13:09 ` [PATCH v2 2/2] ppc: recognize all program traps Jan Vrany
2021-11-27 6:58 ` Joel Brobecker
2021-11-30 12:17 ` Pedro Alves
2021-12-01 13:52 ` Jan Vrany
2021-12-01 14:30 ` [PATCH v3 0/2] " Jan Vrany
2021-12-01 14:30 ` [PATCH v3 1/2] ppc: use "trap" ("tw, 31, 0, 0") as breakpoint instruction Jan Vrany
2021-12-04 10:16 ` Joel Brobecker
2021-12-01 14:30 ` [PATCH v3 2/2] ppc: recognize all program traps Jan Vrany
2021-12-04 10:18 ` Joel Brobecker
2021-12-07 23:30 ` Pedro Alves [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d76d65ef-15f2-26e0-3222-51179c0161b9@palves.net \
--to=pedro@palves.net \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.vrany@labware.com \
--cc=lsix@lancelotsix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).