From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) by sourceware.org (Postfix) with ESMTPS id D3B803858C39 for ; Tue, 7 Dec 2021 23:30:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D3B803858C39 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr1-f53.google.com with SMTP id j3so947226wrp.1 for ; Tue, 07 Dec 2021 15:30:28 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=kIzEnOdU9YsdzjLd33kB34vu/X5rNNAmUn/xbooIzJA=; b=p/Z0TUvYMn3wLWb65dFn2CceeeajqRhQKERjHrLshC/4UT0Lz3pXeqeN20/vdLw7QG 1RuXpcQb3MiO3cbNjOejvZMDwmb8lQqm1RT6E/8KT44QPaoG2UNivxINngTrH9iUktKL bcHEGDIxm6+viwiwhZPmYQkiD7aC703z6hesVLq5Vi/ULnjpbxJcDmcME77WjtiXhI/l FQ4/Fw6LJP3B1nQ9omODHeUlcyACOWTo0/cUdRDjTFo16Xl1u7RUT7sYz1oAi+GAL/qF UNJe5p+AzNbVFoMzOxgtRh1LHAAZ4OqOKNr6lEgZ+JzL5/CPygNItu68VHixiSWYSdRN 6Lkg== X-Gm-Message-State: AOAM531FOAbq92w2as0S1knZ57bgNxPHiJeSyTFiCcaW3cS0bvUX/cnW A/gAaeSG2I6sqt0i+4kmmazh3pD2iHY= X-Google-Smtp-Source: ABdhPJytAGf1d31Zm+YDL+50siOGHoTT+BlLsFYf9nFK3xMTP0EqZzC9z+aihQp8stOTtGfouuwzMg== X-Received: by 2002:a5d:4901:: with SMTP id x1mr53358281wrq.473.1638919827948; Tue, 07 Dec 2021 15:30:27 -0800 (PST) Received: from ?IPV6:2001:8a0:f912:1a00:d3db:ac91:4b9e:1449? ([2001:8a0:f912:1a00:d3db:ac91:4b9e:1449]) by smtp.gmail.com with ESMTPSA id b13sm1118408wrh.32.2021.12.07.15.30.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Dec 2021 15:30:26 -0800 (PST) Message-ID: Date: Tue, 7 Dec 2021 23:30:25 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.2 Subject: Re: [PATCH v3 2/2] ppc: recognize all program traps Content-Language: en-US To: Jan Vrany , gdb-patches@sourceware.org Cc: lsix@lancelotsix.com, brobecker@adacore.com References: <20211124130926.2412617-1-jan.vrany@labware.com> <20211201143005.3690440-3-jan.vrany@labware.com> From: Pedro Alves In-Reply-To: <20211201143005.3690440-3-jan.vrany@labware.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 07 Dec 2021 23:30:30 -0000 Thanks! This LGTM. Just a super tiny nit to pick. No need to repost for this. > +if { [istarget powerpc-*] } { > + standard_testfile powerpc-trap.s > + # Number of expected SIGTRAP's to get. This needs to be kept in sync > + # with the source file powerpc-trap.s SIGTRAP's -> SIGTRAPs (i.e., plural, not possessive.) Add missing period at the end, after the filename: ... file powerpc-trap.s. > + set expected_traps 3 > +} elseif {[istarget powerpc64*] } { > + standard_testfile powerpc64-trap.s > + # Number of expected SIGTRAP's to get. This needs to be kept in sync > + # with the source file powerpc64-trap.s Ditto.