From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=xmMy=DY=suse.de=tdevries@sourceware.org>
Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c])
	by sourceware.org (Postfix) with ESMTPS id 4BA863858C2D
	for <gdb-patches@sourceware.org>; Mon,  7 Aug 2023 00:02:05 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4BA863858C2D
Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
	(No client certificate requested)
	by smtp-out1.suse.de (Postfix) with ESMTPS id 6554D218A9;
	Mon,  7 Aug 2023 00:02:04 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa;
	t=1691366524; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:
	 mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=SAI3ZAtLL7h8Yk7AntCYmnq7QsXg6txksdwy2YgEt6w=;
	b=j/o6gr1igfcl5nIQ2OzEYzVQgK2HqH1SIGXZm6iEkaRkBvfkOTM8s/WXujQOd/Uk9tKpZ7
	muRcJkAOR1LusZ4P6uuKcr45j8setvSbLfJCPSVyKK9Rt+d8mh/2jflpsNoW5KBAR6HKr1
	KvfSq9nxA5K/Gc/Nqu3FHVQ4uHLE9O0=
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de;
	s=susede2_ed25519; t=1691366524;
	h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:
	 mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=SAI3ZAtLL7h8Yk7AntCYmnq7QsXg6txksdwy2YgEt6w=;
	b=fmb4S8/X3MekHtlJL5ODpMmRFgW7cQCg2UajNL2YA4Adz8/HARq++hcWHnvil0uVQPr9/f
	HkTSHqpwWcZQrEAg==
Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512)
	(No client certificate requested)
	by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 525C513910;
	Mon,  7 Aug 2023 00:02:04 +0000 (UTC)
Received: from dovecot-director2.suse.de ([192.168.254.65])
	by imap2.suse-dmz.suse.de with ESMTPSA
	id 43YUE3w00GRrQgAAMHmgww
	(envelope-from <tdevries@suse.de>); Mon, 07 Aug 2023 00:02:04 +0000
Message-ID: <d77b2980-ccaf-5ff1-02e3-cb11a0dd042a@suse.de>
Date: Mon, 7 Aug 2023 02:01:51 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3 1/5] [gdb/symtab] Fix data race on
 index_cache::m_enabled
To: Tom Tromey <tom@tromey.com>,
 Tom de Vries via Gdb-patches <gdb-patches@sourceware.org>
References: <20230804000329.21405-1-tdevries@suse.de>
 <20230804000329.21405-2-tdevries@suse.de> <87zg337um5.fsf@tromey.com>
Content-Language: en-US
From: Tom de Vries <tdevries@suse.de>
In-Reply-To: <87zg337um5.fsf@tromey.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <gdb-patches.sourceware.org>

On 8/6/23 23:01, Tom Tromey wrote:
>>>>>> "Tom" == Tom de Vries via Gdb-patches <gdb-patches@sourceware.org> writes:
> 
> Tom> -    = gdb::thread_pool::g_thread_pool->post_task ([this, per_bfd] ()
> Tom> +    = gdb::thread_pool::g_thread_pool->post_task ([this, per_bfd,
> Tom> +						   ctx = std::move (ctx)] ()
> 
> I just noticed this.  Move captures are part of C++14, not C++11.
> 
> It doesn't look too expensive to just copy the index_cache_store_context
> instead.

Thanks for letting me know, I"ve submitted this patch ( 
https://sourceware.org/pipermail/gdb-patches/2023-August/201386.html ).

Thanks,
- Tom