From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 52422 invoked by alias); 5 Dec 2016 23:46:08 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 52406 invoked by uid 89); 5 Dec 2016 23:46:07 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_PASS,UNWANTED_LANGUAGE_BODY autolearn=ham version=3.3.2 spammy=1726, Hx-languages-length:4310, ufc X-HELO: aserp1040.oracle.com Received: from aserp1040.oracle.com (HELO aserp1040.oracle.com) (141.146.126.69) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 05 Dec 2016 23:45:57 +0000 Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id uB5NjtpF007914 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Mon, 5 Dec 2016 23:45:55 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userv0021.oracle.com (8.14.4/8.14.4) with ESMTP id uB5NjsDM021317 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Mon, 5 Dec 2016 23:45:55 GMT Received: from abhmp0009.oracle.com (abhmp0009.oracle.com [141.146.116.15]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id uB5NjsAr004886 for ; Mon, 5 Dec 2016 23:45:54 GMT Received: from [10.175.216.184] (/10.175.216.184) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 05 Dec 2016 15:45:54 -0800 To: gdb-patches@sourceware.org From: Ivo Raisr Subject: [PATCH] Bug 20928 - Decode %ccr into individual flags in sparcv9 register output Message-ID: Date: Mon, 05 Dec 2016 23:46:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------------F23A2A7EBC9AED56836B398B" X-SW-Source: 2016-12/txt/msg00146.txt.bz2 This is a multi-part message in MIME format. --------------F23A2A7EBC9AED56836B398B Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-length: 776 Please find attached a patch which fixes PR tdep/20928. Register %ccr on sparcv9 (called sparc64 in gdb's speak) contains several flags {icc,xcc}.{cnvz}. They should be properly decoded such as %fprs, %pstate and %fsr is done currently. While at it, decode also properly one-bit flags of %fsr - accrued and current exception flags were mixed up. Regression test suite was run successfully with gdb 7.11 on Solaris/sparcv9. gdb's commands 'info registers' and 'info all-registers' show %ccr with correctly decoded flags. ChangeLog entry: 2016-12-05 Ivo Raisr PR tdep/20928 Decode %ccr into individual flags in sparcv9 register output. * sparc-tdep.h: Declare %ccr type. * sparc64-tdep.c: Decode %ccr. Fix %fsr decoding. --------------F23A2A7EBC9AED56836B398B Content-Type: text/x-patch; name="ccr_decoding.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="ccr_decoding.patch" Content-length: 3740 diff -upr a/ChangeLog b/ChangeLog --- a/ChangeLog 2016-02-24 01:55:15.000000000 +0000 +++ b/ChangeLog 2016-12-05 15:38:46.962931312 +0000 @@ -1,3 +1,10 @@ +2016-12-05 Ivo Raisr + + PR tdep/20928 + Decode %ccr into individual flags in sparcv9 register output. + * sparc-tdep.h: Declare %ccr type. + * sparc64-tdep.c: Decode %ccr. Fix %fsr decoding. + 2016-01-12 H.J. Lu Sync with GCC diff -upr a/gdb/sparc-tdep.h b/gdb/sparc-tdep.h --- a/gdb/sparc-tdep.h 2016-02-09 19:19:39.000000000 +0000 +++ b/gdb/sparc-tdep.h 2016-12-05 15:25:55.187764842 +0000 @@ -76,6 +76,7 @@ struct gdbarch_tdep /* ISA-specific data types. */ struct type *sparc_psr_type; struct type *sparc_fsr_type; + struct type *sparc64_ccr_type; struct type *sparc64_pstate_type; struct type *sparc64_fsr_type; struct type *sparc64_fprs_type; diff -upr a/gdb/sparc64-tdep.c b/gdb/sparc64-tdep.c --- a/gdb/sparc64-tdep.c 2016-02-09 19:19:39.000000000 +0000 +++ b/gdb/sparc64-tdep.c 2016-12-05 15:26:04.242830444 +0000 @@ -172,6 +172,31 @@ sparc64_pstate_type (struct gdbarch *gdb } static struct type * +sparc64_ccr_type (struct gdbarch *gdbarch) +{ + struct gdbarch_tdep *tdep = gdbarch_tdep (gdbarch); + + if (tdep->sparc64_ccr_type == NULL) + { + struct type *type; + + type = arch_flags_type (gdbarch, "builtin_type_sparc64_ccr", 8); + append_flags_type_flag (type, 0, "icc.c"); + append_flags_type_flag (type, 1, "icc.v"); + append_flags_type_flag (type, 2, "icc.z"); + append_flags_type_flag (type, 3, "icc.n"); + append_flags_type_flag (type, 4, "xcc.c"); + append_flags_type_flag (type, 5, "xcc.v"); + append_flags_type_flag (type, 6, "xcc.z"); + append_flags_type_flag (type, 7, "xcc.n"); + + tdep->sparc64_ccr_type = type; + } + + return tdep->sparc64_ccr_type; +} + +static struct type * sparc64_fsr_type (struct gdbarch *gdbarch) { struct gdbarch_tdep *tdep = gdbarch_tdep (gdbarch); @@ -181,16 +206,16 @@ sparc64_fsr_type (struct gdbarch *gdbarc struct type *type; type = arch_flags_type (gdbarch, "builtin_type_sparc64_fsr", 8); - append_flags_type_flag (type, 0, "NXA"); - append_flags_type_flag (type, 1, "DZA"); - append_flags_type_flag (type, 2, "UFA"); - append_flags_type_flag (type, 3, "OFA"); - append_flags_type_flag (type, 4, "NVA"); - append_flags_type_flag (type, 5, "NXC"); - append_flags_type_flag (type, 6, "DZC"); - append_flags_type_flag (type, 7, "UFC"); - append_flags_type_flag (type, 8, "OFC"); - append_flags_type_flag (type, 9, "NVC"); + append_flags_type_flag (type, 0, "NXC"); + append_flags_type_flag (type, 1, "DZC"); + append_flags_type_flag (type, 2, "UFC"); + append_flags_type_flag (type, 3, "OFC"); + append_flags_type_flag (type, 4, "NVC"); + append_flags_type_flag (type, 5, "NXA"); + append_flags_type_flag (type, 6, "DZA"); + append_flags_type_flag (type, 7, "UFA"); + append_flags_type_flag (type, 8, "OFA"); + append_flags_type_flag (type, 9, "NVA"); append_flags_type_flag (type, 22, "NS"); append_flags_type_flag (type, 23, "NXM"); append_flags_type_flag (type, 24, "DZM"); @@ -327,7 +352,7 @@ sparc64_register_type (struct gdbarch *g if (regnum == SPARC64_ASI_REGNUM) return builtin_type (gdbarch)->builtin_int64; if (regnum == SPARC64_CCR_REGNUM) - return builtin_type (gdbarch)->builtin_int64; + return sparc64_ccr_type (gdbarch); if (regnum >= SPARC64_D0_REGNUM && regnum <= SPARC64_D62_REGNUM) return builtin_type (gdbarch)->builtin_double; if (regnum >= SPARC64_Q0_REGNUM && regnum <= SPARC64_Q60_REGNUM) --------------F23A2A7EBC9AED56836B398B--