From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by sourceware.org (Postfix) with ESMTPS id 6F66138560A1 for ; Tue, 28 Jun 2022 15:11:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6F66138560A1 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id A0D7521F86 for ; Tue, 28 Jun 2022 15:11:26 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 8E34813ACA for ; Tue, 28 Jun 2022 15:11:26 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id H952IR4au2K6bgAAMHmgww (envelope-from ) for ; Tue, 28 Jun 2022 15:11:26 +0000 Message-ID: Date: Tue, 28 Jun 2022 17:11:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: [committed][gdb/testsuite] Workaround unnecessary .s file with gfortran 4.8 Content-Language: en-US From: Tom de Vries To: gdb-patches@sourceware.org References: <20220610071129.GA16220@delia.home> In-Reply-To: <20220610071129.GA16220@delia.home> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_NUMSUBJECT, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Jun 2022 15:11:28 -0000 On 6/10/22 09:11, Tom de Vries wrote: > Hi, > > After running test-case gdb.fortran/namelist.exp with gfortran 4.8.5, I'm left > with: > ... > $ git sti > On branch master > Your branch is up to date with 'origin/master'. > > Untracked files: > (use "git add ..." to include in what will be committed) > gdb/testsuite/lib/compiler.s > > nothing added to commit but untracked files present (use "git add" to track) > ... > > We're running into PR gcc/60447, which was fixed in gcc 4.9.0. > > Workaround this by first copying the source file to the temp dir, such that > the .s file is left there instead: > ... > $ ls build/gdb/testsuite/temp// > compiler.c compiler.F90 compiler.s > ... > > Tested on x86_64-linux. > > Any comments? Committed. Thanks, - Tom > [gdb/testsuite] Workaround unnecessary .s file with gfortran 4.8 > > --- > gdb/testsuite/lib/gdb.exp | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp > index 41e1d549510..d1a4f3720c7 100644 > --- a/gdb/testsuite/lib/gdb.exp > +++ b/gdb/testsuite/lib/gdb.exp > @@ -4139,6 +4139,12 @@ proc get_compiler_info {{language "c"}} { > set cppout [read $file] > close $file > } else { > + # Copy $ifile to temp dir, to work around PR gcc/60447. This will leave the > + # superfluous .s file in the temp dir instead of in the source dir. > + set tofile [file tail $ifile] > + set tofile [standard_temp_file $tofile] > + file copy -force $ifile $tofile > + set ifile $tofile > set cppout [ gdb_compile "${ifile}" "" preprocess [list "$language" quiet getting_compiler_info] ] > } > eval log_file $saved_log