From: Guinevere Larsen <blarsen@redhat.com>
To: Kevin Buettner <kevinb@redhat.com>,
Bruno Larsen via Gdb-patches <gdb-patches@sourceware.org>
Cc: Andrew Burgess <aburgess@redhat.com>
Subject: Re: [PATCH v2] gdb/testsuite: explicitly test for stderr in gdb.mi/mi-dprintf.exp
Date: Fri, 15 Sep 2023 09:36:44 +0200 [thread overview]
Message-ID: <d8033299-86a2-60e2-804b-9089ea06633d@redhat.com> (raw)
In-Reply-To: <20230914172902.6f781b7e@f37-zws-nv>
On 15/09/2023 02:29, Kevin Buettner wrote:
> On Fri, 21 Jul 2023 11:58:10 +0200
> Bruno Larsen via Gdb-patches <gdb-patches@sourceware.org> wrote:
>
>> As mentioned in commit 3f5bbc3e2075ef5061a815c73fdc277218489f22, some
>> compilers such as clang don't add debug information about stderr by
>> default, leaving it to external debug packages.
>>
>> This commit adds a way to check if GDB has access to stderr information
>> when in MI mode, and uses this new mechanism to skip the related section
>> of the test gdb.mi/mi-dprintf.exp. It also fixes an incorrect name for a
>> test in that file.
>>
>> Co-Authored-By: Andrew Burgess <aburgess@redhat.com>
> LGTM.
>
> Approved-by: Kevin Buettner <kevinb@redhat.com>
>
Thanks pushed!
--
Cheers,
Guinevere Larsen
She/Her/Hers
prev parent reply other threads:[~2023-09-15 7:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-21 9:58 Bruno Larsen
2023-08-03 13:43 ` [PING][PATCH " Bruno Larsen
2023-08-10 13:52 ` [PINGv2][PATCH " Guinevere Larsen
2023-08-23 9:59 ` [PINGv3][PATCH " Guinevere Larsen
2023-09-14 13:03 ` [PINGv4][PATCH " Guinevere Larsen
2023-09-15 0:29 ` [PATCH " Kevin Buettner
2023-09-15 7:36 ` Guinevere Larsen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d8033299-86a2-60e2-804b-9089ea06633d@redhat.com \
--to=blarsen@redhat.com \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=kevinb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).