From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10047.outbound.protection.outlook.com [40.107.1.47]) by sourceware.org (Postfix) with ESMTPS id 773263858C2D for ; Wed, 30 Mar 2022 15:31:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 773263858C2D Received: from AS9PR06CA0774.eurprd06.prod.outlook.com (2603:10a6:20b:484::29) by DBBPR08MB4523.eurprd08.prod.outlook.com (2603:10a6:10:c8::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5102.20; Wed, 30 Mar 2022 15:31:29 +0000 Received: from VE1EUR03FT027.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:484:cafe::f3) by AS9PR06CA0774.outlook.office365.com (2603:10a6:20b:484::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.13 via Frontend Transport; Wed, 30 Mar 2022 15:31:29 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT027.mail.protection.outlook.com (10.152.18.154) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5123.19 via Frontend Transport; Wed, 30 Mar 2022 15:31:28 +0000 Received: ("Tessian outbound facaf1373bbd:v118"); Wed, 30 Mar 2022 15:31:28 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 1ee2ff58b98d1701 X-CR-MTA-TID: 64aa7808 Received: from bbaece7366b5.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id F7D1A90C-7F3E-4985-9FD6-D5B55DCAFB35.1; Wed, 30 Mar 2022 15:31:21 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id bbaece7366b5.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 30 Mar 2022 15:31:21 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WM2kuD7X+1npnzrwYyEB/pex8T38QCTXwJMCldybQX8wQXi9K/o69N6t3+caZO+DUgr90iozKZWGtpJb/ZMDis/x6uBvLi8+4lncb0paWYnvgE20waWpZg7ynZ9EPUfkdG6fwroZJyHiH534bok/gf20O+4FhY5uP2i++VcZhqA6kFbQhDtBJEbD+GNcy9dxWlGPfpDvLLLGWmJrNT1tP3w8e2LDpJTrb+oXRut2chjZ2K9PPlVi15whXjHU62S//ePZVgYxOUmDEzSMDk/mIldOXeGJfP7ToC6VUYVGh/F8FeXl2IafF1jPfhz1ETrSSftE/sT47za7Z1sBGY2ORw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UulVg+fxdMFTItHAEfG4s2pzSRjuiHuAKrCQDCAFODE=; b=hmGMQLVSsS2sibSHp3VQHsyLKZ1Qcu5QF9gnbbRCbrIIEyjA9L/MFze6WOn6lzMtNe+kFV4YbtYjPaNyyn+f13McJmL8XgwbJ7ppUPAR1uRDGlxsbgZZmcJFCzBgfpfVbHzZhFMjE7s6YV0cW2K9L2oIxF2uf77k9pBBE3cYzesa/h2HiXerMDdpXOSREjgMSGN5LuIzK+ew5rvgw3L1oDyAilOXLdWzIYQ6Aiin90IYsukcuXYw2Lv/FH9ZViCzkHSr5qGLmTVOfhYslM6VbXSgL1R9IUZuqVfxBJyLGdL6N0vop4dXc2Sbryhij+QUyb7JEaxcwfs7UVjJpT3XcA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) by DBBPR08MB6090.eurprd08.prod.outlook.com (2603:10a6:10:208::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5102.18; Wed, 30 Mar 2022 15:31:16 +0000 Received: from VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::905f:29ee:d858:516e]) by VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::905f:29ee:d858:516e%7]) with mapi id 15.20.5102.023; Wed, 30 Mar 2022 15:31:16 +0000 Message-ID: Date: Wed, 30 Mar 2022 16:31:15 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v2 00/12] FreeBSD/aarch64 hardware watchpoint support Content-Language: en-US From: Luis Machado To: John Baldwin , gdb-patches@sourceware.org References: <20220316201923.89694-1-jhb@FreeBSD.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P265CA0303.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a5::27) To VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: 1dbc0e51-d555-42a8-df84-08da12625c30 X-MS-TrafficTypeDiagnostic: DBBPR08MB6090:EE_|VE1EUR03FT027:EE_|DBBPR08MB4523:EE_ X-Microsoft-Antispam-PRVS: x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: AW1+9Z75Yg6URsX5IVi9OL91ls0aYFoD/KIJhRPleifKOp6QBbgrDdr5FGDNmfvNaxHqCuak4NrWJOGJyFjUd1owF6kG8vir+KbGXVPOT1S7bu/ySIn78wMqDvm1svP1rw2vfJ1KWQRe+MnEsNqegk84R30QH/VDPWtZI/iu9p++dM5Da+8NVXztstIq/UQA8ytfhmXPk/HjCJ4oH5DCYlLPS0ImV05X3lZGvN78WehmY8a4+YbAZKMzq8V4AjOK1/KTL4Qpv9Zs/rRhMj8I0wfyAmVEXmnUL8JvuRiLYzmP4ny4AVyGKhLFN+hRO2TiDuW19wQjeHn6L9Yh+vWjNyQUX+2Bf1JLdzXdI7y3yfDOmTg2OUnhVutV/M075WqG7A9JU/66VDa3bygwvnCGHNIxnzHEoK7Tse/4KQRJ7WStABOL7QGXI41BndTb4DNlezZsKyg8zOoLtZJT/FdY5ATygd0qMjaHdq1rdz4VnlN+PfMoXd90h/gUgKCw1RQz2MZBPjrUdkTuCsnBrRIUVlptBmyLhjbl8OoIP53lyjNEcO314gh59ugDZ10YKYYaUgbXC/cS3UwYj8tON1KqhO9kKMhM/TdoCJDyGnIMzxqSJY3rSOjktQ06EiGhIfoNBoTBQKRmzydUo6prgESq8qMlRzjyESuIAjHrQPx9hFmFU83TMuaBvA1Y1pIS6Oc7/ZqY8whY8pNiphSrscd4UIuCcSCOyQPKalI/1FoxsJU= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR08MB3919.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(4636009)(366004)(6512007)(8676002)(86362001)(44832011)(53546011)(31696002)(6506007)(2616005)(2906002)(38100700002)(8936002)(5660300002)(31686004)(36756003)(508600001)(6486002)(83380400001)(186003)(26005)(316002)(66556008)(66476007)(66946007)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB6090 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT027.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 22e6d99b-0a1b-4deb-017b-08da126254a6 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: pLz7aXexJhptbKIcnRBUUppT54C+DeOSLI0jxL4VA6bIrp5Rc0P6RqnXaJBjVYZgpVzrgT4nibKyoLYI7UL2A2xaitj7aWH57Qo7r+W4g1bT1tDrj6/KvBP66ED3xVyhmB5zX0fIqfDs0T+lEqSq94hXy5jwkC4VGNWF03KKG/aVkDiONAyDkQblLXAlEZpf2Oy9yv6M8y8XYXEr//67TB1TOyh+TJzXabaH8obDfC+8GlY1ix/3tZbW+tBgeHhU9dRK/XaAIBvvES4V09sc11ooeRlYG6pf4a4IvGYi3HoANGsnyqJ06ZzVpy1+S22zkjelEXfKv4YRM6kgLoSeeftfEC6fQBAmrw9ZpyUaWGOq3qTOBRkRXfxX4w8OuUishEI8a933EVTq3P7V4/PECixKgK26HNMGEuJKcO5e6sboWLf2NxLfYmiXlElUMLC5qXrXl/OswLwatUSxqiKBTsFQYRKU0TLTggvI649CJbkyIdULDVdAbVy2BUc7beucaFQZCQPDq71GpJX54qJrjtDI34LvH0efOgAOh0PoUpVbT1v/z8wseeSobiHkNo7bRNPDoNduEXxC9xAgQRrllBglDg6PtnU01cxr54C+DzFblUnWu+79BnDdiLwqluV5gioyYrL0l2L6d32hUMsjD0RhKS9AgS8MxNX3YDROUiSXaJj33ioabYEjkiC78wkIX2oqTO8RWIQAjnSfeMHJkw== X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230001)(4636009)(36840700001)(40470700004)(46966006)(6512007)(508600001)(6486002)(6506007)(5660300002)(44832011)(53546011)(47076005)(31686004)(36756003)(8936002)(36860700001)(2906002)(81166007)(356005)(82310400004)(8676002)(70206006)(336012)(316002)(83380400001)(40460700003)(86362001)(2616005)(186003)(26005)(70586007)(31696002)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Mar 2022 15:31:28.8054 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1dbc0e51-d555-42a8-df84-08da12625c30 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT027.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB4523 X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Mar 2022 15:31:34 -0000 Nevermind. It was a later commit. On 3/30/22 16:23, Luis Machado wrote: > Hi John, > > This breaks aarch64's build. fprintf_unfiltered doesn't exist anymore, > and this patch is still using it. > > On 3/16/22 20:19, John Baldwin wrote: >> Changes since V1: >> >> - The unordered_map<>'s in x86-nat.c and aarch64-nat.c both now store >>    objects directly rather than pointers to objects. >> >> - Trimmed "Contributed by" notices from new files. >> >> - I have compiled and (very lightly) tested this on Linux Aarch64. >>    By light testing I mean that I ran a test program with a harware >>    breakpoint set on main and it stopped correctly.  I haven't run a >>    full test suite as my Aarch64 test box is a lowly Raspberry Pi >>    for which such a run would take a fairly long time. >> >> I still have some open questions about Patch 6 from the first >> version: >> >> Patch 6 has an open question about how best to handle having a >> platform-specific hook for when debug registers have been changed. >> Right now we require the platform to supply the function that >> nat/aarch64-hw-point.c calls.  I did not choose to create an >> equivalent to x86_dr_low, but perhaps that sort of structure, or at >> least a function pointer should be used instead? >> >> There is also some messiness around the Linux-specific >> kernel_supports_any_contiguous_range workaround in patch 6. >> >> OTOH, some of the FreeBSD/x86 cleanups in the first half of the series >> (such as adding x86-fbsd-nat.*) might be nice to reuse in my XSAVE >> series, so if that half of the series is ok (first 5 patches), it >> might be nice to push that in sooner. >> >> John Baldwin (12): >>    Remove USE_SIGTRAP_SIGINFO condition for FreeBSD/x86 debug regs >>      support. >>    x86-nat: Use an unordered_map to store per-pid debug reg state. >>    x86-nat: Add x86_lookup_debug_reg_state. >>    Add an x86_fbsd_nat_target mixin class for FreeBSD x86 native targets. >>    fbsd-nat: Add a low_new_fork virtual method. >>    x86-fbsd-nat: Copy debug register state on fork. >>    nat: Split out platform-independent aarch64 debug register support. >>    aarch64: Add an aarch64_nat_target mixin class. >>    fbsd-nat: Add helper routine to fetch siginfo_t for a ptid. >>    fbsd-nat: Add a low_delete_thread virtual method. >>    fbsd-nat: Add a low_prepare_to_resume virtual method. >>    Add support for hardware breakpoints/watchpoints on FreeBSD/Aarch64. >> >>   gdb/NEWS                         |   2 + >>   gdb/aarch64-fbsd-nat.c           | 260 ++++++++++++- >>   gdb/aarch64-linux-nat.c          | 352 +---------------- >>   gdb/aarch64-nat.c                | 302 +++++++++++++++ >>   gdb/aarch64-nat.h                | 109 ++++++ >>   gdb/amd64-fbsd-nat.c             |  20 +- >>   gdb/configure.nat                |  12 +- >>   gdb/fbsd-nat.c                   |  28 +- >>   gdb/fbsd-nat.h                   |  18 + >>   gdb/i386-fbsd-nat.c              |  20 +- >>   gdb/nat/aarch64-hw-point.c       | 624 +++++++++++++++++++++++++++++++ >>   gdb/nat/aarch64-hw-point.h       | 126 +++++++ >>   gdb/nat/aarch64-linux-hw-point.c | 605 +----------------------------- >>   gdb/nat/aarch64-linux-hw-point.h | 105 +----- >>   gdb/nat/aarch64-linux.c          |   4 +- >>   gdb/x86-fbsd-nat.c               |  45 +++ >>   gdb/x86-fbsd-nat.h               |  36 ++ >>   gdb/x86-nat.c                    |  92 +---- >>   gdb/x86-nat.h                    |   5 + >>   gdbserver/configure.srv          |   1 + >>   gdbserver/linux-aarch64-low.cc   |  13 +- >>   21 files changed, 1612 insertions(+), 1167 deletions(-) >>   create mode 100644 gdb/aarch64-nat.c >>   create mode 100644 gdb/aarch64-nat.h >>   create mode 100644 gdb/nat/aarch64-hw-point.c >>   create mode 100644 gdb/nat/aarch64-hw-point.h >>   create mode 100644 gdb/x86-fbsd-nat.c >>   create mode 100644 gdb/x86-fbsd-nat.h >> >