From: Doug Gilmore <Doug.Gilmore@imgtec.com>
To: Simon Marchi <simon.marchi@polymtl.ca>,
"Maciej W. Rozycki" <macro@imgtec.com>
Cc: Luis Machado <lgustavo@codesourcery.com>, <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Fix PR 21337 (v4): segfault when re-reading symbols with remote debugging.
Date: Tue, 27 Jun 2017 21:35:00 -0000 [thread overview]
Message-ID: <d80602bb-5d91-fa45-2087-868cb7687620@imgtec.com> (raw)
In-Reply-To: <3abdfadd-9ec1-0f2c-45ed-de2184340320@imgtec.com>
On 06/27/2017 10:28 AM, Doug Gilmore wrote:
> On 06/25/2017 04:24 AM, Simon Marchi wrote:
>> Hi Doug,
>>
>> Good thing you pinged, I had completely missed it, sorry for the wait.
>>
>> +gdb_test "source $gdbfile" ".*source-command-completed.*" \
>> + "source $testfile.gdb"
>> +# Sometimes the failure only occurs on the second invocation.
>> +gdb_test "source $gdbfile" ".*source-command-completed.*" \
>> + "source $testfile.gdb"
>>
>> Tests should have unique names, so that when one fails, you know easily which one. So, perhaps "source $testfile.gdb 1" and "source $testfile.gdb 2"?
>>
>> The patch is ok with this fixed.
>>
>> Thanks,
>>
>> Simon
> Hi Simon and Maciej,
>
> Simon: I updated the tests per your request. When I asked Maciej to
> commit the patch for me, he noticed that the comment extended over the
> soft 72 column limit of, so I reformatted it. Also I corrected a typo
> and format issues in the changelog entries that he noticed.
>
> Thanks,
>
> Doug
Also I forgot to mention per Maciej's request, that my work is covered
by a copyright assignment to FSF.
Doug
next prev parent reply other threads:[~2017-06-27 21:35 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-31 23:04 [PATCH] [mips] Fix PR 21337 v1: " Doug Gilmore
2017-04-10 16:01 ` Doug Gilmore
2017-04-12 18:52 ` Luis Machado
2017-04-12 21:42 ` Doug Gilmore
2017-04-13 18:56 ` [PATCH] Fix PR 21337 v2: " Doug Gilmore
2017-04-14 15:33 ` Luis Machado
2017-04-22 2:15 ` Simon Marchi
2017-04-25 18:16 ` Doug Gilmore
2017-04-27 19:46 ` Simon Marchi
2017-04-28 23:44 ` Doug Gilmore
2017-04-29 1:13 ` Luis Machado
2017-04-29 1:42 ` Simon Marchi
2017-04-29 17:12 ` Doug Gilmore
2017-04-29 23:26 ` Simon Marchi
2017-04-30 5:14 ` Doug Gilmore
2017-05-10 23:26 ` Doug Gilmore
2017-05-12 3:29 ` Simon Marchi
2017-05-12 19:24 ` Doug Gilmore
2017-05-16 23:11 ` [PATCH] Fix PR 21337 (v3): " Doug Gilmore
2017-06-06 16:08 ` [PING][PATCH] " Doug Gilmore
2017-06-23 18:20 ` [PING^2][PATCH] " Doug Gilmore
2017-06-25 11:25 ` [PATCH] " Simon Marchi
2017-06-27 17:29 ` [PATCH] Fix PR 21337 (v4): " Doug Gilmore
2017-06-27 21:35 ` Doug Gilmore [this message]
2017-06-28 2:01 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d80602bb-5d91-fa45-2087-868cb7687620@imgtec.com \
--to=doug.gilmore@imgtec.com \
--cc=gdb-patches@sourceware.org \
--cc=lgustavo@codesourcery.com \
--cc=macro@imgtec.com \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).