From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 82112 invoked by alias); 7 Apr 2018 17:21:03 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 82101 invoked by uid 89); 7 Apr 2018 17:21:03 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=byte_vector, management X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 07 Apr 2018 17:21:01 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id w37HKt4P029874 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Sat, 7 Apr 2018 13:21:00 -0400 Received: by simark.ca (Postfix, from userid 112) id 39E631E661; Sat, 7 Apr 2018 13:20:55 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id AB50E1E4B5; Sat, 7 Apr 2018 13:20:54 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Sat, 07 Apr 2018 17:21:00 -0000 From: Simon Marchi To: Simon Marchi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Make target_read_alloc & al return vectors In-Reply-To: <1521691401-21512-1-git-send-email-simon.marchi@ericsson.com> References: <1521691401-21512-1-git-send-email-simon.marchi@ericsson.com> Message-ID: X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.4 X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Sat, 7 Apr 2018 17:20:55 +0000 X-IsSubscribed: yes X-SW-Source: 2018-04/txt/msg00119.txt.bz2 On 2018-03-22 00:03, Simon Marchi wrote: > This patch started by changing target_read_alloc_1 to return a > byte_vector, to avoid manual memory management (in target_read_alloc_1 > and in the callers). To communicate failures to the callers, it > actually returns a gdb::optional. > > Adjusting target_read_stralloc was a bit more tricky, since it wants to > return a buffer of char, and not gdb_byte. Since you can't just cast a > gdb::byte_vector into a gdb::def_vector, I made > target_read_alloc_1 templated, so both versions (that return vectors of > gdb_byte and char) are generated. Since target_read_stralloc now > returns a gdb::char_vector instead of a gdb::unique_xmalloc_ptr, > a > few callers need to be adjusted. I pushed this patch. Simon