From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id 7F7903858D1E for ; Wed, 2 Aug 2023 15:11:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7F7903858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=us.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=us.ibm.com Received: from pps.filterd (m0356516.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 372F9376012596; Wed, 2 Aug 2023 15:11:07 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : from : to : cc : date : in-reply-to : references : content-type : mime-version : content-transfer-encoding : subject; s=pp1; bh=iE5ukoAXcbQ2Uo513CF5XzWOzrfbCsC+BF/+ieKF4h4=; b=Gvd80lx+IO6XxOS05JiUuGezNpcb+8o0WfdBCJya2NrXrRh+RQDqcT0B4LZTIM06CBYn Plvypb5ZvyMrx3qytDaW9XpymAtS5UfAoXXMilsp9z7Hktrf/mXikErQ7t3uoLuRFPfx 8WhQr9Cu0rfYCfAjzw1NRTL4H3fWmOi0Sy/jMkJc2Bro5NTqzfa2EuKUOlts3hUhAjqM GCv2ffrEuILECsrWPceneImY3TEswU9GmCGNfCkqGzT/q+9ZTCcfvMUXZw3y3S9BzdFb 6CmIcFWeTa0mD0D4Ks/pcpAjXxQM8LW6Ol7/5nqY4eNcr5yvIDB7logMJ0sra3a2lDBb 5w== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3s7shk02cc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 02 Aug 2023 15:11:06 +0000 Received: from m0356516.ppops.net (m0356516.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 372F95ae012688; Wed, 2 Aug 2023 15:11:06 GMT Received: from ppma13.dal12v.mail.ibm.com (dd.9e.1632.ip4.static.sl-reverse.com [50.22.158.221]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3s7shk02bn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 02 Aug 2023 15:11:06 +0000 Received: from pps.filterd (ppma13.dal12v.mail.ibm.com [127.0.0.1]) by ppma13.dal12v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 372F9HUF017132; Wed, 2 Aug 2023 15:11:05 GMT Received: from smtprelay06.wdc07v.mail.ibm.com ([172.16.1.73]) by ppma13.dal12v.mail.ibm.com (PPS) with ESMTPS id 3s5fajw1yn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 02 Aug 2023 15:11:05 +0000 Received: from smtpav04.wdc07v.mail.ibm.com (smtpav04.wdc07v.mail.ibm.com [10.39.53.231]) by smtprelay06.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 372FB4mr44827008 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 2 Aug 2023 15:11:04 GMT Received: from smtpav04.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id ACB3258054; Wed, 2 Aug 2023 15:11:04 +0000 (GMT) Received: from smtpav04.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D5B6F58045; Wed, 2 Aug 2023 15:11:03 +0000 (GMT) Received: from li-e362e14c-2378-11b2-a85c-87d605f3c641.ibm.com (unknown [9.61.185.149]) by smtpav04.wdc07v.mail.ibm.com (Postfix) with ESMTP; Wed, 2 Aug 2023 15:11:03 +0000 (GMT) Message-ID: From: Carl Love To: Bruno Larsen , Simon Marchi , Tom de Vries , Ulrich Weigand , "gdb-patches@sourceware.org" , "pedro@palves.net" Cc: cel@us.ibm.com Date: Wed, 02 Aug 2023 08:11:03 -0700 In-Reply-To: References: <041f62e9f26fd4a536bc90c34f072985582e6237.camel@de.ibm.com> <46c2c756475ba5923d7eed97996632a08285dd42.camel@us.ibm.com> <65861786-069e-53a1-ca17-a525b6629c95@suse.de> <5be0c849abeef84d34a6ff255fb2705ca5dcb035.camel@us.ibm.com> <5e60a837-b21c-011f-c94e-e8bbf7645c5d@simark.ca> <7639de48695d52a806627b0a91979ad2e5fd9b42.camel@us.ibm.com> <9cf51eb9-c731-6f42-ab2b-a37048f25d12@simark.ca> <60c362e6dadd05754907af5f10e6f3c0423e1901.camel@us.ibm.com> <2a1d55cb-118b-d942-b315-a5f2348894f5@simark.ca> <0ab7af40f2f8d1edbceea851c37282a03c830567.camel@us.ibm.com> <90c98190-f8eb-1d64-43ce-8bab67d5caef@simark.ca> <6c58d4ce-d9ff-e1d9-398b-724859394f22@redhat.com> <38ab07a7a217bcc05be78c82d351aef73b411fb9.camel@us.ibm.com> <63d4dcba-923a-9a66-23f3-9135bb1b4521@redhat.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 (3.28.5-18.el8) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: 4Uu00EzUOSK_NbtO-dMJyXwOpdahKdlj X-Proofpoint-ORIG-GUID: W5sYsFF6cUn-Qe2pkOI1pSbUYWZp7mUQ Subject: RE: [PATCH 2/2 ] PowerPC: fix for gdb.reverse/finish-precsave.exp and gdb.reverse/finish-reverse.exp X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-08-02_11,2023-08-01_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 suspectscore=0 mlxlogscore=899 spamscore=0 phishscore=0 adultscore=0 lowpriorityscore=0 clxscore=1015 bulkscore=0 malwarescore=0 impostorscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2306200000 definitions=main-2308020133 X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,KAM_MANYTO,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Bruno: On Wed, 2023-08-02 at 11:29 +0200, Bruno Larsen wrote: > Hi Carl! > > Thanks for the thorough explanation and test. You did understood what > I > meant perfectly :) > > This is a little besides the point, but I don't see any other > patches > that touch this area and haven't been committed yet. Am I missing > something obvious? The patch that I was talking about is patch 2/2 for the reverse execution that I posted a few weeks ago. Patch 1 was for checking the gcc version. But yea, the discussion thread is getting long enough that some of this is getting lost. > > Regardless, I feel like this one change can propagate enough that it > should be its own commit anyway. > > > If you were to apply the following patch on top of the currently > > proposed patch, does gdb then execute as you expect on your > > system? I > > have tested the change on IBM Power 10. It would be good to make > > sure > > it works on your X86 system as well. I also ran the full gdb > > regression tests on Power 10 with no additional regression > > failures. > > Thanks for looking at the patch, proposed fix and the additional > > testing. > > The patch didn't apply on current master, but I added the changes > manually and tested it. It does fix the issue, and adds no > regressions. I think this little fix needs to be added to patch 2/2 for fixing the reverse execution as this fix and the patch are trying to fix the same things. I was also thinking this fix needs to be inside a if (reverse- execution) statement as it is really for the reverse execution. > > I feel like it could be worth sending an official version this patch > as > a new thread, instead of a reply to this one, to get people who > might > not be interested in reverse debugging but may have thoughts on this > patch, but maybe wait a bit to see if someone in here says anything > :) I have been thinking it is time to start a fresh thread for the patches as I think the length of this thread is losing people. Lets see if anyone else responds to this thread in a week or so. I will add the if (reverse execution) to the little fix as mentioned, update the tests, refresh the patch and then send out a new version in a new thread. Thanks for the help. Carl