From: Vyacheslav Petrishchev <vyachemail@gmail.com>
To: Christian Biesinger <cbiesinger@google.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v1] gdbsupport: Fix setting up 'development' var.
Date: Wed, 26 Feb 2020 07:40:00 -0000 [thread overview]
Message-ID: <d851ec32-e6c7-99cf-e2a0-6783ccb2a36b@gmail.com> (raw)
In-Reply-To: <CAPTJ0XFpM-Nz99zvmTYPOq6xdeeCcRp8+RASW-o2RmH9EBpuMA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 483 bytes --]
On 2/26/20 3:17 AM, Christian Biesinger wrote:
> Oh, that explains the error someone mentioned on IRC recently...
>
> I can't approve patches, but it looks like you used Debian's autoconf
> to regenerate the configure script, leading to extra changes. To avoid
> that it is best if you install and use an unmodified upstream autoconf
> directly, perhaps by installing with --prefix and running it from
> there.
>
> Christian
>
yes, it was Debian's autoconf, thanks
Vyacheslav
[-- Attachment #2: 0001-gdbsupport-Fix-setting-up-development-var.patch --]
[-- Type: text/x-patch, Size: 1737 bytes --]
From aa728d759ffee93698c282003e532398de2a6000 Mon Sep 17 00:00:00 2001
From: Vyacheslav Petrishchev <vyachemail@gmail.com>
Date: Wed, 26 Feb 2020 12:32:03 +0600
Subject: gdbsupport: Fix setting up 'development' var.
gdbsupport/ChangeLog:
* configure.ac: Added call development.sh.
* configure: Regenerate.
---
gdbsupport/ChangeLog | 5 +++++
gdbsupport/configure | 3 +++
gdbsupport/configure.ac | 3 +++
3 files changed, 11 insertions(+)
diff --git a/gdbsupport/ChangeLog b/gdbsupport/ChangeLog
index d01966ed1d..e1d4853df7 100644
--- a/gdbsupport/ChangeLog
+++ b/gdbsupport/ChangeLog
@@ -1,3 +1,8 @@
+2020-02-25 Vyacheslav Petrishchev <vyachemail@gmail.com>
+
+ * configure.ac: Added call development.sh.
+ * configure: Regenerate.
+
2020-02-19 Andrew Burgess <andrew.burgess@embecosm.com>
* configure: Regenerate.
diff --git a/gdbsupport/configure b/gdbsupport/configure
index a4871f8d5b..e7a99e3ddf 100755
--- a/gdbsupport/configure
+++ b/gdbsupport/configure
@@ -6569,6 +6569,9 @@ fi
am_cv_prog_cc_stdc=$ac_cv_prog_cc_stdc
+# Set the 'development' global.
+. $srcdir/../bfd/development.sh
+
# We require a C++11 compiler. Check if one is available, and if
# necessary, set CXX_DIALECT to some -std=xxx switch.
diff --git a/gdbsupport/configure.ac b/gdbsupport/configure.ac
index 401e16f821..ab71a3cb36 100644
--- a/gdbsupport/configure.ac
+++ b/gdbsupport/configure.ac
@@ -33,6 +33,9 @@ AC_USE_SYSTEM_EXTENSIONS
ACX_LARGEFILE
AM_PROG_CC_STDC
+# Set the 'development' global.
+. $srcdir/../bfd/development.sh
+
# We require a C++11 compiler. Check if one is available, and if
# necessary, set CXX_DIALECT to some -std=xxx switch.
AX_CXX_COMPILE_STDCXX(11, , mandatory)
--
2.20.1
next prev parent reply other threads:[~2020-02-26 7:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-25 20:33 [PATCH] " Vyacheslav Petrishchev
2020-02-25 21:18 ` Christian Biesinger via gdb-patches
2020-02-26 7:40 ` Vyacheslav Petrishchev [this message]
2020-03-05 19:36 ` [PATCH v1] " Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d851ec32-e6c7-99cf-e2a0-6783ccb2a36b@gmail.com \
--to=vyachemail@gmail.com \
--cc=cbiesinger@google.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).