From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 26E53396E85F for ; Tue, 8 Jun 2021 16:26:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 26E53396E85F Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 158GPcth021015 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 8 Jun 2021 12:25:43 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 158GPcth021015 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id C54271E01F; Tue, 8 Jun 2021 12:25:37 -0400 (EDT) Subject: Re: [PATCH] Use is/is not to check for None in python. To: Lancelot SIX , gdb-patches@sourceware.org References: <20210607225044.486370-1-lsix@lancelotsix.com> From: Simon Marchi Message-ID: Date: Tue, 8 Jun 2021 12:25:37 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Tue, 8 Jun 2021 16:25:38 +0000 X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 08 Jun 2021 16:26:47 -0000 On 2021-06-07 9:12 p.m., Mike Frysinger via Gdb-patches wrote: > On 07 Jun 2021 23:50, Lancelot SIX via Gdb-patches wrote: >> While reviewing a patch sent to the mailing list, I noticed there are few >> places where python code checks if a variable is 'None' or not by using the >> comparison operators '==' and '!='. PEP8[1], which is used as coding standard >> in GDB coding standards, recommends using 'is' / 'is not' when comparing to a >> singleton such as 'None'. > > this is correct, so all the changes look fine. but i wonder if we couldn't > make many more pythonic by treating them as bools. for example: The patch LGTM but I also agree with Mike. So Lancelot, if you want to merge it as-is, that's fine. If you want to update it as suggested by Mike, that's fine too. Simon