From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 668643857C46 for ; Tue, 21 Jul 2020 17:42:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 668643857C46 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 06LHgVxZ018997 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 21 Jul 2020 13:42:35 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 06LHgVxZ018997 Received: from [172.16.0.95] (192-222-181-218.qc.cable.ebox.net [192.222.181.218]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id B68EC1E794; Tue, 21 Jul 2020 13:42:30 -0400 (EDT) Subject: Re: [PATCH v3 2/9] gdb/jit: link to jit_objfile_data directly from the objfile struct To: "Aktemur, Tankut Baris" , "gdb-patches@sourceware.org" References: <93d9645d292b89cabe572cbe43c622a514cc06e1.1594799616.git.tankut.baris.aktemur@intel.com> <5b70a0e0-da30-c00b-30bd-e61e2fd48f46@polymtl.ca> From: Simon Marchi Message-ID: Date: Tue, 21 Jul 2020 13:42:29 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: tl Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Tue, 21 Jul 2020 17:42:31 +0000 X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Jul 2020 17:42:40 -0000 On 2020-07-21 12:25 p.m., Aktemur, Tankut Baris wrote: > However, I don't think a reset is needed at all. The `jit_breakpoint_re_set_internal` > function is invoked each time an objfile is loaded. This means, at the beginning of > a run and later when a JITer or a non-JITer solib file is loaded, the symbols will be > looked up again and the addresses will be overwritten. Or am I missing something? That makes sense, I just wanted to make sure we considered this case. Simon