From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by sourceware.org (Postfix) with ESMTPS id B2E9E3858D33 for ; Tue, 5 Dec 2023 07:56:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B2E9E3858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B2E9E3858D33 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701762975; cv=none; b=efkpJYyDqXH33jXyxY6Rx100My6JCor5OqjDdlMc/ruGI3Pu3Xzm58OwPXNUXaMww+jduHj6zUR4CYL2YWEwOO+4ZVZvrga/dm1qtzn0TEAhMq7n9Eyli6vKUuaD17YvZkIRDWFvEiCk37SfZWlWICqjPxda0GbdkQ0YIMMj1Uk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701762975; c=relaxed/simple; bh=nNmyr9vnnLJdLaBckGxF1vTSXprHNUnD/BQzJHTCxWg=; h=Message-ID:Date:MIME-Version:Subject:To:From; b=yDlATrtOpOPpwH6K1kkjcYBeqrh74mBCAx/pYypvNiMou79wDyEV6Uxh5uT8yAHN7Ka3t2n8XC93krkPjMfkyOKdsNjFtEU6uSIkQXG4TCcKsmHyt+W8iaLp/6RTFezO3qgRfQF9JV6WWtsr7fw7AADVp+AT4JFFU3kmgsZUlMU= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 994631FB74; Tue, 5 Dec 2023 07:56:13 +0000 (UTC) Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 69EBD13A2E; Tue, 5 Dec 2023 07:56:13 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id zQYuFJ3XbmUsLQAAD6G6ig (envelope-from ); Tue, 05 Dec 2023 07:56:13 +0000 Message-ID: Date: Tue, 5 Dec 2023 08:56:14 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4] gdb: Enable early init of thread pool size Content-Language: en-US To: Tom Tromey , Richard Bunt Cc: gdb-patches@sourceware.org References: <20231124161321.572511-1-richard.bunt@linaro.org> <87edgbdjyw.fsf@tromey.com> From: Tom de Vries In-Reply-To: <87edgbdjyw.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spamd-Bar: ++++ Authentication-Results: smtp-out2.suse.de; dkim=none; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=suse.de (policy=none); spf=softfail (smtp-out2.suse.de: 2a07:de40:b281:104:10:150:64:97 is neither permitted nor denied by domain of tdevries@suse.de) smtp.mailfrom=tdevries@suse.de X-Rspamd-Server: rspamd2 X-Spamd-Result: default: False [4.72 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; XM_UA_NO_VERSION(0.01)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; NEURAL_HAM_LONG(-0.99)[-0.986]; R_SPF_SOFTFAIL(4.60)[~all:c]; BAYES_HAM(-1.09)[88.14%]; RCVD_COUNT_THREE(0.00)[3]; MX_GOOD(-0.01)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[linaro.org:email]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(2.20)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; DMARC_POLICY_SOFTFAIL(0.10)[suse.de : No valid SPF, No valid DKIM,none] X-Spam-Score: 4.72 X-Rspamd-Queue-Id: 994631FB74 X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00,KAM_DMARC_STATUS,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/27/23 21:23, Tom Tromey wrote: >>>>>> "Richard" == Richard Bunt writes: > > Richard> Updates in v4. > Richard> Clamped the default number of worker threads to eight. I'm ok with this as GDB > Richard> can always be configured to use a higher number of work threads if the use case > Richard> demands it. > > I think these are fine. Thank you for doing this. > Approved-By: Tom Tromey I think this caused: ... FAIL: gdb.gdb/index-file.exp: maintenance show worker-threads ERROR: tcl error sourcing /data/vries/gdb/src/gdb/testsuite/gdb.gdb/index-file.exp. ERROR: invalid bareword "UNKNOWN" in expression "UNKNOWN / 2"; should be "$UNKNOWN" or "{UNKNOWN}" or "UNKNOWN(...)" or ... (parsing expression "UNKNOWN / 2") invoked from within "expr $worker_threads / 2" invoked from within "if { $worker_threads > 1 } { # Start GDB, but don't load a file yet. clean_restart # Adjust the number of threads to use. set reduced..." (file "/data/vries/gdb/src/gdb/testsuite/gdb.gdb/index-file.exp" line 127) invoked from within "source /data/vries/gdb/src/gdb/testsuite/gdb.gdb/index-file.exp" ("uplevel" body line 1) invoked from within "uplevel #0 source /data/vries/gdb/src/gdb/testsuite/gdb.gdb/index-file.exp" invoked from within "catch "uplevel #0 source $test_file_name"" ... Thanks, - Tom