public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tiezhu Yang <yangtiezhu@loongson.cn>
To: Hui Li <lihui@loongson.cn>, gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb: LoongArch: Silence warning about core file of lsx and lasx
Date: Thu, 21 Mar 2024 22:18:41 +0800	[thread overview]
Message-ID: <d8a109c0-90fe-5b76-02c9-f8a46ff81c7e@loongson.cn> (raw)
In-Reply-To: <20240321014130.31568-1-lihui@loongson.cn>

On 3/21/24 09:41, Hui Li wrote:
> In loongarch_iterate_over_regset_sections(), the second and third arguments
> of the iterate_over_regset_sections_cb callback function should be the regset
> size which is regsize * regnum. Otherwise when execute:
> 
> make check-gdb TESTS="gdb.base/corefile.exp"
> 
> there exists the following failed log:
> 
>    (gdb) core-file /home/fedora/community/gdb/build/gdb/testsuite/outputs/gdb.base/corefile/corefile.core
>    [New LWP 531099]
>    warning: Unexpected size of section `.reg-loongarch-lsx/531099' in core file.
>    warning: Unexpected size of section `.reg-loongarch-lasx/531099' in core file.
>    Core was generated by `/home/fedora/community/gdb/build/gdb/testsuite/outputs/gdb.base/corefile/corefile'.
>    Program terminated with signal SIGABRT, Aborted.
>    warning: Unexpected size of section `.reg-loongarch-lsx/531099' in core file.
>    warning: Unexpected size of section `.reg-loongarch-lasx/531099' in core file.
>    #0  0x00007ffff3081600 in __pthread_kill_implementation.constprop.0 () from /lib64/libc.so.6
>    (gdb) FAIL: gdb.base/corefile.exp: core-file warning-free
> 
> Signed-off-by: Hui Li <lihui@loongson.cn>

Looks good to me. Pushed.

Thanks,
Tiezhu


      reply	other threads:[~2024-03-21 14:18 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-21  1:41 Hui Li
2024-03-21 14:18 ` Tiezhu Yang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d8a109c0-90fe-5b76-02c9-f8a46ff81c7e@loongson.cn \
    --to=yangtiezhu@loongson.cn \
    --cc=gdb-patches@sourceware.org \
    --cc=lihui@loongson.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).