From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2a07:de40:b251:101:10:150:64:2]) by sourceware.org (Postfix) with ESMTPS id DB859385783B for ; Tue, 28 Nov 2023 17:03:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DB859385783B Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org DB859385783B Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:2 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701191024; cv=none; b=TCpw4v4okap8g/ZAZEbwiIRnrRmw7MNTozr8S0JQ08dr1yvgd9YNAKANelwLMYwsFZd+CLAxgWNFFBHGMHmurlKvHlnUD8h6qRouVUrlmIW64MblWXjexpktet4ebuActBGnhyG3wLrcJ6ieT5xv6Z/QIXW373ivvTDU3qgaN6w= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701191024; c=relaxed/simple; bh=D+vreP5FNp1bYyoyJjF1rl+AJm5kcA68ds9nC1jhXmE=; h=Message-ID:Date:MIME-Version:Subject:To:From; b=fseqcwW1QbVgSCpCvX2sD5j1adOnOYRHhUP+HS8IfnKpsjSNJxyt+wWghdawaCBmM7w5YRe0c6nwwLf6JC66a6Lf1UmXoh/P7UeQhgc2V8t9Kx2n6I2jklk+9twu9mH31ZO1Qou63XfqaYA4UpDC5EMajvPDXbE0AJhJr+/0n3w= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id E018E1F853; Tue, 28 Nov 2023 17:03:41 +0000 (UTC) Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id C374D13763; Tue, 28 Nov 2023 17:03:41 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id x/JNLm0dZmVFbgAAD6G6ig (envelope-from ); Tue, 28 Nov 2023 17:03:41 +0000 Message-ID: Date: Tue, 28 Nov 2023 18:03:39 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] [gdb/tui] Show focus window in status line Content-Language: en-US To: Alexandra Petlanova Hajkova Cc: gdb-patches@sourceware.org, Tom Tromey References: <20231127033908.13249-1-tdevries@suse.de> <20231127033908.13249-2-tdevries@suse.de> From: Tom de Vries In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spamd-Bar: +++++++++++ X-Spam-Score: 11.68 X-Rspamd-Server: rspamd1 Authentication-Results: smtp-out2.suse.de; dkim=none; spf=softfail (smtp-out2.suse.de: 2a07:de40:b281:104:10:150:64:97 is neither permitted nor denied by domain of tdevries@suse.de) smtp.mailfrom=tdevries@suse.de; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=suse.de (policy=none) X-Rspamd-Queue-Id: E018E1F853 X-Spamd-Result: default: False [11.68 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; XM_UA_NO_VERSION(0.01)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; R_SPF_SOFTFAIL(4.60)[~all:c]; BAYES_HAM(-0.00)[39.68%]; RCVD_COUNT_THREE(0.00)[3]; NEURAL_SPAM_SHORT(2.82)[0.941]; MX_GOOD(-0.01)[]; NEURAL_SPAM_LONG(3.06)[0.875]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:email]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(2.20)[]; MIME_TRACE(0.00)[0:+]; RCVD_IN_DNSWL_HI(-1.00)[2a07:de40:b281:106:10:150:64:167:received,2a07:de40:b281:104:10:150:64:97:from]; RCVD_TLS_ALL(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; DMARC_POLICY_SOFTFAIL(0.10)[suse.de : No valid SPF, No valid DKIM,none] X-Spam-Status: No, score=-6.4 required=5.0 tests=BAYES_00,KAM_DMARC_STATUS,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/28/23 16:22, Alexandra Petlanova Hajkova wrote: > > > On Mon, Nov 27, 2023 at 4:48 AM Tom de Vries > wrote: > > The focused window is highlighting by using active-border-kind Hi, I see now this should be "highlighted". > instead of > border-kind. > > But if the focused window is the cmd window (which is an unboxed > window), then > no highlighting is done, and it's not obvious from looking at the > screen which > window has the focus.  Instead, you have to notice the absence of > highlighting > on boxed windows, and then infer that the focus is on the unboxed > window. > > That approach stops working if there are multiple unboxed windows. > > Likewise if highlighting is switched off by setting > active-border-kind to the > same value as border-kind. > > Make it more explicit which window has the focus by mentioning it in > the status > window, like so: > ... > native process 8282 (src) In: main                      L7    PC: > 0x400525 > ... > > Tested on x86_64-linux. > --- > I can confirm it works for ppc64le Fedora Rawhide, the (src) is > neatly there. Causes no regressions. > Thanks for testing this. Since this is user-visible, I'll leave this for Tom to comment. Thanks, - Tom